[GitHub] mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test
mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180940507 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__ import absolute_import +from __future__ import division +from __future__ import print_function +from __future__ import unicode_literals + +import json + +FIXTURES_DIR = 'tests/fixtures' Review comment: You could also just have the fixtures be defined as python data structures and `json.dumps` them if/when needed. Personally I rarely write JSON as I don't like the fact it doesn't support trailing commas and triple quoted strings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test
mistercrunch commented on a change in pull request #4798: [DeckGL] Added fixtures and Deck test URL: https://github.com/apache/incubator-superset/pull/4798#discussion_r180940507 ## File path: tests/utils.py ## @@ -0,0 +1,14 @@ +# -*- coding: utf-8 -*- +from __future__ import absolute_import +from __future__ import division +from __future__ import print_function +from __future__ import unicode_literals + +import json + +FIXTURES_DIR = 'tests/fixtures' Review comment: You could also just have the fixtures be defined as python data structures and `json.dumps` them if/when needed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
