[GitHub] mistercrunch commented on issue #4405: Disable user access request

2018-02-13 Thread GitBox 
mistercrunch commented on issue #4405: Disable user access request
URL: 
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365377069
 
 
   Wait you're deleting all those tests :( 
   
   Why not just have them look at the same config/feature flag?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4405: Disable user access request

2018-02-12 Thread GitBox 
mistercrunch commented on issue #4405: Disable user access request
URL: 
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365147909
 
 
   Let's flip it off by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4405: Disable user access request

2018-02-12 Thread GitBox 
mistercrunch commented on issue #4405: Disable user access request
URL: 
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365075267
 
 
   You may want to disable the ModelView as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services