[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396

2018-03-06 Thread GitBox
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in 
#4396
URL: 
https://github.com/apache/incubator-superset/pull/4500#issuecomment-370885030
 
 
   Sounds about right, this area is pretty brittle around the no-query special 
cases...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396

2018-03-06 Thread GitBox
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in 
#4396
URL: 
https://github.com/apache/incubator-superset/pull/4500#issuecomment-370866365
 
 
   I think this broke the brittle `markup` viz in trunk. Has to do with the 
fact that the payload gets a `error` key that says `No data` and the frontend 
then refuses to render the viz.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396

2018-03-06 Thread GitBox
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in 
#4396
URL: 
https://github.com/apache/incubator-superset/pull/4500#issuecomment-370866365
 
 
   I think this broke the brittle `markup` viz. Has to do with the fact that 
the payload gets a `error` key that says `No data` and the frontend then 
refuses to render the viz.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in #4396

2018-03-05 Thread GitBox
mistercrunch commented on issue #4500: [bugfix] Fixing regression introduced in 
#4396
URL: 
https://github.com/apache/incubator-superset/pull/4500#issuecomment-370622454
 
 
   Sorry for the delay, was traveling last week with limited attention. Thanks 
@michellethomas for merging it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services