[GitHub] mistercrunch commented on issue #4659: Adding tests for the time table viz

2018-04-11 Thread GitBox
mistercrunch commented on issue #4659: Adding tests for the time table viz
URL: 
https://github.com/apache/incubator-superset/pull/4659#issuecomment-380584663
 
 
   I think for committers it's preferable for them to merge their own PRs as 
they might know things others don't or may want to merge their multiple PR in a 
certain order. @michellethomas do you have `write` access to the repo yet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4659: Adding tests for the time table viz

2018-03-22 Thread GitBox
mistercrunch commented on issue #4659: Adding tests for the time table viz
URL: 
https://github.com/apache/incubator-superset/pull/4659#issuecomment-375504866
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services