[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

2018-04-30 Thread GitBox
mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-385571371
 
 
   @fabianmenges @john-bodley I'm identifying this PR as something that could 
break things in your environment but I can't really test it in my environment 
since we don't have a lot of charts on Druid at this point. Can you 2 
review/greenlight this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

2018-04-04 Thread GitBox
mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974
 
 
   @fabianmenges do you all use extraction functions much? Do you think you can 
review/test this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

2018-04-04 Thread GitBox
mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974
 
 
   @fabianmenges do you all use extraction functions much? Do you think you can 
review this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

2018-04-02 Thread GitBox
mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378124690
 
 
   Can you bump the pydruid dep to `0.4.2` as part of this PR?
   https://github.com/apache/incubator-superset/blob/master/setup.py#L78


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services