[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-03-23 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-375690621
 
 
   @xiaohanyu @WangXueminGit I tried to implement the PR by myself and it works 
fine for the pivot visualization and it looks awesome . But you have stated on 
top of this thread that you have this feature implemented for both the table 
and pivot . How to implement this feature on plain table ? I am struck with the 
changes that needs to be done on table.js .
   
Can you share the code for plain table . It will be of great help . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995
 
 
   @xiaohanyu  Thanks for the response . So will this feature be applicable 
even for the plain table other than pivot .And can you provide the tentative 
timeline regarding when it will be merged .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995
 
 
   @xiaohanyu  Thanks for the response . So will this feature be applicable 
even for the plain table other than pivot . Any tentative timeline regarding 
when it will be merged .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995
 
 
   @xiaohanyu  Thanks for the response . So will this feature be applicable 
even for the plain table other than pivot . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995
 
 
   @xiaohanyu  okay . So will this feature be applicable even for the plain 
table other than pivot . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-365831198
 
 
   @xiaohanyu  I reinstalled superset to use this feature in my machine . But i 
could not find any row or column configuration in the Pivot table 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-05 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-363088313
 
 
   @WangXueminGit  The second one looks pretty neat . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2017-12-26 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-353954578
 
 
   @xiaohanyu This looks cool . Thanks for the reply . We are in very much need 
of this feature . Expecting it to be in superset by Jan.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2017-12-22 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-353554721
 
 
   Has this feature been implemented in superset ? . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services