[GitHub] williaster commented on issue #4609: [Explore] overriding Annotations and Layers' control tab

2018-03-13 Thread GitBox 
williaster commented on issue #4609: [Explore] overriding Annotations and 
Layers' control tab
URL: 
https://github.com/apache/incubator-superset/pull/4609#issuecomment-372836901
 
 
   thanks for updating this  LGTM, only possible suggestion would be making 
`data` a variable constant instead for easier re-use ... but as you pointed out 
re-use may be quite uncommon   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4609: [Explore] overriding Annotations and Layers' control tab

2018-03-13 Thread GitBox 
williaster commented on issue #4609: [Explore] overriding Annotations and 
Layers' control tab
URL: 
https://github.com/apache/incubator-superset/pull/4609#issuecomment-372836901
 
 
   thanks for updating this  LGTM, only possible suggestion would be making 
`data` a variable constant instead for easier re-use ... but as you pointed out 
re-use may be quite uncommon :P 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4609: [Explore] overriding Annotations and Layers' control tab

2018-03-13 Thread GitBox 
williaster commented on issue #4609: [Explore] overriding Annotations and 
Layers' control tab
URL: 
https://github.com/apache/incubator-superset/pull/4609#issuecomment-372836901
 
 
   thanks for updating this  LGTM, only possible suggestion would be making 
`data` a variable constant instead for easier re-use ... but as you pointed out 
this is uncommon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services