[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365841957 @shyam2794 Hi, this PR is not merged yet, and if you would like to have a try, you have to cherry pick this PR manually by yourself, then you have to recompile the frontend assets. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365168344 HI, all, we have updated lots of screenshots in https://github.com/apache/incubator-superset/pull/4394, please vote for us, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll push this to upstream soon. Here's a small demo of our work:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll push this to upstream. Here's a small demo of our work:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-360985412 @kartikshanbhag oh really? we think the second one looks more aligned considering layout, while the first one looks a little messy about layout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-357839164 @kartikshanbhag we're working on it from this week. It should be PRed by the end of this month. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-354039432 @shyam2794 we will start to do this from Jan, so be patient! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-353571580 @shyam2794 Right now, no. We're considering contribute our patch to upstream, maybe start from Next January. And to give you a sneak:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-328480116 Hi, @gangh Right now these feature is hosted on our own internal private codebase, and we're considering to contribute back this feature to upstream in one or two months. I wrote our work here because I was wondering how many people are interested in this kind of feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-327708132 Hi, all, Actually, we have implement similar features for pivot table and plain table, in our own branch. Some screenshot here: The final table style:  Configure table column style based on some rules (like if the value is greater than 100%, then set the cell color to red)  Configure table row style based on some rules (like if the row contains some keyword, then highlight the whole row):  I was wondering if anybody have interest in this feature. We can consider to contribute back to upstream. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
