[GitHub] xrmx commented on issue #4605: Portuguese Translation

2018-04-23 Thread GitBox
xrmx commented on issue #4605: Portuguese Translation URL: https://github.com/apache/incubator-superset/pull/4605#issuecomment-383588356 @nunohelibeires whatever works for you, if you open a new PR please work a branch and not on your master to avoid this kind of issues. -

[GitHub] xrmx commented on issue #4605: Portuguese Translation

2018-04-23 Thread GitBox
xrmx commented on issue #4605: Portuguese Translation URL: https://github.com/apache/incubator-superset/pull/4605#issuecomment-383556904 You have to rebase on upstream master not merge it. This is an automated message from th

[GitHub] xrmx commented on issue #4605: Portuguese Translation

2018-03-13 Thread GitBox
xrmx commented on issue #4605: Portuguese Translation URL: https://github.com/apache/incubator-superset/pull/4605#issuecomment-372719111 You added the messages.json to pt_br and please rename the ptpt dir to pt with git mv T

[GitHub] xrmx commented on issue #4605: Portuguese Translation

2018-03-13 Thread GitBox
xrmx commented on issue #4605: Portuguese Translation URL: https://github.com/apache/incubator-superset/pull/4605#issuecomment-372654679 Are you sure portuguese is ptpt and not just pt or pt_PT? This is an automated message f

[GitHub] xrmx commented on issue #4605: Portuguese Translation

2018-03-13 Thread GitBox
xrmx commented on issue #4605: Portuguese Translation URL: https://github.com/apache/incubator-superset/pull/4605#issuecomment-372654822 Also you are missing the messages.json for the frontend This is an automated message fro