Colm O hEigeartaigh wrote
Hi Francesco,
I don't see why the merges for SYNCOPE-203 need to be reverted as they are
not breaking anything. I would prefer to leave things as they are but not
claim full OSGi support in the 1.1.0 release.
I guess you are concerned that these issues will hold
FYI, I've just applied all proposed changes; see [1] for more details.
[1] https://cwiki.apache.org/confluence/display/SYNCOPE/Roadmap
--
View this message in context:
http://syncope-dev.1063484.n5.nabble.com/DISCUSS-Roadmap-reorganization-tp5714642p5714716.html
Sent from the syncope-dev
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/3#issuecomment-92893226
LGTM @giacomolm please go ahead and commit by running
```
git pull https://github.com/giacomolm/syncope 1_2_X
```
from a local clone of ASF's
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/4#issuecomment-93672922
@xldai thx for this, I've merged this PR.
Are you subscribed to dev@ ML? I'd need to discuss some things about OSGi
in Syncope 2.0.0
---
If your project is set
Hello there!
It seems that our INFRA guys have made their magic again and the
#apache-syncope IRC channel on FreeNode is working now :-)
We need to put this information in a proper place on our site, but for the
moment please take your time to join the discussion or take a look at IRC
logs
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/6#issuecomment-106742950
LGTM: please go ahead and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246708
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246625
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246817
--- Diff:
console/src/main/java/org/apache/syncope/console/rest/JobRestClient.java ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246879
--- Diff:
console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java ---
@@ -105,4 +108,24 @@ public void deleteExecution(final long
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246542
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246599
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246483
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246454
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31247288
--- Diff:
core/src/main/java/org/apache/syncope/core/rest/controller/AbstractJobController.java
---
@@ -158,7 +158,19 @@ protected void actionJob(final
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246416
--- Diff:
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/6#discussion_r31246859
--- Diff:
console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java ---
@@ -105,4 +108,24 @@ public void deleteExecution(final long
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30798373
--- Diff:
common/src/main/java/org/apache/syncope/common/services/ReportService.java ---
@@ -192,4 +195,25 @@
@Consumes({ MediaType.APPLICATION_XML
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30799252
--- Diff:
core/src/main/java/org/apache/syncope/core/quartz/AbstractTaskJob.java ---
@@ -176,4 +183,15 @@ public void execute(final JobExecutionContext
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30798500
--- Diff:
common/src/main/java/org/apache/syncope/common/services/ReportService.java ---
@@ -192,4 +195,25 @@
@Consumes({ MediaType.APPLICATION_XML
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30799130
--- Diff:
core/src/main/java/org/apache/syncope/core/quartz/AbstractTaskJob.java ---
@@ -176,4 +183,15 @@ public void execute(final JobExecutionContext
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30798393
--- Diff:
common/src/main/java/org/apache/syncope/common/services/TaskService.java ---
@@ -242,4 +244,24 @@ TaskExecTO execute(@NotNull @PathParam(taskId
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30798576
--- Diff:
common/src/main/java/org/apache/syncope/common/types/JobAction.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30798792
--- Diff:
core/src/main/java/org/apache/syncope/core/quartz/AbstractTaskJob.java ---
@@ -99,6 +100,11 @@
protected Task task
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/5#discussion_r30799470
--- Diff:
core/src/main/java/org/apache/syncope/core/rest/controller/ReportController.java
---
@@ -341,4 +340,24 @@ protected ReportTO resolveReference
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/5#issuecomment-104318602
All is fine @giacomolm, please go ahead and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/9#issuecomment-145786501
Please limit your changes to the link only, I see several formatting and
spacing changes.
---
If your project is set up for it, you can reply to this email and have
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/9#issuecomment-145788400
Please also send you fix against the 1_2_X branch, not master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Thanks for this PR @tmess567, I appreciate it very much.
I have added some comments to avoid duplicate classes and stay close to
what other Logic classes do.
Please fix
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Ok, let's do things one step at a time.
Please first address my comments in code, we will come up with testing
later on, ok?
---
If your project is set up for it, you can reply to this email
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Ok, the changes are just fine.
Now, you need to add a couple of methods like as follows
```java
@Test
public void issueSYNCOPE866() {
}
```
to the two
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Please also add a test case on
[ReportTemplateITCase](https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/core/ReportTemplateITCase.java
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
LGTM, please squash your three commits into one, and don't forget to
mention SYNCOPE-866 in the final commit log (the very first used here will
work, anyway).
I will merge this PR
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/22#discussion_r6732
--- Diff: pom.xml ---
@@ -404,6 +404,9 @@ under the License.
1.3.3
0.17.1
1.1.0
+2.11.0
+
2.8.1
--- End diff
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/22#discussion_r67326854
--- Diff: pom.xml ---
@@ -1177,6 +1180,16 @@ under the License.
org.webjars.bower
+angular-translate
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67346528
--- Diff: src/main/asciidoc/commondocs/guiinstaller.adoc ---
@@ -112,7 +112,7 @@ image::installer-10.png[installer-10]
Application server settings
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67346624
--- Diff: src/main/asciidoc/concepts/provisioning/provisioning.adoc ---
@@ -18,20 +18,20 @@
//
=== Provisioning
The main purpose of identity
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67346686
--- Diff: src/main/asciidoc/concepts/provisioning/provisioning.adoc ---
@@ -18,20 +18,20 @@
//
=== Provisioning
The main purpose of identity
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67346726
--- Diff: src/main/asciidoc/iam/accessmanager/accessmanager.adoc ---
@@ -17,9 +17,9 @@
// under the License.
//
=== Access Managers
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/19
You need to make the following modification, otherwise your changes won't
be included in the generated PDF / HTML:
```
ilgrosso@sequoia:~/work/syncope/syncope2$ git diff
diff --git
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/21#discussion_r67342972
--- Diff:
client/console/src/main/java/org/apache/syncope/client/console/widgets/NumberWidget.java
---
@@ -37,6 +56,57 @@ public NumberWidget(final String
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/21#discussion_r67343220
--- Diff:
client/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java
---
@@ -170,76 +175,101 @@ private WebMarkupContainer
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67346492
--- Diff: src/main/asciidoc/commondocs/guiinstaller.adoc ---
@@ -31,7 +31,7 @@ operating system. +
. http://maven.apache.org/[Apache Maven
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67349101
--- Diff:
src/main/asciidoc/workingwithapachesyncope/adminconsole/topology.adoc ---
@@ -0,0 +1,26 @@
+//
+// Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67468968
--- Diff: src/main/asciidoc/concepts/provisioning/provisioning.adoc ---
@@ -18,20 +18,20 @@
//
=== Provisioning
The main purpose of identity
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67468996
--- Diff: src/main/asciidoc/iam/accessmanager/accessmanager.adoc ---
@@ -17,9 +17,9 @@
// under the License.
//
=== Access Managers
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/19
You can of course use the text above as starting point, but it would be
nice to expand some concepts.
Same applies to wiki page.
---
If your project is set up for it, you can reply
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67349245
--- Diff:
src/main/asciidoc/workingwithapachesyncope/adminconsole/introduction.adoc ---
@@ -0,0 +1,32 @@
+//
+// Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67349728
--- Diff:
src/main/asciidoc/workingwithapachesyncope/adminconsole/realms.adoc ---
@@ -0,0 +1,63 @@
+//
+// Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67349839
--- Diff:
src/main/asciidoc/workingwithapachesyncope/adminconsole/introduction.adoc ---
@@ -0,0 +1,32 @@
+//
+// Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/19#discussion_r67351561
--- Diff:
src/main/asciidoc/workingwithapachesyncope/adminconsole/extensions.adoc ---
@@ -0,0 +1,26 @@
+//
+// Licensed to the Apache Software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488614
--- Diff:
core/workflow-java/src/main/java/org/apache/syncope/core/workflow/java/AbstractUserWorkflowAdapter.java
---
@@ -78,6 +78,10 @@ public String
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488618
--- Diff:
core/workflow-java/src/main/java/org/apache/syncope/core/workflow/java/DefaultUserWorkflowAdapter.java
---
@@ -201,4 +201,9 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488631
--- Diff:
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
---
@@ -0,0 +1,79
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488636
--- Diff:
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
---
@@ -0,0 +1,79
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488627
--- Diff:
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
---
@@ -0,0 +1,79
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488648
--- Diff:
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
---
@@ -0,0 +1,79
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r68488649
--- Diff: fit/core-reference/src/main/resources/userWorkflow.bpmn20.xml ---
@@ -1,101 +1,64 @@
-
-http://www.omg.org/spec/BPMN/20100524/MODEL
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/26
Hi @nscendoni, thanks for taking this initiative!
Could you please fill an issue on JIRA (as "new feature") where you also
provide functional high-level description?
On
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/26
Thanks for opening
[SYNCOPE-880|https://issues.apache.org/jira/browse/SYNCOPE-880], I have
commented there.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/21
Please rebase on master: b1626cf0d5b438c466ca2501b23153dc4fed6d4b has moved
`AnyTypeComparator` into a separate class file.
---
If your project is set up for it, you can reply to this email
I see now that you already posted to user mailing list:
http://syncope-user.1051894.n5.nabble.com/Getting-500-when-I-try-to-Authorize-an-user-from-syncope-database-td5708417.html
but again your message there was not accepted - as reported by Nabble -
because you did not subscribe the user
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/17#issuecomment-219069794
LGTM! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/14#discussion_r61889125
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/controllers/LoginController.js
---
@@ -76,19 +76,19 @@ angular.module("
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736265
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736063
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736276
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61735968
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -1,3 +1,5 @@
+/* global $http, AuthService */
--- End diff
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736403
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61735681
--- Diff:
client/enduser/src/main/java/org/apache/syncope/client/enduser/SyncopeEnduserApplication.java
---
@@ -154,6 +155,16 @@ public IResource
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736304
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736292
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/13#issuecomment-216232120
Hi @mteo thanks for your PR!
There are few minor comments of mine: once fixed, I'll be happy to merge it.
---
If your project is set up for it, you can reply
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/13#discussion_r61736317
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
// Declare app
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/13#issuecomment-216268832
LGTM @mteo I'll go ahead and merge, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/15#issuecomment-216865870
LGTM! I'll go ahead an merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/14#issuecomment-216546800
Nice job @mteo - could you please also review the Java code in a similar
fashion?
---
If your project is set up for it, you can reply to this email and have your
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r72031798
--- Diff: core/persistence-jpa/src/test/resources/domains/MasterContent.xml
---
@@ -461,7 +470,15 @@ under the License
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833155
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml
---
@@ -82,12 +82,47 @@ under the License
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833186
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml
---
@@ -229,4 +284,4 @@ under the License
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833798
--- Diff:
fit/core-reference/src/test/java/org/apache/syncope/fit/core/RecertificationITCase.java
---
@@ -0,0 +1,90 @@
+/*
+ * Copyright 2016
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833002
--- Diff:
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
---
@@ -0,0 +1,102
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833076
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml
---
@@ -82,12 +82,47 @@ under the License
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833609
--- Diff:
fit/core-reference/src/test/java/org/apache/syncope/fit/core/RecertificationITCase.java
---
@@ -0,0 +1,90 @@
+/*
--- End diff
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/26
@nscendoni thanks for your work: I have added some minor comments.
Once addressed, please also rebase and squash and I'd say we'll be ready to
merge this PR.
As you might have seen
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/28
I have made some adjustments to Maven and now things seem to work fine:
please review and apply the attached
[SYNCOPE-809-Maven-diff.txt](https://github.com/apache/syncope/files/377683/SYNCOPE-809
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833259
--- Diff:
core/workflow-api/src/main/java/org/apache/syncope/core/workflow/api/UserWorkflowAdapter.java
---
@@ -60,6 +61,10 @@
WorkflowResult<P
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833309
--- Diff:
core/workflow-java/src/main/java/org/apache/syncope/core/workflow/java/DefaultUserWorkflowAdapter.java
---
@@ -207,4 +207,10 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71833317
--- Diff:
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
---
@@ -0,0 +1,100
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71832626
--- Diff:
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/ActivitiUserWorkflowAdapter.java
---
@@ -349,11 +349,33
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71832672
--- Diff:
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
---
@@ -0,0 +1,102 @@
+/*
--- End diff
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71832647
--- Diff:
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/ActivitiUserWorkflowAdapter.java
---
@@ -349,11 +349,33
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71832801
--- Diff: core/persistence-jpa/src/test/resources/domains/MasterContent.xml
---
@@ -461,7 +470,15 @@ under the License
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/26#discussion_r71832883
--- Diff:
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
---
@@ -0,0 +1,102
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/30#discussion_r73184440
--- Diff:
client/enduser/src/main/java/org/apache/syncope/client/enduser/resources/UserSelfCreateResource.java
---
@@ -13,16 +13,26 @@
* software
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/30#discussion_r73184897
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/directives/dynamicPlainAttribute.js
---
@@ -85,10 +83,10 @@ angular.module('self
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/30#discussion_r73184620
--- Diff:
client/enduser/src/main/java/org/apache/syncope/client/enduser/resources/UserSelfUpdateResource.java
---
@@ -57,8 +63,8 @@ protected
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/30#discussion_r73184924
--- Diff:
client/enduser/src/main/resources/META-INF/resources/app/js/directives/dynamicPlainAttribute.js
---
@@ -85,10 +83,10 @@ angular.module('self
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/31
Your latest changes look good, please go ahead and rebase / squash into
single commit, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/31
Merged, thank you @tmess567!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 334 matches
Mail list logo
