[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user mteo closed the pull request at: https://github.com/apache/syncope/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216268832 LGTM @mteo I'll go ahead and merge, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user mteo commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216263417 Hi @ilgrosso, I made the changes. Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736304 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736063 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736276 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61735681 --- Diff: client/enduser/src/main/java/org/apache/syncope/client/enduser/SyncopeEnduserApplication.java --- @@ -154,6 +155,16 @@ public IResource

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61735968 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -1,3 +1,5 @@ +/* global $http, AuthService */ --- End diff --

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736265 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736403 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736292 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736317 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user ilgrosso commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216232120 Hi @mteo thanks for your PR! There are few minor comments of mine: once fixed, I'll be happy to merge it. --- If your project is set up for it, you can reply to

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

Github user mteo commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216227329 Pr is completed, now you can take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] syncope pull request: SYNCOPE-798 now cancel does logout

GitHub user mteo opened a pull request: https://github.com/apache/syncope/pull/13 SYNCOPE-798 now cancel does logout You can merge this pull request into a Git repository by running: $ git pull https://github.com/mteo/syncope SYNCOPE-798 Alternatively you can review and