[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-19 Thread Misagh Moayyed (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933280#comment-16933280
 ] 

Misagh Moayyed commented on SYNCOPE-1332:
-

I think this can now be closed. We are at a good-enough state where all other 
clean-up etc would have to be ad-hoc and sort of ongoing. 

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-11 Thread Jira


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927320#comment-16927320
 ] 

Francesco Chicchiriccò commented on SYNCOPE-1332:
-

{quote}
There is some minor cleanup left and a few more rounds of fixes for stuff 
reported by static analysis tools. I think we should be able to finalize and 
close this out by next Monday. Probably 1-2 more PRs should do it.
{quote}

Sounds good!

{quote}
How about var support? Are we sure tp skip adopting? (Nothing to do with type 
safety per se; just makes it simpler to read and write less code) 
{quote}

As I say above, I don't see much addition to introduce such a massive change 
into an existing, strongly typed, codebase - maybe we can just decide to accept 
{{var}} for new code.

{quote}
Don't plan to do modules; I see no benefit in complicating the codebase with 
the use of modules and we get nothing out of it. Seems way more useful for 
library authors; not folks who work on platforms/products.
{quote}

Well, this makes sense, thanks for sharing your thoughts.

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-11 Thread Misagh Moayyed (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927306#comment-16927306
 ] 

Misagh Moayyed commented on SYNCOPE-1332:
-

There is some minor cleanup left and a few more rounds of fixes for stuff 
reported by static analysis tools. I think we should be able to finalize and 
close this out by next Monday. Probably 1-2 more PRs should do it.

 

How about var support? Are we sure tp skip adopting? (Nothing to do with type 
safety per se; just makes it simpler to read and write less code) 

 

Don't plan to do modules; I see no benefit in complicating the codebase with 
the use of modules and we get nothing out of it. Seems way more useful for 
library authors; not folks who work on platforms/products.

 

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-11 Thread Jira


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927298#comment-16927298
 ] 

Francesco Chicchiriccò commented on SYNCOPE-1332:
-

[~mmoayyed] do you plan do submit more PRs here? Is there any major feature in 
JDK > 9 we are not covering yet? Maybe 
[modules|https://www.journaldev.com/13106/java-9-modules]? 

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925606#comment-16925606
 ] 

ASF subversion and git services commented on SYNCOPE-1332:
--

Commit 6864923b61c395b7be3bcf2e10b5d50aea547515 in syncope's branch 
refs/heads/master from Misagh Moayyed
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=6864923 ]

SYNCOPE-1332: Java 11 language features; use factory calls for immutable 
collections


> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925560#comment-16925560
 ] 

ASF subversion and git services commented on SYNCOPE-1332:
--

Commit 61385632208864e645e7a33d2db962c2fd8c99fd in syncope's branch 
refs/heads/master from Misagh Moayyed
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=6138563 ]

SYNCOPE-1332: use lambda's for anonymous types and/or method args/calls


> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922428#comment-16922428
 ] 

ASF subversion and git services commented on SYNCOPE-1332:
--

Commit 9feb0fa02f9a4190e4eb6d1c2887482204605949 in syncope's branch 
refs/heads/master from Misagh Moayyed
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=9feb0fa ]

SYNCOPE-1332: remove unused imports (#109)



> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922368#comment-16922368
 ] 

ASF subversion and git services commented on SYNCOPE-1332:
--

Commit edfb42c8b04289793ed9529803df8a61c04be6a7 in syncope's branch 
refs/heads/master from Misagh Moayyed
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=edfb42c ]

SYNCOPE-1332: Java 11 language features; use Optional where possible (#108)



> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-03 Thread Jira


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921222#comment-16921222
 ] 

Francesco Chicchiriccò commented on SYNCOPE-1332:
-

Cool, thanks [~mmoayyed]

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-09-02 Thread Misagh Moayyed (Jira)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921015#comment-16921015
 ] 

Misagh Moayyed commented on SYNCOPE-1332:
-

Sounds good, sure. Don't quite see the value in the module system here just 
yet, but the rest should be doable easily. I'll put this on the TODO list for 
the near-midterm future.

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-04-02 Thread JIRA


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807441#comment-16807441
 ] 

Francesco Chicchiriccò commented on SYNCOPE-1332:
-

Maybe not {{var}} (I honestly don't see any addition to introduce that into an 
existing, strongly typed, codebase - but maybe I am wrong...)

I was more thinking to review the whole codebase to profit from the language 
features introduced after Java 8; something like as 
https://codete.com/blog/java-8-java-11-quick-guide/

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SYNCOPE-1332) Java 11 language features

2019-04-01 Thread Misagh Moayyed (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807144#comment-16807144
 ] 

Misagh Moayyed commented on SYNCOPE-1332:
-

I'd like to work on this in general, converting as much as possible and 
contribute back. Are there any particular language features that folks are 
interested to adopt? `var` support perhaps? 

> Java 11 language features
> -
>
> Key: SYNCOPE-1332
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1332
> Project: Syncope
>  Issue Type: Task
>Reporter: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> SYNCOPE-1327 allowed the code to be built with JDK 9/10.
> As agreed in [mailing 
> list|https://lists.apache.org/thread.html/8c5f03cb5f0304c215bc05fa6e61da808433e09359d749cdf2dec9b2@%3Cdev.syncope.apache.org%3E],
>  3.0.0 will require JDK 11, and should also use the new language features as 
> much as possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)