[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672855#comment-16672855
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
ilgrosso commented on issue #86: SYNCOPE-1390: Pull Realms: pull task with
Unmatching Rules: PROVISION…
URL: https://github.com/apache/syncope/pull/86#issuecomment-435330455
Thanks for your contribution @AlexTsvetkov - please do not forget to submit
your ICLA.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.10, 2.1.1
>Reporter: Alexander Tsvetkov
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.11, 2.1.2, 3.0.0
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672852#comment-16672852
]
ASF subversion and git services commented on SYNCOPE-1390:
--
Commit 68b3b89234e5d16a63eba71402320da4dae56902 in syncope's branch
refs/heads/2_0_X from [~AlexanderTs]
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=68b3b89 ]
SYNCOPE-1390: Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't
create propagation task (#86)
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.9, 2.1.1
>Reporter: Alexander Tsvetkov
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.11, 2.1.2, 3.0.0
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672851#comment-16672851
]
ASF subversion and git services commented on SYNCOPE-1390:
--
Commit 2a5ebc988df1d1717835f0195e479736791abf91 in syncope's branch
refs/heads/master from [~AlexanderTs]
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=2a5ebc9 ]
SYNCOPE-1390: Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't
create propagation task (#86)
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.9, 2.1.1
>Reporter: Alexander Tsvetkov
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.11, 2.1.2, 3.0.0
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672840#comment-16672840
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
ilgrosso closed pull request #86: SYNCOPE-1390: Pull Realms: pull task with
Unmatching Rules: PROVISION…
URL: https://github.com/apache/syncope/pull/86
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
index fb29bd4684..2f0fd19f9c 100644
---
a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
+++
b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
@@ -31,7 +31,6 @@
import org.apache.syncope.common.lib.types.AuditElements.Result;
import org.apache.syncope.common.lib.types.ClientExceptionType;
import org.apache.syncope.common.lib.types.MatchingRule;
-import org.apache.syncope.core.provisioning.api.PropagationByResource;
import org.apache.syncope.common.lib.types.PullMode;
import org.apache.syncope.common.lib.types.ResourceOperation;
import org.apache.syncope.common.lib.types.UnmatchingRule;
@@ -42,6 +41,7 @@
import org.apache.syncope.core.persistence.api.entity.Realm;
import org.apache.syncope.core.persistence.api.entity.resource.OrgUnit;
import org.apache.syncope.core.persistence.api.entity.task.PullTask;
+import org.apache.syncope.core.provisioning.api.PropagationByResource;
import
org.apache.syncope.core.provisioning.api.propagation.PropagationException;
import
org.apache.syncope.core.provisioning.api.pushpull.IgnoreProvisionException;
import org.apache.syncope.core.provisioning.api.pushpull.ProvisioningReport;
@@ -160,7 +160,7 @@ public boolean handle(final SyncDelta delta) {
action.beforeAssign(profile, delta, realmTO);
}
-create(realmTO, delta,
UnmatchingRule.toEventName(UnmatchingRule.ASSIGN), result);
+create(realmTO, delta, UnmatchingRule.ASSIGN, result);
}
return Collections.singletonList(result);
@@ -198,7 +198,7 @@ public boolean handle(final SyncDelta delta) {
action.beforeProvision(profile, delta, realmTO);
}
-create(realmTO, delta,
UnmatchingRule.toEventName(UnmatchingRule.PROVISION), result);
+create(realmTO, delta, UnmatchingRule.PROVISION, result);
}
return Collections.singletonList(result);
@@ -225,7 +225,7 @@ private void throwIgnoreProvisionException(final SyncDelta
delta, final Exceptio
private void create(
final RealmTO realmTO,
final SyncDelta delta,
-final String operation,
+final UnmatchingRule unmatchingRule,
final ProvisioningReport result)
throws JobExecutionException {
@@ -239,8 +239,10 @@ private void create(
for (String resource : realm.getResourceKeys()) {
propByRes.add(ResourceOperation.CREATE, resource);
}
-List tasks =
propagationManager.createTasks(realm, propByRes, null);
-taskExecutor.execute(tasks, false);
+if (unmatchingRule == UnmatchingRule.ASSIGN) {
+List tasks =
propagationManager.createTasks(realm, propByRes, null);
+taskExecutor.execute(tasks, false);
+}
RealmTO actual = binder.getRealmTO(realm, true);
@@ -271,7 +273,7 @@ private void create(
resultStatus = Result.FAILURE;
}
-finalize(operation, resultStatus, null, output, delta);
+finalize(UnmatchingRule.toEventName(unmatchingRule), resultStatus,
null, output, delta);
}
private List update(final SyncDelta delta, final
List keys)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
>
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672842#comment-16672842
]
ASF subversion and git services commented on SYNCOPE-1390:
--
Commit 9d6f89dfe67bf528d161ea3f6ac1c130434004a9 in syncope's branch
refs/heads/2_1_X from [~AlexanderTs]
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=9d6f89d ]
SYNCOPE-1390: Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't
create propagation task (#86)
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.9, 2.1.1
>Reporter: Alexander Tsvetkov
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.11, 2.1.2, 3.0.0
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672841#comment-16672841
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
Github user ilgrosso closed the pull request at:
https://github.com/apache/syncope/pull/86
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.0.9, 2.1.1
>Reporter: Alexander Tsvetkov
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.0.11, 2.1.2, 3.0.0
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671608#comment-16671608
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
ilgrosso commented on issue #86: SYNCOPE-1390: Pull Realms: pull task with
Unmatching Rules: PROVISION…
URL: https://github.com/apache/syncope/pull/86#issuecomment-435039516
Please submit your
[ICLA](http://syncope.apache.org/contributing#How_do_I_become_a_contributor_or_a_committer.3F)
before we can accept your contributions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
>Affects Versions: 2.1.0, 2.1.1
>Reporter: Alexander Tsvetkov
>Priority: Major
> Fix For: 2.1.2
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671609#comment-16671609
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/86
Please submit your
[ICLA](http://syncope.apache.org/contributing#How_do_I_become_a_contributor_or_a_committer.3F)
before we can accept your contributions.
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
>Affects Versions: 2.1.0, 2.1.1
>Reporter: Alexander Tsvetkov
>Priority: Major
> Fix For: 2.1.2
>
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> ([https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):]
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
> BUT propagation tasks are created for this pull task.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671346#comment-16671346
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
GitHub user AlexTsvetkov opened a pull request:
https://github.com/apache/syncope/pull/86
SYNCOPE-1390: Pull Realms: pull task with Unmatching Rules: PROVISION…
… shouldn't create propagation task
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexTsvetkov/syncope 2_1_X
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
commit ced3d6045c3fb584e8805af93d5fb409e66806d3
Author: Alexander Tsvetkov
Date: 2018-11-01T09:30:31Z
SYNCOPE-1390: Pull Realms: pull task with Unmatching Rules: PROVISION
shouldn't create propagation task
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
>Reporter: Alexander Tsvetkov
>Priority: Major
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> (https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYNCOPE-1390) Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create propagation task
[
https://issues.apache.org/jira/browse/SYNCOPE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671345#comment-16671345
]
ASF GitHub Bot commented on SYNCOPE-1390:
-
AlexTsvetkov opened a new pull request #86: SYNCOPE-1390: Pull Realms: pull
task with Unmatching Rules: PROVISION…
URL: https://github.com/apache/syncope/pull/86
… shouldn't create propagation task
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pull Realms: pull task with Unmatching Rules: PROVISION shouldn't create
> propagation task
> -
>
> Key: SYNCOPE-1390
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1390
> Project: Syncope
> Issue Type: Bug
>Reporter: Alexander Tsvetkov
>Priority: Major
>
> I need to pull Realms from Active Directotory.
> I have created Pull task with Unmatching Rules: PROVISION.
> According to the documentation
> (https://syncope.apache.org/docs/reference-guide.html#provisioning-pull):
> Unmatching Rules
> * {{IGNORE}}: do not perform any action;
> * {{UNLINK}}: do not perform any action;
> * {{ASSIGN}}: create internally, assign the external resource;
> * {{PROVISION}}: create internally, do not assign the external resource.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
