[GitHub] incubator-tephra pull request #38: TEPHRA-224 Handle delay between transacti...

2017-02-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/38#discussion_r102371884 --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java --- @@ -376,6 +376,11 @@ public static final String

[GitHub] incubator-tephra pull request #38: TEPHRA-224 Handle delay between transacti...

2017-02-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/38#discussion_r102371828 --- Diff: tephra-core/src/main/java/org/apache/tephra/txprune/TransactionPruningRunnable.java --- @@ -57,8 +60,13 @@ public void run

[GitHub] incubator-tephra pull request #38: TEPHRA-224 Handle delay between transacti...

2017-02-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/38#discussion_r102365159 --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java --- @@ -376,6 +376,11 @@ public static final String

[GitHub] incubator-tephra pull request #37: TEPHRA-223 Encapsulate the two data struc...

2017-02-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/37#discussion_r102124543 --- Diff: tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-tephra pull request #37: TEPHRA-223 Encapsulate the two data struc...

2017-02-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/37#discussion_r102124522 --- Diff: tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-tephra pull request #37: TEPHRA-223 Encapsulate the two data struc...

2017-02-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/37#discussion_r102124470 --- Diff: tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-tephra pull request #37: TEPHRA-223 Encapsulate the two data struc...

2017-02-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/37#discussion_r102124449 --- Diff: tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-tephra pull request #37: TEPHRA-223 Encapsulate the two data struc...

2017-02-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/37#discussion_r102124958 --- Diff: tephra-core/src/main/java/org/apache/tephra/manager/InvalidTxList.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-tephra issue #38: TEPHRA-224 Handle delay between transaction max ...

2017-02-22 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/38 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-tephra pull request #34: TEPHRA-216 Handle empty transactional reg...

2017-02-10 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/34#discussion_r100608042 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java --- @@ -366,6 +371,56 @@ public void

[GitHub] incubator-tephra pull request #34: TEPHRA-216 Handle empty transactional reg...

2017-02-10 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/34#discussion_r100603640 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java --- @@ -288,23 +288,27

[GitHub] incubator-tephra issue #34: TEPHRA-216 Handle empty transactional regions du...

2017-02-11 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/34 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-tephra issue #33: Use getRegion instead of getRegionInfo for hbase...

2017-02-09 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/33 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...

2016-10-06 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/17 (TEPHRA-188) Allow to configure a limit for the transaction timeout the title says it all. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-tephra pull request #17: (TEPHRA-188) Allow to configure a limit f...

2016-10-06 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/17#discussion_r82313446 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -722,7 +725,10 @@ public Transaction startShort

[GitHub] incubator-tephra issue #17: (TEPHRA-188) Allow to configure a limit for the ...

2016-10-06 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/17 @poornachandra I made the change. Please take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-tephra issue #14: (TEPHRA-185) Add a way to pass a custom timeout ...

2016-09-21 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/14 @poornachandra please take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-tephra pull request #14: (TEPHRA-185) Add a way to pass a custom t...

2016-09-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/14#discussion_r79965244 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java --- @@ -88,7 +88,27 @@ public boolean removeTransactionAware

[GitHub] incubator-tephra pull request #14: (TEPHRA-185) Add a way to pass a custom t...

2016-09-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/14#discussion_r79965250 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java --- @@ -88,7 +88,27 @@ public boolean removeTransactionAware

[GitHub] incubator-tephra issue #19: TEPHRA-35 Save compaction state for pruning inva...

2016-11-05 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/19 Question: Suppose I start a transaction, which times out, and therefore goes into the invalid list. A little later HBase performs a major compaction. This transaction and all its writes

[GitHub] incubator-tephra pull request #19: TEPHRA-35 Save compaction state for pruni...

2016-11-04 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/19#discussion_r86656565 --- Diff: tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/InvalidListPruneTest.java --- @@ -0,0 +1,203 @@ +/* + * Licensed

[GitHub] incubator-tephra pull request #19: TEPHRA-35 Save compaction state for pruni...

2016-11-04 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/19#discussion_r86656252 --- Diff: tephra-core/src/main/java/org/apache/tephra/util/TxUtils.java --- @@ -149,4 +149,15 @@ private static long getMaxTTL(Map<byte[], L

[GitHub] incubator-tephra pull request #19: TEPHRA-35 Save compaction state for pruni...

2016-11-04 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/19#discussion_r86656117 --- Diff: tephra-core/src/main/java/org/apache/tephra/TxConstants.java --- @@ -345,4 +345,14 @@ public static final byte CURRENT_VERSION = 3

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-19 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/18 [TEPHRA-194] Make startShort() throw IllegalArgumentException … … consistently for invalid timeout values. Previously, it was throwing IllegalArgumentException in-memory

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-19 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84193226 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TBoolean.java --- @@ -24,19 +24,29 @@ */ package

[GitHub] incubator-tephra issue #18: [TEPHRA-194] Make startShort() throw IllegalArgu...

2016-10-19 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/18 Please do not review Thrift classes :) tephra-core/src/main/java/org/apache/tephra/distributed/thrift/T*.java --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84390730 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84391234 --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java --- @@ -124,4 +127,39 @@ protected TransactionSystemClient

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84392263 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceThriftClient.java --- @@ -112,7 +113,20 @@ public Transaction

[GitHub] incubator-tephra issue #18: [TEPHRA-194] Make startShort() throw IllegalArgu...

2016-10-20 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/18 @poornachandra I have addressed your comments, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84399721 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89938828 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89207961 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89377823 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89391984 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89391878 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89939212 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DefaultDataJanitorPlugin.java --- @@ -0,0 +1,189

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89391681 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89207839 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +105,237

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89938230 --- Diff: tephra-core/src/main/java/org/apache/tephra/janitor/DataJanitorPlugin.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89938297 --- Diff: tephra-core/src/main/java/org/apache/tephra/janitor/DataJanitorPlugin.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89938407 --- Diff: tephra-core/src/main/java/org/apache/tephra/janitor/DataJanitorPlugin.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-11-28 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r89938969 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DefaultDataJanitorPlugin.java --- @@ -0,0 +1,189

[GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog...

2016-12-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91468098 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -348,27 +348,30 @@ private void cleanupTimedOutTransactions

[GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog...

2016-12-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91471138 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -340,48 +340,51 @@ public long getSleepMillis

[GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog...

2016-12-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91467537 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -958,25 +983,31 @@ private void doAbort(long writePointer, long

[GitHub] incubator-tephra pull request #23: [Tephra-201] Store checkpoints in in-prog...

2016-12-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/23#discussion_r91467770 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -1319,20 +1344,60 @@ public void shutdown

[GitHub] incubator-tephra pull request #22: Transaction pruning service

2016-12-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/22#discussion_r91990644 --- Diff: tephra-core/src/main/java/org/apache/tephra/util/TxUtils.java --- @@ -163,8 +167,22 @@ public static long getPruneUpperBound(Transaction tx

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-12-03 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r90760015 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/HBaseTransactionPruningPlugin.java --- @@ -0,0 +1,289

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-12-03 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r90759375 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/DataJanitorState.java --- @@ -58,10 +110,248

[GitHub] incubator-tephra issue #20: Compute global prune upper bound using compactio...

2016-12-03 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/20 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-tephra issue #20: Compute global prune upper bound using compactio...

2016-12-03 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/20 I did another pass. Only a few more comments... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-tephra pull request #20: Compute global prune upper bound using co...

2016-12-03 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/20#discussion_r90766319 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/janitor/HBaseTransactionPruningPlugin.java --- @@ -179,15

[GitHub] incubator-tephra issue #22: Transaction pruning service

2016-12-27 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/22 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-08-17 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/47 [TEPHRA-240] Include conflicting key and client id in TransactionConflictException - Enhances TransactionConflictException to have fields for the transaction id, the conflicting change

[GitHub] incubator-tephra pull request #56: (TEPHRA-258) Improve logging in thrift cl...

2017-09-11 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/56 (TEPHRA-258) Improve logging in thrift client providers title says it all. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anew/incubator

[GitHub] incubator-tephra issue #53: (TEPHRA-243) Improve logging for slow log append

2017-09-13 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/53 Thanks for t he review, I agree with everything but your last comment. I have pushed another commit to address these comments. ---

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138684944 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -165,26 +203,36 @@ private void sync() throws

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138686433 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -48,21 +52,30 @@ protected long timestamp

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138692966 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -48,21 +51,30 @@ protected long timestamp

[GitHub] incubator-tephra pull request #61: TEPHRA-263 Enforce TTL, regardless of any...

2017-09-16 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/61#discussion_r139287927 --- Diff: tephra-hbase-compat-1.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionVisibilityFilterTest.java --- @@ -290,44 +290,52

[GitHub] incubator-tephra pull request #61: TEPHRA-263 Enforce TTL, regardless of any...

2017-09-16 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/61#discussion_r139287786 --- Diff: tephra-core/src/main/java/org/apache/tephra/util/TxUtils.java --- @@ -75,12 +75,9 @@ public static long getOldestVisibleTimestamp(Map<b

[GitHub] incubator-tephra pull request #61: TEPHRA-263 Enforce TTL, regardless of any...

2017-09-16 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/61#discussion_r139287848 --- Diff: tephra-hbase-compat-1.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionVisibilityFilterTest.java --- @@ -290,44 +290,52

[GitHub] incubator-tephra pull request #62: TEPHRA-245 Improve prune debug tool

2017-09-19 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/62#discussion_r139811987 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java --- @@ -56,15 +59,18 @@ public

[GitHub] incubator-tephra issue #62: TEPHRA-245 Improve prune debug tool

2017-09-19 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/62 I trust you that you made the same changes in the other modules. LGTM ---

[GitHub] incubator-tephra issue #62: TEPHRA-245 Improve prune debug tool

2017-09-19 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/62 looks good. please apply this to the other compat modules. ---

[GitHub] incubator-tephra issue #62: TEPHRA-245 Improve prune debug tool

2017-09-20 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/62 these commits look good. Please apply to all compat modules. ---

[GitHub] incubator-tephra issue #62: TEPHRA-245 Improve prune debug tool

2017-09-21 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/62 LGTM ---

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138732890 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -134,57 +124,112 @@ private void ensureAvailable

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138731295 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -85,44 +99,20 @@ public long getTimestamp

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-13 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138759678 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -85,105 +100,145 @@ public long getTimestamp

[GitHub] incubator-tephra pull request #62: TEPHRA-245 Improve prune debug tool

2017-09-19 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/62#discussion_r139744215 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebug.java --- @@ -56,15 +59,18 @@ public

[GitHub] incubator-tephra pull request #62: TEPHRA-245 Improve prune debug tool

2017-09-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/62#discussion_r140172872 --- Diff: tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTest.java --- @@ -280,29 +282,36

[GitHub] incubator-tephra pull request #62: TEPHRA-245 Improve prune debug tool

2017-09-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/62#discussion_r140172193 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTool.java --- @@ -165,10 +165,10

[GitHub] incubator-tephra pull request #62: TEPHRA-245 Improve prune debug tool

2017-09-21 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/62#discussion_r140172443 --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTool.java --- @@ -204,16 +204,19

[GitHub] incubator-tephra issue #61: TEPHRA-263 Enforce TTL, regardless of any in-pro...

2017-09-21 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/61 Changes look the same to me in all modules. LGTM ---

[GitHub] incubator-tephra issue #50: [TEPHRA-238] Support for HBase 1.3.x

2017-09-06 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/50 Rebased on top of Tephra-252. Travis build should now pass. ---

[GitHub] incubator-tephra issue #50: [TEPHRA-238] Support for HBase 1.3.x

2017-09-06 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/50 Thanks, @JamesRTaylor, for the verification. I am waiting for the Travis build to succeed. What is your anticipated date for Phoenix 4.12? We have a few critical fixes that we would like

[GitHub] incubator-tephra pull request #51: [TEPHRA-252] Fix Travis build for Oracle ...

2017-09-06 Thread anew
Github user anew closed the pull request at: https://github.com/apache/incubator-tephra/pull/51 ---

[GitHub] incubator-tephra issue #51: [TEPHRA-252] Fix Travis build for Oracle JDK 7

2017-09-06 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/51 Travis build passed now. Will commit this. ---

[GitHub] incubator-tephra pull request #49: [TEPHRA-242] Ensure Pruning Service shuts...

2017-09-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/49#discussion_r137879378 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionService.java --- @@ -121,15 +121,15 @@ public void failed(State from

[GitHub] incubator-tephra pull request #52: (TEPHRA-250) Allow to trigger transaction...

2017-09-08 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/52 (TEPHRA-250) Allow to trigger transaction pruning - adds a method to TransactionPruningService to trigger pruning now - exposes this method through Thrift and the Tx system client

[GitHub] incubator-tephra pull request #52: (TEPHRA-250) Allow to trigger transaction...

2017-09-08 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/52#discussion_r137911192 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TTransactionServer.java --- @@ -88,6 +88,8 @@ public

[GitHub] incubator-tephra pull request #55: TEPHRA-244 Remove regions of deleted tabl...

2017-09-10 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/55#discussion_r137981077 --- Diff: tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java --- @@ -384,7 +384,67 @@ public void

[GitHub] incubator-tephra pull request #50: [TEPHRA-238] Support for HBase 1.3.x

2017-09-05 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/50 [TEPHRA-238] Support for HBase 1.3.x - Adds a new compat module using 1.3.1 as the HBase version. I could not reuse the compat-1.1-base because HTable added four new methods in 1.3 (get

[GitHub] incubator-tephra issue #50: [TEPHRA-238] Support for HBase 1.3.x

2017-09-05 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/50 Thanks for the quick review, @JamesRTaylor. As an additional validation, could you run the Phoenix tests with this branch of Tephra? Thanks a lot! ---

[GitHub] incubator-tephra issue #50: [TEPHRA-238] Support for HBase 1.3.x

2017-09-06 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/50 The travis test run for Java 8 failed while it passed for Java 7. It fails in a test for HBase 1.2, which is not affected at all by this change. That indicates that the failing test case

[GitHub] incubator-tephra issue #47: [TEPHRA-240] Include conflicting key and client ...

2017-09-12 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/47 squashed and rebased on latest master. ---

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138490048 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -206,12 +210,19 @@ public TransactionManager(Configuration conf

[GitHub] incubator-tephra pull request #54: wip

2017-09-09 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/54 wip on hold You can merge this pull request into a Git repository by running: $ git pull https://github.com/anew/incubator-tephra tephra-253 Alternatively you can review and apply

[GitHub] incubator-tephra issue #48: [TEPHRA-241] Introduce a way to limit the size o...

2017-09-09 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/48 Same travis failure. This appears to happen a lot more frequently with Java 8. I will commit this now and try to fix the flaky test before 0.13 release. ---

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-08 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/53 (TEPHRA-243) Improve logging for slow log append - adds more detail to the log message (number of entries, bytes written) - ensures only one thread logs the message concurrently, by moving

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138435657 --- Diff: tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java --- @@ -22,11 +22,50 @@ * Thrown to indicate transaction

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138437669 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java --- @@ -89,21 +89,38 @@ * * @param tx transaction

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138436222 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java --- @@ -311,25 +304,16 @@ private void persist() throws

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138437903 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -853,46 +867,45 @@ private void advanceWritePointer(long

[GitHub] incubator-tephra pull request #48: [TEPHRA-241] Introduce a way to limit the...

2017-08-31 Thread anew
GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/48 [TEPHRA-241] Introduce a way to limit the size of a transaction - first commit introduces four new configurations for change set size limits, enforces these limits in a new method

[GitHub] incubator-tephra pull request #48: [TEPHRA-241] Introduce a way to limit the...

2017-08-31 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/48#discussion_r136457929 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionManagerTest.java --- @@ -54,115 +54,35 @@ protected TransactionStateStorage

[GitHub] incubator-tephra pull request #48: [TEPHRA-241] Introduce a way to limit the...

2017-08-31 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/48#discussion_r136458250 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TTransactionServer.java --- @@ -68,6 +68,8 @@ public TBoolean

[GitHub] incubator-tephra pull request #74: TEPHRA-266 Identify log messages when mul...

2018-05-01 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/74#discussion_r185305932 --- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java --- @@ -184,4 +185,14 @@ private void refreshState

  1   2   >