[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Feel free to take it. I won't support it anymore though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509129#comment-15509129 ] ASF GitHub Bot commented on THRIFT-3867: Github user erikvanoosten commented on t

[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509144#comment-15509144 ] ASF GitHub Bot commented on THRIFT-3867: Github user erikvanoosten commented on t

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 The feedback cycle took more then a month. This is too long for me. I do not have the mental capacity to keep work in my head for that long. Kind regards, Erik.

[jira] [Commented] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Fan Yang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509306#comment-15509306 ] Fan Yang commented on THRIFT-1667: -- [~jensg][~roger.meier] Hi, I think I'm able to tak

[jira] [Comment Edited] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Fan Yang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509306#comment-15509306 ] Fan Yang edited comment on THRIFT-1667 at 9/21/16 9:13 AM: --- Hi

[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509335#comment-15509335 ] ASF GitHub Bot commented on THRIFT-3929: Github user RobberPhex commented on the

[GitHub] thrift issue #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-21 Thread RobberPhex
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1089 @jfarrell Can you review this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-21 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Buğra Gedik updated THRIFT-3932: Description: {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls {{removeWorker(w

[GitHub] thrift issue #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-21 Thread bmeynell
Github user bmeynell commented on the issue: https://github.com/apache/thrift/pull/1089 FWIW I tested to use case described in `THRIFT-3929` locally and it worked as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510218#comment-15510218 ] ASF GitHub Bot commented on THRIFT-3929: Github user bmeynell commented on the is

[jira] [Commented] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510428#comment-15510428 ] Jens Geyer commented on THRIFT-1667: Yes, sending a PR via Github is perfectly fine.

[jira] [Resolved] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3867. Resolution: Fixed Assignee: Erik van Oosten Fix Version/s: 0.10.0 {quote} Github us

[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

2016-09-21 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1088 Could you please file a JIRA ticket according to our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute)? --- If your project is set up for it, you can reply to this email and have y

[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

2016-09-21 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511222#comment-15511222 ] James E. King, III commented on THRIFT-3775: How are we looking on putting ou

[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

2016-09-21 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1088 ### General All code files etc. need an ASF header on top. Please have a look at the existing code if you are unsure, what, where and how to apply. ### using Serilog; We d

[jira] [Resolved] (THRIFT-3923) Maybe remove Aereo from the "Powered by" list

2016-09-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3923. Resolution: Fixed Assignee: Jens Geyer Fix Version/s: 0.10.0 Committed. > Maybe re

[jira] [Updated] (THRIFT-3923) Maybe remove Aereo from the "Powered by" list

2016-09-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3923: --- Attachment: THRIFT-3923.patch > Maybe remove Aereo from the "Powered by" list > -