[GitHub] thrift pull request #1331: THRIFT-3974: fix ThreadSanitizer identified issue...

2017-08-12 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1331 THRIFT-3974: fix ThreadSanitizer identified issues Tested with pthread, boost and std threads and -fsanitizer=thread with clang-4.0. You can merge this pull request into a Git repository by runnin

[jira] [Commented] (THRIFT-3974) Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124700#comment-16124700 ] ASF GitHub Bot commented on THRIFT-3974: GitHub user jeking3 opened a pull reques

[GitHub] thrift pull request #1331: THRIFT-3974: fix ThreadSanitizer identified issue...

2017-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-3974) Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124741#comment-16124741 ] ASF GitHub Bot commented on THRIFT-3974: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3974) Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3974. Resolution: Fixed Fix Version/s: 0.11.0 > Using clang-3.8 and ThreadSanitize

[jira] [Commented] (THRIFT-3974) Using clang-3.8 and ThreadSanitizer on the concurrency_test claims bad PThread behavior

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124742#comment-16124742 ] James E. King, III commented on THRIFT-3974: Thread Sanitizer runs clean on t

[GitHub] thrift pull request #1330: THRIFT-4284: remove extraneous character

2017-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Resolved] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4284. Resolution: Fixed Fix Version/s: 0.11.0 > File contains a NBSP: lib/nodejs/l

[jira] [Commented] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124745#comment-16124745 ] ASF GitHub Bot commented on THRIFT-4284: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3857. Resolution: Fixed Fix Version/s: 0.11.0 > thrift js:node complier support an

[GitHub] thrift pull request #1034: THRIFT-3857

2017-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124747#comment-16124747 ] ASF GitHub Bot commented on THRIFT-3857: Github user asfgit closed the pull reque

[jira] [Updated] (THRIFT-4106) concurrency_test fails randomly on MinGW

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4106: --- Affects Version/s: (was: 0.11.0) 0.10.0 > concurrency_test

[jira] [Commented] (THRIFT-4106) concurrency_test fails randomly on MinGW

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124748#comment-16124748 ] James E. King, III commented on THRIFT-4106: It also seems to fail on WIN32 x

[GitHub] thrift issue #1326: THRIFT-3821

2017-08-12 Thread asuhan
Github user asuhan commented on the issue: https://github.com/apache/thrift/pull/1326 Are there any additional changes I should make to this pull request? As I've said in the inline comment, I believe comparing to `std::numeric_limits::max()` is actually consistent with what the erro

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124775#comment-16124775 ] ASF GitHub Bot commented on THRIFT-3821: Github user asuhan commented on the issu

[GitHub] thrift issue #1326: THRIFT-3821

2017-08-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1326 I'd prefer if we refactored it to make the limit configurable with a default matching what it is now; that way tests won't need multiple gigabytes of memory to function properly. I'll approve and m

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124779#comment-16124779 ] ASF GitHub Bot commented on THRIFT-3821: Github user jeking3 commented on the iss

[GitHub] thrift pull request #1326: THRIFT-3821

2017-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1326 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124780#comment-16124780 ] ASF GitHub Bot commented on THRIFT-3821: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3821. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0

[jira] [Resolved] (THRIFT-4263) Fix use after free bug for thrown exceptions

2017-08-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4263. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0

[GitHub] thrift pull request #1314: THRIFT-4263: Fix use after free bug for thrown ex...

2017-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4263) Fix use after free bug for thrown exceptions

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124781#comment-16124781 ] ASF GitHub Bot commented on THRIFT-4263: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-4251) Epoll Selector Bug

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124783#comment-16124783 ] ASF GitHub Bot commented on THRIFT-4251: Github user jeking3 commented on the iss

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

2017-08-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1313 According to the documentation of the defect that triggered this (http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6670302), it indicates this only occurs in kernel 2.4 series, and if you move to

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

2017-08-12 Thread Johnny-Liao
Github user Johnny-Liao commented on the issue: https://github.com/apache/thrift/pull/1313 My linux kernel is 3.10.0 when this bug occured. And I'm pretty sure that still trouble many people who dependence Thrift to implements theirs server program. Netty uses this approach to mask th

[jira] [Commented] (THRIFT-4251) Epoll Selector Bug

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124801#comment-16124801 ] ASF GitHub Bot commented on THRIFT-4251: Github user Johnny-Liao commented on the