[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198288#comment-16198288 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-10 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1382 ping @jeking3 ---

TException and cross-tests

2017-10-10 Thread Tom
Hi, We're working on Common Lisp support for Thrift. I've run into a little issue while implementing cross-tests - namely this bit: /** * Print 'testException(%s)' with arg as '%s' * @param string arg - a string indication what type of exception to throw * if arg == "Xception" throw

[jira] [Commented] (THRIFT-4119) bootstrap.sh is missing from the source tarball

2017-10-10 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198462#comment-16198462 ] Robert Lu commented on THRIFT-4119: --- [~ctubbsii] Well, I agree with you. [~jfarrell] Talk about the

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198624#comment-16198624 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-10 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1382 > Is there a way you can provide a generated NewFooClientFactory as an adapter to run the new code? It would require putting back some of the generated code, but I'll try to find a way. I

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198648#comment-16198648 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

2017-10-10 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1382 Given the backlog on the project, I don't blame you! :) ---

[jira] [Created] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-10 Thread Christian Ciach (JIRA)
Christian Ciach created THRIFT-4362: --- Summary: Missing size-check can lead to huge memory allocation Key: THRIFT-4362 URL: https://issues.apache.org/jira/browse/THRIFT-4362 Project: Thrift

[jira] [Updated] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-10 Thread Christian Ciach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ciach updated THRIFT-4362: Description: In some cases the method

[jira] [Commented] (THRIFT-889) Add SPNEGO support to Thrift HTTP transport

2017-10-10 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199127#comment-16199127 ] Jens Geyer commented on THRIFT-889: --- > My understanding is that Facebook's Thrift library is a fork of

[jira] [Updated] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-10 Thread Christian Ciach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ciach updated THRIFT-4362: Description: In some cases the method

[jira] [Updated] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-10 Thread Christian Ciach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ciach updated THRIFT-4362: Attachment: check-size.patch > Missing size-check can lead to huge memory allocation >

[jira] [Updated] (THRIFT-4362) Missing size-check can lead to huge memory allocation

2017-10-10 Thread Christian Ciach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ciach updated THRIFT-4362: Description: In some cases the method

Re: TException and cross-tests

2017-10-10 Thread Randy Abernethy
Hi Tom, All Apache Thrift generated exceptions are derived from TException, not just user defined exceptions. There are transport exceptions like TTransportException which raise connectivity problems, TProtocolExceptions for serialization errors, TApplicationExceptions for Server errors (e.g.

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198867#comment-16198867 ] ASF GitHub Bot commented on THRIFT-4329: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-10-10 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1361 Seems like it still has some issues in the cross test with c_glib. ---

[jira] [Resolved] (THRIFT-4355) Javascript indentation incorrect when defaulting field attribute to a struct

2017-10-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4355. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks. > Javascript

[jira] [Commented] (THRIFT-4355) Javascript indentation incorrect when defaulting field attribute to a struct

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198863#comment-16198863 ] ASF GitHub Bot commented on THRIFT-4355: Github user asfgit closed the pull request at:

[jira] [Assigned] (THRIFT-4355) Javascript indentation incorrect when defaulting field attribute to a struct

2017-10-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4355: -- Assignee: James E. King, III > Javascript indentation incorrect when

[GitHub] thrift pull request #1388: THRIFT-4355 Fix javascript indentation of default...

2017-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1388 ---

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

2017-10-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198843#comment-16198843 ] ASF GitHub Bot commented on THRIFT-4350: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1379: THRIFT-4350: enable dotnet-2.0.0-sdk in ubuntu xe...

2017-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1379 ---

[jira] [Resolved] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

2017-10-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4350. Resolution: Fixed Fix Version/s: 0.11.0 > Update netcore build for dotnet

Re: TException and cross-tests

2017-10-10 Thread Tom
Thank you for the thorough explanation. It clarified some bits of the exception system for me. I'm still not sure about that test I quoted, though - the testException one. My best guess is that when the client calls testException("TException"), the server should pass back an instance of Xception