[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350515#comment-16350515 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue:

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread johnboiles
Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 Hmm yeah must be a race condition with the test server starting in the go routine. Any thoughts on how to wait for it to start up? I guess I could use a wait group to wait at least until

[jira] [Commented] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350306#comment-16350306 ] ASF GitHub Bot commented on THRIFT-4454: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1490: THRIFT-4454 Large writes/reads may cause range ch...

2018-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1490 ---

[GitHub] thrift pull request #1489: THRIFT-4485 Possible invalid ptr AV with overlapp...

2018-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1489 ---

[jira] [Commented] (THRIFT-4485) Possible invalid ptr AV with overlapped read/write on pipes

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350307#comment-16350307 ] ASF GitHub Bot commented on THRIFT-4485: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-760) Generated client code does not set or check the sequence ID in messages

2018-02-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350779#comment-16350779 ] Jens Geyer commented on THRIFT-760: --- http://thrift.apache.org/docs/HowToContribute > Generated client

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1459 I think the only one-liner fix is a 500ms sleep before `client.TestVoid()`. Retry logic would work as well. ---

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350542#comment-16350542 ] ASF GitHub Bot commented on THRIFT-4448: Github user dcelasun commented on the issue:

[jira] [Resolved] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode

2018-02-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4454. Resolution: Fixed Committed. > Large writes/reads may cause range check errors in debug mode >

[jira] [Resolved] (THRIFT-4485) Possible invalid ptr AV with overlapped read/write on pipes

2018-02-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4485. Resolution: Fixed Fix Version/s: 0.12.0 Committed. > Possible invalid ptr AV with

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1459 The only other way is for someone with Travis crendentials to manually trigger it. I think it's faster if you push something trivial (whitespace etc.) Thrift's CI builds are unfortunately

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350815#comment-16350815 ] ASF GitHub Bot commented on THRIFT-4448: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350897#comment-16350897 ] ASF GitHub Bot commented on THRIFT-4448: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350881#comment-16350881 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue:

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread johnboiles
Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 It's not clear to me what went wrong in the Travis build. Trusty, for example, seems to have stack overflow'd while installing ocaml. Is there a way to retrigger a build without pushing another

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350795#comment-16350795 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue:

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread johnboiles
Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 It bugged me to have a time.Sleep in the test so I wrote the retry logic :) ---

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1459 Looks *much* cleaner! ---

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1459 A different failure this time: ``` --- FAIL: TestHttpContextTimeout (0.00s) context_test.go:74: Unexpected error: dial tcp 127.0.0.1:9096: getsockopt: connection refused

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350182#comment-16350182 ] ASF GitHub Bot commented on THRIFT-4448: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-760) Generated client code does not set or check the sequence ID in messages

2018-02-02 Thread Jacquet Fabian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350173#comment-16350173 ] Jacquet Fabian commented on THRIFT-760: --- hello all, I know this defect is closed but it has not been