[GitHub] thrift issue #1505: Fixing java thrift compiler to generate constants in sta...

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1505 Please add the issue number to your commit message and PR title. See [here](https://thrift.apache.org/docs/HowToContribute) (point 7 under Github). ---

[GitHub] thrift pull request #1505: Fixing java thrift compiler to generate constants...

GitHub user romanoid opened a pull request: https://github.com/apache/thrift/pull/1505 Fixing java thrift compiler to generate constants in stable order. For description of the issue fixed, see: https://issues.apache.org/jira/browse/THRIFT-4513 You can merge this pull request into

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393330#comment-16393330 ] ASF GitHub Bot commented on THRIFT-4513: GitHub user romanoid opened a pull request:

[jira] [Commented] (THRIFT-4024) Skip() should throw on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393726#comment-16393726 ] ASF GitHub Bot commented on THRIFT-4024: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393733#comment-16393733 ] ASF GitHub Bot commented on THRIFT-4495: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1494: THRIFT-4495: Allow `undefined` for non-required Erlang r...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1494 I'm running this and 4497 through local tests since it wasn't based on good CI builds. ---

[GitHub] thrift issue #1494: THRIFT-4495: Allow `undefined` for non-required Erlang r...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1494 Ugh, build failure is dlang related, not to this. ---

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393734#comment-16393734 ] ASF GitHub Bot commented on THRIFT-4495: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1495: THRIFT-4497: Use map() field type for Erlang type...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1495 ---

[jira] [Commented] (THRIFT-4497) Erlang records should use map() for map type

[ https://issues.apache.org/jira/browse/THRIFT-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393798#comment-16393798 ] ASF GitHub Bot commented on THRIFT-4497: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393799#comment-16393799 ] ASF GitHub Bot commented on THRIFT-4495: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1494: THRIFT-4495: Allow `undefined` for non-required E...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1494 ---

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1480 This needs to be retargeted at the master branch and it needs an Apache Jira thrift ticket. See https://thrift.apache.org/docs/HowToContribute ---

[GitHub] thrift pull request #1503: THRIFT-4024: Skip() throws TProtocolException.INV...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1503 ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393803#comment-16393803 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393801#comment-16393801 ] ASF GitHub Bot commented on THRIFT-4474: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 The current master is fairly clean except for a recurring dlang issue. Squash and rebase on master. Squash to one commit please. ---

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Document all breaking changes in the language README. ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Rebase on master and let's see what happens, thanks. ---

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393828#comment-16393828 ] ASF GitHub Bot commented on THRIFT-4513: Github user romanoid commented on the issue:

[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...

Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 @jeking3 Yes, thanks, PR had some assumption on Map keys being only primitive for constant maps, which is not true in general. Latest revision should no longer rely on it. ---

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1474 @jfarrell can you please give a final say on this? ---