[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398149#comment-16398149 ] ASF GitHub Bot commented on THRIFT-4474: Github user RobberPhex commented on the issue:

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

2018-03-14 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1479 @RobberPhex can you squash your commits? ---

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398145#comment-16398145 ] ASF GitHub Bot commented on THRIFT-4474: Github user dcelasun commented on the issue:

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

2018-03-14 Thread RobberPhex
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1479 @dcelasun squashed ---

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-14 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 The build on the `CYGWIN x86` (see https://ci.appveyor.com/project/ozymaxx/thrift/build/job/09xqx9b54efog55o for more details) machine has broken. Here is the error that I got: ```

[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...

2018-03-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1505 Looks like a dlang issue that pops up from time to time. Just to satisfy myself this change is okay I need to look at generated thrift file comparisons from before and after this change. I'll do

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398441#comment-16398441 ] ASF GitHub Bot commented on THRIFT-4513: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398463#comment-16398463 ] ASF GitHub Bot commented on THRIFT-4476: GitHub user ozymaxx reopened a pull request:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-14 Thread ozymaxx
GitHub user ozymaxx reopened a pull request: https://github.com/apache/thrift/pull/1496 THRIFT-4476: Typecasting problem on list items (+ low precision double rendering, + mis-rendering non-fractional double literals in Python) - high precision double rendering in JS, Java, Python

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398462#comment-16398462 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[jira] [Commented] (THRIFT-4513) thrift generated java code is not stable for constants

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398905#comment-16398905 ] ASF GitHub Bot commented on THRIFT-4513: Github user asfgit closed the pull request at:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-14 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 @jeking3 Forget about what I said on Travis. There is only 1 failure in Apache arsenal of Travis (at `cross-test`) as follows: ```

[GitHub] thrift pull request #1505: THRIFT-4513: Fixing java thrift compiler to gener...

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1505 ---

[jira] [Commented] (THRIFT-4513) thrift generated code is not stable for constants

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398912#comment-16398912 ] James E. King, III commented on THRIFT-4513: Root cause of this defect was that the compiler

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-14 Thread Allen George
I'll try track it down. It may be a "make -j2" issue aka. operator error): I notice that c_glib is unable to compile properly if I run more than a single job. Allen From: James E. King, III Sent: Wednesday, March 14, 2018 12:43:34 PM To:

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-14 Thread James E. King, III
The xenial autotools.sh script (which runs "make check", not sure about tutorials) is passing on CI. I assume tutorials are built with one of our CI jobs! - Jim On Wed, Mar 14, 2018 at 12:23 PM, Allen George wrote: > Is anyone having problems compiling master dotnet and

[jira] [Resolved] (THRIFT-4513) thrift generated java code is not stable for constants

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4513. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > thrift

[jira] [Updated] (THRIFT-4513) thrift generated java code is not stable for constants

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4513: --- Component/s: (was: Java - Compiler) Compiler (General) > thrift

[jira] [Assigned] (THRIFT-4513) thrift generated java code is not stable for constants

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4513: -- Assignee: James E. King, III > thrift generated java code is not stable for

[jira] [Updated] (THRIFT-4513) thrift generated code is not stable for constants

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4513: --- Summary: thrift generated code is not stable for constants (was: thrift generated

[jira] [Commented] (THRIFT-4214) map<i64,value> key treated as hex value in JavaScript

2018-03-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399643#comment-16399643 ] Jens Geyer commented on THRIFT-4214: blocker and easyfix and no action for more than 6 months ...

[jira] [Updated] (THRIFT-4214) map<i64,value> key treated as hex value in JavaScript

2018-03-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4214: --- Priority: Critical (was: Blocker) > map key treated as hex value in JavaScript >

[jira] [Updated] (THRIFT-4517) opam that comes with xenial fails "opam init" with stack overflow

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4517: --- Component/s: (was: OCaml - Library) Build Process > opam that

[jira] [Commented] (THRIFT-4517) ocaml 4.02.3-5ubuntu2 released March 7 2018 for xenial fails opam init with stack overflow

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399067#comment-16399067 ] James E. King, III commented on THRIFT-4517: Looks like pulling opam 1.2.2 from github

[jira] [Commented] (THRIFT-4513) thrift generated code is not stable for constants

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399075#comment-16399075 ] ASF GitHub Bot commented on THRIFT-4513: Github user romanoid commented on the issue:

[GitHub] thrift issue #1505: THRIFT-4513: Fixing java thrift compiler to generate con...

2018-03-14 Thread romanoid
Github user romanoid commented on the issue: https://github.com/apache/thrift/pull/1505 Thank you for the review! ---

[jira] [Updated] (THRIFT-4517) opam that comes with xenial fails "opam init" with stack overflow

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4517: --- Description: If one removes /root/.opam in the docker image and then try  {{opam

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398634#comment-16398634 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-03-14 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 We can not directly accept this PR as it contains code that originated in fbthrift. We need someone from Facebook to contribute the code or files back to Apache Thrift for use by the ASF.

Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-14 Thread Allen George
Is anyone having problems compiling master dotnet and csharp on ubuntu-xenial docker? It appears to be bombing out while trying to compile the tutorial. Allen

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398727#comment-16398727 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398728#comment-16398728 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398724#comment-16398724 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174494320 --- Diff: lib/java/gradle/unitTests.gradle --- @@ -68,6 +68,20 @@ test { include '**/Test*.class' exclude '**/Test*\$*.class' +

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1496#discussion_r174495089 --- Diff: test/DoubleConstantsTest.thrift --- @@ -0,0 +1,17 @@ +namespace java thrift.test +namespace cpp thrift.test + +// more tests on

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 Thanks for dealing with the relatively unstable CI. Our project has support for 25 languages, so needless to say without a fixed build environment (which is impossible, since packages change over

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1491 Please rebase on master one more time, most of the build issues are gone now. ---

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

2018-03-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399097#comment-16399097 ] ASF GitHub Bot commented on THRIFT-4489: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

2018-03-14 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399109#comment-16399109 ] Chet Murthy commented on THRIFT-3877: - James, I hope you weren't waiting on me to proceed on this

[jira] [Commented] (THRIFT-4482) error making c++ library on windows 8.1 using cygwin

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399136#comment-16399136 ] James E. King, III commented on THRIFT-4482: I cannot reproduce this locally with cygwin64. 

[jira] [Comment Edited] (THRIFT-4482) error making c++ library on windows 8.1 using cygwin

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399136#comment-16399136 ] James E. King, III edited comment on THRIFT-4482 at 3/14/18 7:10 PM: -

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-14 Thread Jens Geyer
Hi, I just want to emphasize that "bombing out while compiling" is a fairly poor problem description. Even if someone wants to do something about it ... where can we possibly start? As a developer, we should know better. $0,02 JensG -Ursprüngliche Nachricht- From: Allen George

[jira] [Closed] (THRIFT-4517) opam that comes with xenial fails "opam init" with stack overflow

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4517. -- > opam that comes with xenial fails "opam init" with stack overflow >

[jira] [Resolved] (THRIFT-4517) opam that comes with xenial fails "opam init" with stack overflow

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4517. Resolution: Won't Fix ocaml is not currently integrated into the build therefore I

[jira] [Resolved] (THRIFT-4411) SIGABRT in thrift client during program end, C++, using openssl

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4411. Resolution: Information Provided If you are still having an issue feel free to

[jira] [Closed] (THRIFT-4411) SIGABRT in thrift client during program end, C++, using openssl

2018-03-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4411. -- > SIGABRT in thrift client during program end, C++, using openssl >

Re: Problems compiling master dotnet and csharp on ubuntu-xenial docker

2018-03-14 Thread Allen George
Hi JensG and Jim, You’re absolutely right - my initial message wasn't useful; I typed before I thought. Using the ubuntu-xenial docker container. master as of today morning Ran "./bootstrap.sh" followed by “./configure” followed by “make -j2 precross” and then "make precross" I get a large