[jira] [Comment Edited] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437668#comment-16437668 ] Buğra Gedik edited comment on THRIFT-4532 at 4/13/18 5:58 PM: -- Hi [~jking3],

[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268

2018-04-13 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437733#comment-16437733 ] Vihang Karajgaonkar commented on THRIFT-3769: - Moving this forward. When load balancers like

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437668#comment-16437668 ] Buğra Gedik commented on THRIFT-4532: - Hi [~jking3], as we discussed earlier [~mustafa-cosar]

[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437731#comment-16437731 ] ASF GitHub Bot commented on THRIFT-3769: vihangk1 opened a new pull request #1543: THRIFT-3769 :

[jira] [Commented] (THRIFT-4554) uncompileable code with member names that are also types under specific conditions

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438040#comment-16438040 ] ASF GitHub Bot commented on THRIFT-4554: Jens-G closed pull request #1539: THRIFT-4554

[jira] [Resolved] (THRIFT-4554) uncompileable code with member names that are also types under specific conditions

2018-04-13 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4554. Resolution: Fixed Fix Version/s: 0.12.0 > uncompileable code with member names that are

[jira] [Commented] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436885#comment-16436885 ] gansteed commented on THRIFT-4553: -- okay, thank you! I'll close this issue then. > are there any plans

[jira] [Closed] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gansteed closed THRIFT-4553. Resolution: Fixed > are there any plans for add middle-ware support for thrift Go implementation? >

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-13 Thread Ben Podgursky (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436909#comment-16436909 ] Ben Podgursky commented on THRIFT-4555: --- I have created

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436908#comment-16436908 ] ASF GitHub Bot commented on THRIFT-4555: bpodgursky opened a new pull request #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437025#comment-16437025 ] Can Celasun commented on THRIFT-4552: - Let me try to give an example: {code:go} func main() {

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437005#comment-16437005 ] ASF GitHub Bot commented on THRIFT-4555: dcelasun commented on issue #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437127#comment-16437127 ] Can Celasun commented on THRIFT-4552: - OK, go ahead and send a PR. Make sure your commit message

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437123#comment-16437123 ] gansteed commented on THRIFT-4552: -- That's what I mean in last comment, just like you demo. in

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437451#comment-16437451 ] ASF GitHub Bot commented on THRIFT-4552: jiajunhuang opened a new pull request #1542:

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437225#comment-16437225 ] ASF GitHub Bot commented on THRIFT-4532: mustafa-cosar opened a new pull request #1541:

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437226#comment-16437226 ] ASF GitHub Bot commented on THRIFT-4532: mustafa-cosar commented on issue #1541: THRIFT-4532: Do

[jira] [Updated] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4553: --- Priority: Minor (was: Major) > are there any plans for add middle-ware support for

[jira] [Updated] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4553: --- Issue Type: Question (was: New Feature) > are there any plans for add middle-ware

[jira] [Updated] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4552: --- Priority: Minor (was: Major) > why acquire a lock in TSimpleServer implementation

[jira] [Closed] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4553. -- > are there any plans for add middle-ware support for thrift Go implementation? >

[jira] [Reopened] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-4553: Assignee: James E. King, III > are there any plans for add middle-ware support

[jira] [Resolved] (THRIFT-4553) are there any plans for add middle-ware support for thrift Go implementation?

2018-04-13 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4553. Resolution: Information Provided Assignee: Can Celasun (was: James E. King,

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437255#comment-16437255 ] ASF GitHub Bot commented on THRIFT-4532: mustafa-cosar commented on issue #1541: THRIFT-4532: Do

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437254#comment-16437254 ] ASF GitHub Bot commented on THRIFT-4532: mustafa-cosar commented on issue #1541: THRIFT-4532: Do

[jira] [Created] (THRIFT-4556) Make it possible to return an exception to the client.

2018-04-13 Thread Nicolas Krog (JIRA)
Nicolas Krog created THRIFT-4556: Summary: Make it possible to return an exception to the client. Key: THRIFT-4556 URL: https://issues.apache.org/jira/browse/THRIFT-4556 Project: Thrift

[jira] [Updated] (THRIFT-4556) Make it possible to return an exception to the client.

2018-04-13 Thread Nicolas Krog (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Krog updated THRIFT-4556: - Description: Current behavior for Java processor is to do a minor logging of any unhandled