[jira] [Commented] (THRIFT-4031) Go plugin generates invalid code for lists of typedef'ed built-in types

2017-02-22 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879228#comment-15879228 ] Can Celasun commented on THRIFT-4031: - [~jensg] Sounds like a plan. I'll take a shot at this over the

[jira] [Commented] (THRIFT-4031) Go plugin generates invalid code for lists of typedef'ed built-in types

2017-02-21 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876908#comment-15876908 ] Can Celasun commented on THRIFT-4031: - [~jensg] that commit was a while ago, but do you remember why

[jira] [Commented] (THRIFT-4031) Go plugin generates invalid code for lists of typedef'ed built-in types

2017-02-21 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876861#comment-15876861 ] Can Celasun commented on THRIFT-4031: - Seems this was intentional:

[jira] [Closed] (THRIFT-4090) compile error with array of alias in golang

2017-02-21 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4090. --- Resolution: Duplicate Duplicate of [THRIFT-4031|https://issues.apache.org/jira/browse/THRIFT-4031].

[jira] [Created] (THRIFT-4011) Sets/Lists of Thrift structs generate Go code that can't be serialized to JSON

2016-12-21 Thread Can Celasun (JIRA)
Can Celasun created THRIFT-4011: --- Summary: Sets/Lists of Thrift structs generate Go code that can't be serialized to JSON Key: THRIFT-4011 URL: https://issues.apache.org/jira/browse/THRIFT-4011

[jira] [Updated] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2016-12-23 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4011: Description: Consider the following structs: {code} struct Foo { 1: optional string foo }

[jira] [Updated] (THRIFT-4011) Sets of Thrift structs generate Go code that can't be serialized to JSON

2016-12-23 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4011: Summary: Sets of Thrift structs generate Go code that can't be serialized to JSON (was:

[jira] [Commented] (THRIFT-4011) Sets/Lists of Thrift structs generate Go code that can't be serialized to JSON

2016-12-21 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768040#comment-15768040 ] Can Celasun commented on THRIFT-4011: - [~jensg] I could send a patch that uses slices for Thrift's

[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-29 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106166#comment-16106166 ] Can Celasun commented on THRIFT-4253: - Definitely needs some tests, but otherwise LGTM. [~DavinC]

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-08-13 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124973#comment-16124973 ] Can Celasun commented on THRIFT-4285: - I didn't have a chance to review the patch yet, but I really

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-11 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083445#comment-16083445 ] Can Celasun commented on THRIFT-4236: - I realize I'm a bit late to notice this PR since it's already

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-12 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084098#comment-16084098 ] Can Celasun commented on THRIFT-4236: - {quote}So if you have a better idea, please do!{quote} I

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

2017-07-23 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097597#comment-16097597 ] Can Celasun commented on THRIFT-4260: - Yes, because the client is auto generated from the source

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

2017-07-23 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097592#comment-16097592 ] Can Celasun commented on THRIFT-4260: - Yes, there seems to be a bug with the generated code for the

[jira] [Commented] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102695#comment-16102695 ] Can Celasun commented on THRIFT-4261: - {quote}1. support backward compatibility for old function

[jira] [Comment Edited] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101334#comment-16101334 ] Can Celasun edited comment on THRIFT-4261 at 7/26/17 12:42 PM: --- bq. Go

[jira] [Commented] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101334#comment-16101334 ] Can Celasun commented on THRIFT-4261: - > Go projects always use `glide` as version management, which

[jira] [Updated] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4261: Component/s: Go - Library Go - Compiler > Go context generation issue: breaking

[jira] [Commented] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101360#comment-16101360 ] Can Celasun commented on THRIFT-4261: - Also, I'd like to mention that 0.9.3 was tagged almost 2 years

[jira] [Commented] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102295#comment-16102295 ] Can Celasun commented on THRIFT-4261: - Thanks, now I get what you mean. But that's not really

[jira] [Commented] (THRIFT-4261) Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

2017-07-26 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102213#comment-16102213 ] Can Celasun commented on THRIFT-4261: - bq. My concern is for much longer term, when part of repo uses

[jira] [Created] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

2017-05-11 Thread Can Celasun (JIRA)
Can Celasun created THRIFT-4197: --- Summary: Implement transparent gzip compression for HTTP transport Key: THRIFT-4197 URL: https://issues.apache.org/jira/browse/THRIFT-4197 Project: Thrift

[jira] [Closed] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

2017-05-13 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4197. --- > Implement transparent gzip compression for HTTP transport >

[jira] [Resolved] (THRIFT-3365) IDL Union structs nil dereferencing in Go

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-3365. - Resolution: Cannot Reproduce > IDL Union structs nil dereferencing in Go >

[jira] [Commented] (THRIFT-3365) IDL Union structs nil dereferencing in Go

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029189#comment-16029189 ] Can Celasun commented on THRIFT-3365: - This is no longer valid as it works as expected. See

[jira] [Closed] (THRIFT-3553) Go Map value type is dependent on order of entity definitions

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-3553. --- Resolution: Fixed Fix Version/s: 0.10.0 This was indeed fixed by THRIFT-3705. I have a

[jira] [Updated] (THRIFT-3703) Unions Field Count Does Not Consider Map/Set/List Fields

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-3703: Affects Version/s: 0.10.0 > Unions Field Count Does Not Consider Map/Set/List Fields >

[jira] [Resolved] (THRIFT-3466) Set Parameters Have Wrong Key Type in Go Code

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-3466. - Resolution: Fixed Fix Version/s: 0.10.0 This was fixed with

[jira] [Closed] (THRIFT-3466) Set Parameters Have Wrong Key Type in Go Code

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-3466. --- > Set Parameters Have Wrong Key Type in Go Code > - > >

[jira] [Assigned] (THRIFT-3703) Unions Field Count Does Not Consider Map/Set/List Fields

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-3703: --- Assignee: Can Celasun > Unions Field Count Does Not Consider Map/Set/List Fields >

[jira] [Closed] (THRIFT-2483) Go: Provide option to not write default values

2017-05-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-2483. --- Resolution: Fixed Fixed by THRIFT-2451 > Go: Provide option to not write default values >

[jira] [Commented] (THRIFT-4105) used too much memory randomly

2017-05-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031110#comment-16031110 ] Can Celasun commented on THRIFT-4105: - The problem here is not in Thrift. Somebody is sending a

[jira] [Commented] (THRIFT-4215) Golang TTransportFactory Pattern Squelches Errors

2017-05-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031129#comment-16031129 ] Can Celasun commented on THRIFT-4215: - Yes, something like {code} type TTransportFactory interface {

[jira] [Comment Edited] (THRIFT-4215) Golang TTransportFactory Pattern Squelches Errors

2017-05-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031129#comment-16031129 ] Can Celasun edited comment on THRIFT-4215 at 5/31/17 1:15 PM: -- Yes,

[jira] [Closed] (THRIFT-4105) used too much memory randomly

2017-05-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4105. --- Resolution: Not A Bug > used too much memory randomly > - > >

[jira] [Assigned] (THRIFT-4216) Golang Http Clients Do Not Respect User Options

2017-06-02 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4216: --- Assignee: Can Celasun > Golang Http Clients Do Not Respect User Options >

[jira] [Assigned] (THRIFT-4215) Golang TTransportFactory Pattern Squelches Errors

2017-06-02 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4215: --- Assignee: Can Celasun > Golang TTransportFactory Pattern Squelches Errors >

[jira] [Closed] (THRIFT-4216) Golang Http Clients Do Not Respect User Options

2017-06-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4216. --- Resolution: Fixed > Golang Http Clients Do Not Respect User Options >

[jira] [Reopened] (THRIFT-4216) Golang Http Clients Do Not Respect User Options

2017-06-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reopened THRIFT-4216: - > Golang Http Clients Do Not Respect User Options > ---

[jira] [Resolved] (THRIFT-4216) Golang Http Clients Do Not Respect User Options

2017-06-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4216. - Resolution: Fixed Fix Version/s: 0.11.0 > Golang Http Clients Do Not Respect User Options

[jira] [Commented] (THRIFT-4216) Golang Http Clients Do Not Respect User Options

2017-06-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036944#comment-16036944 ] Can Celasun commented on THRIFT-4216: - [~jensg] not exactly a duplicate but yes, it's fixed with that

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043533#comment-16043533 ] Can Celasun commented on THRIFT-4219: - {quote}We should not do anything that breaks

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043451#comment-16043451 ] Can Celasun commented on THRIFT-4219: - [~jmrdi] I agree that the current situation is confusing. In

[jira] [Commented] (THRIFT-4219) Golang Http Clients Created with Nil Buffer

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038395#comment-16038395 ] Can Celasun commented on THRIFT-4219: - [~jmrdi] {{NewTHttpClient}} is for making a single GET

[jira] [Assigned] (THRIFT-3037) Can not build Go code when using typedef in IDL

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-3037: --- Assignee: Can Celasun > Can not build Go code when using typedef in IDL >

[jira] [Commented] (THRIFT-3037) Can not build Go code when using typedef in IDL

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038487#comment-16038487 ] Can Celasun commented on THRIFT-3037: - The easiest fix would be to use Go 1.9 aliases for typedefs.

[jira] [Comment Edited] (THRIFT-4188) Error while flushing write buffer of size 70 to transport, only wrote 0 bytes: write tcp 127.0.0.1:5000->127.0.0.1:58174: write: broken pipe

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038435#comment-16038435 ] Can Celasun edited comment on THRIFT-4188 at 6/6/17 9:19 AM: - FWIW, I can't

[jira] [Commented] (THRIFT-3959) Golang TSimpleServer Is More Of A TThreadedServer?

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038446#comment-16038446 ] Can Celasun commented on THRIFT-3959: - With the upcoming Go 1.9 [type

[jira] [Commented] (THRIFT-4188) Error while flushing write buffer of size 70 to transport, only wrote 0 bytes: write tcp 127.0.0.1:5000->127.0.0.1:58174: write: broken pipe

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038470#comment-16038470 ] Can Celasun commented on THRIFT-4188: - There is nothing to send, I used the code [~brian.kang]

[jira] [Commented] (THRIFT-4188) Error while flushing write buffer of size 70 to transport, only wrote 0 bytes: write tcp 127.0.0.1:5000->127.0.0.1:58174: write: broken pipe

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038435#comment-16038435 ] Can Celasun commented on THRIFT-4188: - FWIW, I can't reproduce this at all with Go 1.8.1 on Arch

[jira] [Assigned] (THRIFT-3491) Invalid Go Code From Service Signatures With Typedef'd Structs

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-3491: --- Assignee: Can Celasun > Invalid Go Code From Service Signatures With Typedef'd Structs >

[jira] [Commented] (THRIFT-3491) Invalid Go Code From Service Signatures With Typedef'd Structs

2017-06-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038492#comment-16038492 ] Can Celasun commented on THRIFT-3491: - Similar to THRIFT-3037, this can also be solved with aliases

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-09 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044830#comment-16044830 ] Can Celasun commented on THRIFT-4219: - Noted. I'll keep the design principles in mind and send a

[jira] [Assigned] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-09 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4219: --- Assignee: Can Celasun > Golang HTTP clients created with Nil buffer >

[jira] [Commented] (THRIFT-4335) Golang TPipe Windows implementation

2017-09-19 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171193#comment-16171193 ] Can Celasun commented on THRIFT-4335: - The trouble is, we don't currently depend on anything outside

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-09-21 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174844#comment-16174844 ] Can Celasun commented on THRIFT-4285: - Just had a chance to review. The patch doesn't apply cleanly

[jira] [Assigned] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-09-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4320: --- Assignee: Can Celasun > Use interface instead of strict http.Client type in

[jira] [Commented] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-09-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158299#comment-16158299 ] Can Celasun commented on THRIFT-4320: - Makes sense. I'll do it over the weekend. > Use interface

[jira] [Commented] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-09-12 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162813#comment-16162813 ] Can Celasun commented on THRIFT-4320: - On second thought, this isn't necessary. In {{http_client.go}}

[jira] [Comment Edited] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-09-12 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162813#comment-16162813 ] Can Celasun edited comment on THRIFT-4320 at 9/12/17 11:29 AM: --- On second

[jira] [Assigned] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-09-12 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4320: --- Assignee: (was: Can Celasun) > Use interface instead of strict http.Client type in

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-08-29 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145048#comment-16145048 ] Can Celasun commented on THRIFT-4285: - Tried running the tests, there are some failures: {code}

[jira] [Commented] (THRIFT-4298) Fix Ubuntu Xenial build environment for the go 1.6 language

2017-09-01 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150139#comment-16150139 ] Can Celasun commented on THRIFT-4298: - The Go package in Ubuntu is very weird as it doesn't include

[jira] [Created] (THRIFT-4427) Thrift 0.11 is not available on npm

2017-12-15 Thread Can Celasun (JIRA)
Can Celasun created THRIFT-4427: --- Summary: Thrift 0.11 is not available on npm Key: THRIFT-4427 URL: https://issues.apache.org/jira/browse/THRIFT-4427 Project: Thrift Issue Type: Task

[jira] [Comment Edited] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-12-15 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162813#comment-16162813 ] Can Celasun edited comment on THRIFT-4320 at 12/15/17 12:00 PM: This

[jira] [Issue Comment Deleted] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions

2017-12-15 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4320: Comment: was deleted (was: Makes sense. I'll do it over the weekend.) > Use interface instead of

[jira] [Assigned] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

2017-11-03 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4285: --- Assignee: Can Celasun (was: Chris Bannister) > Pull generated send/recv into library to

[jira] [Assigned] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4573: --- Assignee: Can Celasun > Unions Field Count Does Not Consider Binary >

[jira] [Updated] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4573: Affects Version/s: 0.11.0 > Unions Field Count Does Not Consider Binary >

[jira] [Updated] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4573: Fix Version/s: 0.12.0 > Unions Field Count Does Not Consider Binary >

[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478837#comment-16478837 ] Can Celasun commented on THRIFT-4573: - [~simplee] Thanks for the report, I've just pushed a fixed for

[jira] [Assigned] (THRIFT-4542) git.apache.org/thrift.git unavailable

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun reassigned THRIFT-4542: --- Assignee: (was: Can Celasun) > git.apache.org/thrift.git unavailable >

[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479223#comment-16479223 ] Can Celasun commented on THRIFT-4573: - I will, just waiting for the reporter to confirm. > Unions

[jira] [Closed] (THRIFT-4573) Unions Field Count Does Not Consider Binary

2018-05-17 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4573. --- > Unions Field Count Does Not Consider Binary > --- > >

[jira] [Comment Edited] (THRIFT-4607) Go - Making concurrent connection resulting EOF

2018-07-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563620#comment-16563620 ] Can Celasun edited comment on THRIFT-4607 at 7/31/18 12:48 PM: --- Can you

[jira] [Commented] (THRIFT-4607) Go - Making concurrent connection resulting EOF

2018-07-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563620#comment-16563620 ] Can Celasun commented on THRIFT-4607: - Can you reproduce this with latest thrift (0.11)? If you can

[jira] [Updated] (THRIFT-4607) Go - Making concurrent connection resulting EOF

2018-07-31 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4607: Priority: Minor (was: Blocker) > Go - Making concurrent connection resulting EOF >

[jira] [Commented] (THRIFT-4610) [GO] Include directive compiles to language-default import

2018-08-04 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569319#comment-16569319 ] Can Celasun commented on THRIFT-4610: - There shouldn't be {code:java} import "shared" {code} in the

[jira] [Commented] (THRIFT-4610) [GO] Include directive compiles to language-default import

2018-08-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569400#comment-16569400 ] Can Celasun commented on THRIFT-4610: - >From "thrift --help": {code:java}   -r[ecurse]  Also

[jira] [Updated] (THRIFT-4610) [GO] Include directive compiles to language-default import

2018-08-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4610: Priority: Minor (was: Critical) > [GO] Include directive compiles to language-default import >

[jira] [Resolved] (THRIFT-4610) [GO] Include directive compiles to language-default import

2018-08-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4610. - Resolution: Invalid > [GO] Include directive compiles to language-default import >

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-05 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569763#comment-16569763 ] Can Celasun commented on THRIFT-4611: - If I understand correctly, you are trying to decode arbitrary

[jira] [Updated] (THRIFT-4617) Avoid generating conflicting struct names in Rust code

2018-08-10 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4617: Fix Version/s: 0.12.0 > Avoid generating conflicting struct names in Rust code >

[jira] [Updated] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4611: Component/s: (was: Node.js - Library) (was: JavaScript - Library)

[jira] [Updated] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4611: Issue Type: Improvement (was: Wish) > NodeJS thrift enums not mappable back to their string

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570823#comment-16570823 ] Can Celasun commented on THRIFT-4611: - {code:java} Variable Common_ttypes, which contains the

[jira] [Commented] (THRIFT-4612) Add THeader for Go

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570829#comment-16570829 ] Can Celasun commented on THRIFT-4612: - I'd be happy to see a PR for this, please go ahead. Just try

[jira] [Resolved] (THRIFT-4614) Generate missing @Nullable annotations for Java iterator getters

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4614. - Resolution: Fixed Fix Version/s: 0.12.0 > Generate missing @Nullable annotations for

[jira] [Commented] (THRIFT-4607) Go - Making concurrent connection resulting EOF

2018-08-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572748#comment-16572748 ] Can Celasun commented on THRIFT-4607: - I don't see any shared state in your gist that would cause a

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570162#comment-16570162 ] Can Celasun commented on THRIFT-4611: - I'm not familiar with JS (or the thrift JS client), so maybe

[jira] [Updated] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4611: Issue Type: Wish (was: Bug) > NodeJS thrift enums not mappable back to their string values >

[jira] [Updated] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4611: Priority: Minor (was: Major) > NodeJS thrift enums not mappable back to their string values >

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570251#comment-16570251 ] Can Celasun commented on THRIFT-4611: - Thanks Brian. Since there is a workaround, I've changed the

[jira] [Updated] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun updated THRIFT-4611: Component/s: (was: Node.js - Compiler) Node.js - Library

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-07 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571934#comment-16571934 ] Can Celasun commented on THRIFT-4611: - The goal is the latter. We can't do the former because it

[jira] [Commented] (THRIFT-4607) Go - Making concurrent connection resulting EOF

2018-08-10 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575839#comment-16575839 ] Can Celasun commented on THRIFT-4607: - I didn't have time to look at it yet. Maybe over the weekend.

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-08 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573596#comment-16573596 ] Can Celasun commented on THRIFT-4611: - As I've said, I'm not really familiar with JS or Thrift's JS

[jira] [Commented] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570469#comment-16570469 ] Can Celasun commented on THRIFT-4611: - First, I think there is a misunderstanding here. If you have

[jira] [Comment Edited] (THRIFT-4611) NodeJS thrift enums not mappable back to their string values

2018-08-06 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570469#comment-16570469 ] Can Celasun edited comment on THRIFT-4611 at 8/6/18 4:44 PM: - First, I think

[jira] [Closed] (THRIFT-4619) Transport SASL Client fo go

2018-08-28 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun closed THRIFT-4619. --- Resolution: Information Provided > Transport SASL Client fo go > --- > >

  1   2   >