[jira] [Comment Edited] (THRIFT-4593) Unit Tests failing on Alpine Linux due to non-portable mutex initializers

2019-01-11 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740432#comment-16740432 ] Christopher Friedt edited comment on THRIFT-4593 at 1/11/19 2:27 PM: -

[jira] [Commented] (THRIFT-4593) Unit Tests failing on Alpine Linux due to non-portable mutex initializers

2019-01-11 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740432#comment-16740432 ] Christopher Friedt commented on THRIFT-4593: Actually, the problem was with

[jira] [Created] (THRIFT-5079) [CPP] Required fields need to be verified before write

2020-01-29 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5079: -- Summary: [CPP] Required fields need to be verified before write Key: THRIFT-5079 URL: https://issues.apache.org/jira/browse/THRIFT-5079 Project: Thrift

[jira] [Created] (THRIFT-5093) TMemoryBuffer constructor initializes wpos incorrectly

2020-02-14 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5093: -- Summary: TMemoryBuffer constructor initializes wpos incorrectly Key: THRIFT-5093 URL: https://issues.apache.org/jira/browse/THRIFT-5093 Project: Thrift

[jira] [Updated] (THRIFT-5093) TMemoryBuffer fix wpos for policy == OBSERVER

2020-06-19 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Summary: TMemoryBuffer fix wpos for policy == OBSERVER (was: TMemoryBuffer constru

[jira] [Updated] (THRIFT-5093) TMemoryBuffer constructor initializes wpos incorrectly

2020-06-19 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Description: The TMemoryBuffer policy is "OBSERVER" by default in a constructor wher

[jira] [Commented] (THRIFT-5093) TMemoryBuffer fix wpos for policy == OBSERVER

2020-06-19 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140917#comment-17140917 ] Christopher Friedt commented on THRIFT-5093: Is anyone able to do this revie

[jira] [Created] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5429: -- Summary: build: autotools: add foreign to AM_INIT_AUTOMAKE Key: THRIFT-5429 URL: https://issues.apache.org/jira/browse/THRIFT-5429 Project: Thrift

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add `foreign` to `AM_INIT_AUTOMAKE()` in `configure.ac` to prevent erro

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent erro

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent auto

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent auto

[jira] [Commented] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357856#comment-17357856 ] Christopher Friedt commented on THRIFT-5429: GitHub PR: https://github.com/a

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent auto

[jira] [Updated] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5429: --- Description: Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent auto

[jira] [Commented] (THRIFT-5429) build: autotools: add foreign to AM_INIT_AUTOMAKE

2021-06-06 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358224#comment-17358224 ] Christopher Friedt commented on THRIFT-5429: It's ready > build: autotools:

[jira] [Commented] (THRIFT-4910) ./configure: line 14116: syntax error near unexpected token `QT5,'

2022-01-23 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480625#comment-17480625 ] Christopher Friedt commented on THRIFT-4910: This can be solved pretty trivi

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify beha

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Issue Type: Improvement (was: Bug) > TMemoryBuffer: add test cases to clarify beha

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify beha

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Priority: Minor (was: Major) > TMemoryBuffer: add test cases to clarify beha >

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify beha

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Summary: TMemoryBuffer: add test cases to clarify beha (was: TMemoryBuffer fix wpos

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify behaviour of MemoryPolicy

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Summary: TMemoryBuffer: add test cases to clarify behaviour of MemoryPolicy (was: T

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify beha

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Affects Version/s: 0.17.0 (was: 0.10.0)

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify behaviour of MemoryPolicy

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Description: My main use case with the original code change was that I wanted to be

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify behaviour of MemoryPolicy

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Description: My main use case with the original code change was that I wanted to be

[jira] [Updated] (THRIFT-5093) TMemoryBuffer: add test cases to clarify behaviour of MemoryPolicy

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Description: My main use case for {{TMemoryBuffer}} was that I wanted to be able to

[jira] [Updated] (THRIFT-5093) lib: cpp: tests to clarify effect of MemoryPolicy on TMemoryBuffer behaviour

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Summary: lib: cpp: tests to clarify effect of MemoryPolicy on TMemoryBuffer behaviou

[jira] [Updated] (THRIFT-5093) lib: cpp: test: clarify effect of MemoryPolicy on TMemoryBuffer

2022-04-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5093: --- Summary: lib: cpp: test: clarify effect of MemoryPolicy on TMemoryBuffer (was: lib:

[jira] [Created] (THRIFT-5658) lib: cpp: TProtocol: support zephyr byteorder

2022-10-25 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5658: -- Summary: lib: cpp: TProtocol: support zephyr byteorder Key: THRIFT-5658 URL: https://issues.apache.org/jira/browse/THRIFT-5658 Project: Thrift I

[jira] [Created] (THRIFT-5659) lib: cpp: protocol: declare when methods override

2022-10-25 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5659: -- Summary: lib: cpp: protocol: declare when methods override Key: THRIFT-5659 URL: https://issues.apache.org/jira/browse/THRIFT-5659 Project: Thrift

[jira] [Updated] (THRIFT-5659) lib: cpp: protocol: declare when methods override

2022-10-25 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5659: --- Description: {{This avoids compiler warnings about inconsistent use of `override` li

[jira] [Updated] (THRIFT-5659) lib: cpp: protocol: declare when methods override

2022-10-25 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5659: --- Description: This avoids compiler warnings about inconsistent use of `override` like

[jira] [Assigned] (THRIFT-5659) lib: cpp: protocol: declare when methods override

2022-10-25 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt reassigned THRIFT-5659: -- Assignee: Christopher Friedt > lib: cpp: protocol: declare when methods overr

[jira] [Created] (THRIFT-5660) lib: cpp: TTransportException: create thrift::numeric_cast

2022-10-25 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5660: -- Summary: lib: cpp: TTransportException: create thrift::numeric_cast Key: THRIFT-5660 URL: https://issues.apache.org/jira/browse/THRIFT-5660 Project: Thrift

[jira] [Created] (THRIFT-5661) lib: cpp: TOutput: add zephyr-specific strerror_s implementation

2022-10-25 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5661: -- Summary: lib: cpp: TOutput: add zephyr-specific strerror_s implementation Key: THRIFT-5661 URL: https://issues.apache.org/jira/browse/THRIFT-5661 Project:

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2022-10-25 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623777#comment-17623777 ] Christopher Friedt commented on THRIFT-4037: I've been using Thrift for quit

[jira] [Comment Edited] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2022-10-25 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623777#comment-17623777 ] Christopher Friedt edited comment on THRIFT-4037 at 10/25/22 11:44 AM: ---

[jira] [Created] (THRIFT-5663) lib: cpp: usleep was not declared in this scope

2022-10-26 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5663: -- Summary: lib: cpp: usleep was not declared in this scope Key: THRIFT-5663 URL: https://issues.apache.org/jira/browse/THRIFT-5663 Project: Thrift

[jira] [Commented] (THRIFT-5663) lib: cpp: usleep was not declared in this scope

2022-10-26 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624795#comment-17624795 ] Christopher Friedt commented on THRIFT-5663: PR is here https://github.com/a

[jira] [Updated] (THRIFT-5663) lib: cpp: usleep was not declared in this scope

2022-10-27 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5663: --- Description: Several build failures in Travis resulted from an include-order problem

[jira] [Created] (THRIFT-5665) include-order issue in TSocket.cpp

2022-10-28 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5665: -- Summary: include-order issue in TSocket.cpp Key: THRIFT-5665 URL: https://issues.apache.org/jira/browse/THRIFT-5665 Project: Thrift Issue Type: B

[jira] [Closed] (THRIFT-5665) include-order issue in TSocket.cpp

2022-10-28 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt closed THRIFT-5665. -- Resolution: Fixed It looks like it's not an include order issue after all > include-o

[jira] [Created] (THRIFT-5666) use poll.h instead of sys/poll.h

2022-10-28 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5666: -- Summary: use poll.h instead of sys/poll.h Key: THRIFT-5666 URL: https://issues.apache.org/jira/browse/THRIFT-5666 Project: Thrift Issue Type: Imp

[jira] [Updated] (THRIFT-5666) use poll.h instead of sys/poll.h

2022-10-28 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: The sys/poll.h header is not actually specified by POSIX and is therefo

[jira] [Updated] (THRIFT-5666) use poll.h instead of sys/poll.h

2022-10-28 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Component/s: (was: C glib - Library) > use poll.h instead of sys/poll.h > --

[jira] [Updated] (THRIFT-5666) lib: cpp: prefer poll.h over sys/poll.h

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Summary: lib: cpp: prefer poll.h over sys/poll.h (was: use poll.h instead of sys/po

[jira] [Updated] (THRIFT-5666) lib: cpp: prefer poll.h over sys/poll.h

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: The header is not actually where poll(2) must be defined according to

[jira] [Updated] (THRIFT-5666) lib: cpp: prefer poll.h over sys/poll.h

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Issue Type: Bug (was: Improvement) > lib: cpp: prefer poll.h over sys/poll.h >

[jira] [Updated] (THRIFT-5666) lib: cpp: prefer poll.h over sys/poll.h

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: Multiple errors of this form when `HAVE_POLL_H` is defined but `HAVE_S

[jira] [Updated] (THRIFT-5666) lib: cpp: prefer poll.h over sys/poll.h

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: Multiple errors of this form when *HAVE_POLL_H* is defined but *HAVE_S

[jira] [Updated] (THRIFT-5666) lib: cpp: build fails when

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Summary: lib: cpp: build fails when (was: lib: cpp: prefer poll.h over sys/poll.h)

[jira] [Updated] (THRIFT-5666) lib: cpp: build fails when non-standard sys/poll.h is not present

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Summary: lib: cpp: build fails when non-standard sys/poll.h is not present (was: li

[jira] [Updated] (THRIFT-5666) lib: cpp: build fails when non-standard sys/poll.h is not present

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: Multiple errors of this form when *HAVE_POLL_H* is defined but *HAVE_S

[jira] [Updated] (THRIFT-5666) lib: cpp: build fails when non-standard sys/poll.h is not present

2022-11-05 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5666: --- Description: Multiple errors of this form when *HAVE_POLL_H* is defined but *HAVE_S

[jira] [Created] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-17 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5677: -- Summary: lib: cpp: transport: file descriptor leak in TServerSocket::close() Key: THRIFT-5677 URL: https://issues.apache.org/jira/browse/THRIFT-5677 Proje

[jira] [Updated] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-17 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5677: --- Description: It would appear that there is a possible file descriptor leak in TServ

[jira] [Updated] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-17 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5677: --- Description: It would appear that there is a possible file descriptor leak in TServ

[jira] [Commented] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-17 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677802#comment-17677802 ] Christopher Friedt commented on THRIFT-5677: PR is [https://github.com/apach

[jira] [Comment Edited] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-17 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677802#comment-17677802 ] Christopher Friedt edited comment on THRIFT-5677 at 1/17/23 3:18 PM: -

[jira] [Closed] (THRIFT-5677) lib: cpp: transport: file descriptor leak in TServerSocket::close()

2023-01-18 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt closed THRIFT-5677. -- Resolution: Invalid There is already a custom deleter. It seems that the C++ runtime m

[jira] [Created] (THRIFT-5678) lib: cpp: TConnectedClient

2023-01-20 Thread Christopher Friedt (Jira)
Christopher Friedt created THRIFT-5678: -- Summary: lib: cpp: TConnectedClient Key: THRIFT-5678 URL: https://issues.apache.org/jira/browse/THRIFT-5678 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-5678) lib: cpp: TConnectedClient: warning due to non-virtual dtor

2023-01-20 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5678: --- Summary: lib: cpp: TConnectedClient: warning due to non-virtual dtor (was: lib: cpp

[jira] [Updated] (THRIFT-5678) lib: cpp: TConnectedClient: warning due to non-virtual dtor

2023-01-20 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-5678: --- Description: In TConnectedClient.h the destructor is non-virtual, which causes the w

[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679452#comment-17679452 ] Christopher Friedt commented on THRIFT-5678: I would agree with Mario. Unles

[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679453#comment-17679453 ] Christopher Friedt commented on THRIFT-5678: I would be happy to expand the

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2023-08-27 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759368#comment-17759368 ] Christopher Friedt commented on THRIFT-4037: It doesn't support every langua

[jira] [Commented] (THRIFT-5660) TTransportException: create thrift::numeric_cast

2023-10-14 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775197#comment-17775197 ] Christopher Friedt commented on THRIFT-5660: Hi wow - thanks for bringing th

[jira] [Commented] (THRIFT-5660) TTransportException: create thrift::numeric_cast

2023-10-14 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775269#comment-17775269 ] Christopher Friedt commented on THRIFT-5660: Reverting is fine with me for n

[jira] [Comment Edited] (THRIFT-5660) TTransportException: create thrift::numeric_cast

2023-10-14 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775197#comment-17775197 ] Christopher Friedt edited comment on THRIFT-5660 at 10/14/23 4:36 PM:

[jira] [Created] (THRIFT-4546) Thrift No Longer on ASF Git

2018-04-06 Thread Christopher Friedt (JIRA)
Christopher Friedt created THRIFT-4546: -- Summary: Thrift No Longer on ASF Git Key: THRIFT-4546 URL: https://issues.apache.org/jira/browse/THRIFT-4546 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-4593) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
Christopher Friedt created THRIFT-4593: -- Summary: Unit Tests failing Key: THRIFT-4593 URL: https://issues.apache.org/jira/browse/THRIFT-4593 Project: Thrift Issue Type: Bug Com

[jira] [Created] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
Christopher Friedt created THRIFT-4594: -- Summary: Unit Tests failing Key: THRIFT-4594 URL: https://issues.apache.org/jira/browse/THRIFT-4594 Project: Thrift Issue Type: Bug Com

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: thrift-ci-build-20180627.tar.gz > Unit Tests failing > -

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged rel

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged rel

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged rel

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged rel

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged rel

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Summary: Unable to Build Test Suite in Alpine Linux (was: Unit Tests failing) > Un

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the lib/cpp/test suite is not passing when run inside of

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Description: It seems that the 0.11.0 lib/cpp/test suite is not building correctly w

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-06-29 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527618#comment-16527618 ] Christopher Friedt commented on THRIFT-4594: Hi [~jking3], you know what - I

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529080#comment-16529080 ] Christopher Friedt commented on THRIFT-4594: OK, some further investigation:

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529080#comment-16529080 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 12:48 PM: -

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529080#comment-16529080 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 12:48 PM: -

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529080#comment-16529080 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 12:49 PM: -

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529083#comment-16529083 ] Christopher Friedt commented on THRIFT-4594: The question is whether to "fix

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529080#comment-16529080 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 12:56 PM: -

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: (was: thrift-ci-build-20180627.tar.gz) > Unable to Build Test Suite

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: thrift-alpine-20180701.tar.gz > Unable to Build Test Suite in Alpine Lin

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529085#comment-16529085 ] Christopher Friedt commented on THRIFT-4594: Actually, this [snippet from mu

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: make-check-macos-10.13.5.text > Unable to Build Test Suite in Alpine Lin

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: make-check-alpine-3.8.txt > Unable to Build Test Suite in Alpine Linux >

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: musl-1.1.19-mtx-init-supported-types.patch > Unable to Build Test Suite

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529085#comment-16529085 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 2:05 PM: --

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529132#comment-16529132 ] Christopher Friedt commented on THRIFT-4594: Rich, the Thrift code doesn't b

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529132#comment-16529132 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 3:23 PM: --

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529132#comment-16529132 ] Christopher Friedt edited comment on THRIFT-4594 at 7/1/18 3:26 PM: --

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-01 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: (was: musl-1.1.19-mtx-init-supported-types.patch) > Unable to Build

[jira] [Commented] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-07 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535965#comment-16535965 ] Christopher Friedt commented on THRIFT-4594: Aha! Maybe I was too quick to

[jira] [Comment Edited] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-07-07 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535965#comment-16535965 ] Christopher Friedt edited comment on THRIFT-4594 at 7/8/18 3:01 AM: --

  1   2   >