Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138845074
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -100,13 +108,26 @@ class TimerManager {
*/
virtual void remove(stdcxx::shared_ptr
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138849538
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.h ---
@@ -69,28 +72,33 @@ class TimerManager {
*
* @param task The task to execute
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1353#discussion_r138849560
--- Diff: lib/cpp/test/concurrency/TimerManagerTests.h ---
@@ -192,6 +192,38 @@ class TimerManagerTests {
return true
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1337#discussion_r137809132
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.cpp ---
@@ -52,6 +52,8 @@ class TimerManager::Task : public Runnable
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1337#discussion_r137808236
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.cpp ---
@@ -290,11 +292,23 @@ void TimerManager::add(shared_ptr task,
const struct timeval& v
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1337#discussion_r137810110
--- Diff: lib/cpp/test/concurrency/TimerManagerTests.h ---
@@ -126,6 +126,38 @@ class TimerManagerTests {
return true
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1337#discussion_r137811890
--- Diff: lib/cpp/src/thrift/concurrency/TimerManager.cpp ---
@@ -290,11 +292,23 @@ void TimerManager::add(shared_ptr task,
const struct timeval& v
GitHub user Typz opened a pull request:
https://github.com/apache/thrift/pull/1353
THRIFT-4327: add API to efficiently remove a single timer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Typz/thrift THRIFT-4327
Alternatively
GitHub user Typz opened a pull request:
https://github.com/apache/thrift/pull/1337
THRIFT-4292: Implement TimerManager::remove()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Typz/thrift THRIFT-4292
Alternatively you can
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
I have an issue with UBSan build: it keeps failing in codecvt, which may be
due either to a bug in StdLib or simply to that lib not being compiled with
UBSan... Any idea how to overcome this, and let
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1448#discussion_r161516311
--- Diff: appveyor.yml ---
@@ -45,7 +45,7 @@ environment:
- PROFILE: MSVC2015
PLATFORM: x64
CONFIGURATION: Release
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
@jeking3 : This exemple refers to conversions from 'wide' strings to UTF8
or UTF16. I used this exemple:
http://en.cppreference.com/w/cpp/locale/codecvt_utf8_utf16 which shows
conversion from UTF16
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
@jeking3 : any suggestion?
---
Github user Typz commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1448#discussion_r159267705
--- Diff: lib/cpp/src/thrift/processor/TMultiplexedProcessor.h ---
@@ -165,10 +166,11 @@ class TMultiplexedProcessor : public TProcessor
GitHub user Typz opened a pull request:
https://github.com/apache/thrift/pull/1448
[WIP] Support compilation without Boost
The goal of this series of patches is to support compiling Thrift library
without boost: in C++11, most of the things are already integrated, and it is
often
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
Indeed, it is complete now: the lib can be built without Boost, both
through autoconf or cmake.
Tests (based on boost test) and tutorial still require boost, though.
---
Github user Typz commented on the issue:
https://github.com/apache/thrift/pull/1448
Squashed everything in one big patch.
---
17 matches
Mail list logo
