Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/1032
:+1: makes sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1033#discussion_r68087439
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -520,23 +523,23 @@ void TServerSocket::listen() {
if (retries > retryLim
Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/1033
:+1: I don't really mind if you want to leave the two noted lines as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1033#discussion_r68087139
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -284,7 +284,7 @@ void TServerSocket::listen() {
hints.ai_family = PF_UNSPEC
Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/959
@jeking3 Thanks for catching it. It is rebased correctly now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r58814042
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -92,29 +97,42 @@ TThreadedServer::~TThreadedServer() {
void TThreadedServer::serve
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59304879
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.h ---
@@ -83,12 +88,56 @@ class TThreadedServer : public TServerFramework {
virtual void serve
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59304884
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59305327
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/959
THRIFT-3753 Fixed a race condition in TServerFramework::stop that prevents
clean server shutdown
This is a sequence that exposes the race condition:
(1) Thread-1: in serve(), blocked on accept
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/960
THRIFT-3755 TDebugProtocol::writeString hits assert in isprint on Windows
with debug CRT
Passing characters <0 to std::isprint causes asserts.
You can merge this pull request into a Git reposit
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/962
THRIFT-3757 Fix various compile warnings with VS2015
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tpcwang/thrift THRIFT-3757
Alternatively
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/977#discussion_r58472724
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.h ---
@@ -20,19 +20,26 @@
#ifndef _THRIFT_SERVER_TTHREADEDSERVER_H_
#define
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/977#discussion_r58473198
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -77,44 +83,29 @@ TThreadedServer::TThreadedServer(const
shared_ptr& proce
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/977#discussion_r58473050
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.h ---
@@ -20,19 +20,26 @@
#ifndef _THRIFT_SERVER_TTHREADEDSERVER_H_
#define
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r60614631
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r60612338
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r61581424
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r61601611
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on the pull request:
https://github.com/apache/thrift/pull/980#issuecomment-215848959
LGTM. Thanks for fixing this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r61534321
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1005#discussion_r62278341
--- Diff: lib/cpp/test/TNonblockingServerTest.cpp ---
@@ -47,14 +47,32 @@ struct Handler : public test::ParentServiceIf {
class Fixture {
private
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59996235
--- Diff: lib/cpp/test/TServerIntegrationTest.cpp ---
@@ -152,7 +155,10 @@ class TServerIntegrationTestFixture {
new
Github user tpcwang commented on the pull request:
https://github.com/apache/thrift/pull/980#issuecomment-211137935
I think this change looks good for the most part, maybe we can get one of
the maintainers to look at it?
---
If your project is set up for it, you can reply
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59995963
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59996087
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer
Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/1050
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/1044
I didn't review the changes in detail, but I agree with the change and like
the fact that we can compile cleanly with /W3 :+1:
---
If your project is set up for it, you can reply to this email
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/1110
THRIFT-3944 TSSLSocket has dead code in checkHandshake
See https://issues.apache.org/jira/browse/THRIFT-3944 for why I think this
can be safely removed without changing functionality.
You can
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1108#discussion_r82233502
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -57,12 +54,6 @@ struct GlobalFixtureSSL
BOOST_TEST_MESSAGE(boost::format("ar
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/1108
THRIFT-3942 Make TSSLSocket honor send and receive timeouts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tpcwang/thrift THRIFT-3942
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/1107
THRIFT-3941 WinXP version of thrift_poll() relies on undefined behavior by
passing a destructed variable to select()
You can merge this pull request into a Git repository by running:
$ git
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1108#discussion_r82062644
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -57,12 +54,6 @@ struct GlobalFixtureSSL
BOOST_TEST_MESSAGE(boost::format("ar
33 matches
Mail list logo
