[GitHub] thrift issue #1326: THRIFT-3821

2017-08-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1326 I'd prefer if we refactored it to make the limit configurable with a default matching what it is now; that way tests won't need multiple gigabytes of memory to function properly. I'll approve and

[GitHub] thrift issue #1326: THRIFT-3821

2017-08-12 Thread asuhan
Github user asuhan commented on the issue: https://github.com/apache/thrift/pull/1326 Are there any additional changes I should make to this pull request? As I've said in the inline comment, I believe comparing to `std::numeric_limits::max()` is actually consistent with what the