Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Since it's just documentation if you want to add it as a patch to a ticket
instead of putting it through CI, someone can merge it from there.
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
> That needs to be documented in the dlang readme - would you be able to
document that in a separate PR?
Sorry for the delay. I'll open a ticket and send a patch over the weekend.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Excellent, I will merge this, and we'll get it into 0.11.0 - so yay! We
can consider the backwards-compatible construction adapter to be deprecated so
that it can be removed in the follow-on
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
@jeking3 All done! I think we are good to merge, what do you think?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
0.11.0 cycle hasn't started yet - you still have some time (I don't know
how much).
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
@jeking3 Is there a deadline for 0.11? I really want to get this into the
next release, but likely won't have enough time to finish it up in the next
week or so.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Given the backlog on the project, I don't blame you! :)
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
> Is there a way you can provide a generated NewFooClientFactory as an
adapter to run the new code?
It would require putting back some of the generated code, but I'll try to
find a way. I
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
ping @jeking3
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
> I don't think we can unilaterally require go 1.9 at this point without
causing some pain, but I'm not sure.
This change doesn't effect the user, it's only needed for the tests. Though
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
We support go back to version 1.2.1 or 1.4.3 (I can't remember which, but I
think 1.2.1 is on trusty). That said, I'm in the middle of reworking the
docker images to be as stock as possible, and
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1382
Travis failure is unrelated, all Go tests are green.
cc @jeking3 thoughts?
---
12 matches
Mail list logo
