Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
@dcelasun squashed
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1479
@RobberPhex can you squash your commits?
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1479
Added some doc comments. The actual code looks fine to me.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
Any other php folks out there want to comment or review on the breaking
change here? It looks like the strategy was to change the generator and
provide a flag to allow folks to generate older
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
Document all breaking changes in the language README.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
If we are making breaking changes, they need to be documented very clearly
in the php/README.md file as part of any commit. See my breaking changes for
0.10.0 and 0.11.0 in the perl/README.md for
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
Personally, I think we can mark classmap/old-style PHP compiler deprecated.
And can be removed in future.
And, ThriftClassLoader can also be removed in future, to migrate composer
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
There are some break changes:
1. for generated code, old struct is `Types.php` for all args, results,
`.php` for `ServiceIf`, `ServiceClient`, etc.
new struct is `.php` for ``.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
Are these changes all backwards compatible?
---
