[GitHub] thrift issue #1506: THRIFT-4509: grunt update (rebased)

2018-03-13 Thread bananer 
Github user bananer commented on the issue:

https://github.com/apache/thrift/pull/1506
  
@jeking3 I think all the problems mentioned in THRIFT-4509 are resolved 
now. With the package-lock being included now, there should also be less random 
build failures. The node and js parts of thrift could still use some cleanup 
and modernization, but I will leave that for a separate ticket.


---

[GitHub] thrift issue #1506: THRIFT-4509: grunt update (rebased)

2018-03-13 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1506
  
With this merged would you say that THRIFT-4509 is now fixed, or is there 
more work to do?


---

[GitHub] thrift issue #1506: THRIFT-4509: grunt update (rebased)

2018-03-12 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1506
  
I see, you need to build Java first?


---