[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
GitHub user bgedik reopened a pull request: https://github.com/apache/thrift/pull/1476 Remove premature call to workSocket() in TNonblockingServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/bgedik/thrift

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
Github user bgedik closed the pull request at: https://github.com/apache/thrift/pull/1476 ---

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-02-19 Thread bgedik
Github user bgedik closed the pull request at: https://github.com/apache/thrift/pull/1476 ---

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163681677 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163679874 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() { close(); } +bool

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163673632 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() { close(); } +bool

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163663375 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() { close(); } +bool

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163664502 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163663584 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() { close(); } +bool

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163651048 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163640014 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163623295 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163622772 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-23 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163420333 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();

[GitHub] thrift pull request #1476: Remove premature call to workSocket() in TNonbloc...

2018-01-23 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1476#discussion_r163418365 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h --- @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket { bool peek(); void open();