[jira] [Commented] (THRIFT-2357) recurse option has no effect when generating php
[
https://issues.apache.org/jira/browse/THRIFT-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713605#comment-15713605
]
Jens Geyer commented on THRIFT-2357:
{quote}
But all my thrift files share the same namespace. I think it should be
acceptable for multiple files to share one namespace. Is that right?
{quote}
Each Thrift file should have its own namespace. Otherwise it may happen with
certain languages that files get overriden due to file naming conflicts. If
you're lucky, you are not affected by this but if someone starts to use your
IDL with other languages may be affected. So the best advise is to avoid it
form the beginning.
Note that you may specify namespaces on a per-language Basis, the "catch all"
form {{namespace * foo.bar.baz}} is not always suitable.
> recurse option has no effect when generating php
>
>
> Key: THRIFT-2357
> URL: https://issues.apache.org/jira/browse/THRIFT-2357
> Project: Thrift
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Mark Manashirov
> Fix For: 0.9.2
>
>
> When compiling a thrift file that includes other thrift files the included
> files does not get generated for php.
> For example:
> foo.thrift:
>
> include "bar.thrift"
> service FooService {
> bar.Foo SeeDosRun(1: bar.Baz baz);
> }
> bar.thrift
>
> struct Foo {
> 1: string foo;
> }
> struct Baz {
> 1: string baz;
> }
> thrift -v --gen php -r foo.thrift
> Scanning /home/mmanashirov/CMS/develop/tmp/foo.thrift for includes
> Scanning /home/mmanashirov/CMS/develop/tmp/bar.thrift for includes
> Parsing /home/mmanashirov/CMS/develop/tmp/bar.thrift for types
> Parsing /home/mmanashirov/CMS/develop/tmp/foo.thrift for types
> Program: /home/mmanashirov/CMS/develop/tmp/bar.thrift
> Generating "php"
> Program: /home/mmanashirov/CMS/develop/tmp/foo.thrift
> Generating "php"
> It says generating php after bar.thrift but no files actually get generated
> for that file. On the other hand generating files for cpp, py, js for example
> all work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2357) recurse option has no effect when generating php
[
https://issues.apache.org/jira/browse/THRIFT-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710734#comment-15710734
]
Shane commented on THRIFT-2357:
---
I have declared namespace. But all my thrift files share the same namespace. I
think it should be acceptable for multiple files to share one namespace. Is
that right?
> recurse option has no effect when generating php
>
>
> Key: THRIFT-2357
> URL: https://issues.apache.org/jira/browse/THRIFT-2357
> Project: Thrift
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Mark Manashirov
> Fix For: 0.9.2
>
>
> When compiling a thrift file that includes other thrift files the included
> files does not get generated for php.
> For example:
> foo.thrift:
>
> include "bar.thrift"
> service FooService {
> bar.Foo SeeDosRun(1: bar.Baz baz);
> }
> bar.thrift
>
> struct Foo {
> 1: string foo;
> }
> struct Baz {
> 1: string baz;
> }
> thrift -v --gen php -r foo.thrift
> Scanning /home/mmanashirov/CMS/develop/tmp/foo.thrift for includes
> Scanning /home/mmanashirov/CMS/develop/tmp/bar.thrift for includes
> Parsing /home/mmanashirov/CMS/develop/tmp/bar.thrift for types
> Parsing /home/mmanashirov/CMS/develop/tmp/foo.thrift for types
> Program: /home/mmanashirov/CMS/develop/tmp/bar.thrift
> Generating "php"
> Program: /home/mmanashirov/CMS/develop/tmp/foo.thrift
> Generating "php"
> It says generating php after bar.thrift but no files actually get generated
> for that file. On the other hand generating files for cpp, py, js for example
> all work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2357) recurse option has no effect when generating php
[
https://issues.apache.org/jira/browse/THRIFT-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710715#comment-15710715
]
Shane commented on THRIFT-2357:
---
I ran into the same problem, in both version 0.9,.3 and master. Verbose log
shows files are processed recursively. But only the result of the last thrift
file is left.
If this is really fixed, how to get the expected result?
> recurse option has no effect when generating php
>
>
> Key: THRIFT-2357
> URL: https://issues.apache.org/jira/browse/THRIFT-2357
> Project: Thrift
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Mark Manashirov
> Fix For: 0.9.2
>
>
> When compiling a thrift file that includes other thrift files the included
> files does not get generated for php.
> For example:
> foo.thrift:
>
> include "bar.thrift"
> service FooService {
> bar.Foo SeeDosRun(1: bar.Baz baz);
> }
> bar.thrift
>
> struct Foo {
> 1: string foo;
> }
> struct Baz {
> 1: string baz;
> }
> thrift -v --gen php -r foo.thrift
> Scanning /home/mmanashirov/CMS/develop/tmp/foo.thrift for includes
> Scanning /home/mmanashirov/CMS/develop/tmp/bar.thrift for includes
> Parsing /home/mmanashirov/CMS/develop/tmp/bar.thrift for types
> Parsing /home/mmanashirov/CMS/develop/tmp/foo.thrift for types
> Program: /home/mmanashirov/CMS/develop/tmp/bar.thrift
> Generating "php"
> Program: /home/mmanashirov/CMS/develop/tmp/foo.thrift
> Generating "php"
> It says generating php after bar.thrift but no files actually get generated
> for that file. On the other hand generating files for cpp, py, js for example
> all work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2357) recurse option has no effect when generating php
[
https://issues.apache.org/jira/browse/THRIFT-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898286#comment-13898286
]
Jens Geyer commented on THRIFT-2357:
The problem is, that the IDL files should have a {{namespace}} declaration.
Without that, all files are generated into the same output folder, which is
emptied before processing each IDL file. Thus, the second IDL file deletes the
generated code from the first file.
{code:title=bar.thrift}
namespace * bar
struct Foo
{ 1: string foo; }
struct Baz
{ 1: string baz; }
{code}
{code:title=foo.thrift}
namespace * foo
include "bar.thrift"
service FooService
{ bar.Foo SeeDosRun(1: bar.Baz baz); }
{code}
> recurse option has no effect when generating php
>
>
> Key: THRIFT-2357
> URL: https://issues.apache.org/jira/browse/THRIFT-2357
> Project: Thrift
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Mark Manashirov
>
> When compiling a thrift file that includes other thrift files the included
> files does not get generated for php.
> For example:
> foo.thrift:
>
> include "bar.thrift"
> service FooService {
> bar.Foo SeeDosRun(1: bar.Baz baz);
> }
> bar.thrift
>
> struct Foo {
> 1: string foo;
> }
> struct Baz {
> 1: string baz;
> }
> thrift -v --gen php -r foo.thrift
> Scanning /home/mmanashirov/CMS/develop/tmp/foo.thrift for includes
> Scanning /home/mmanashirov/CMS/develop/tmp/bar.thrift for includes
> Parsing /home/mmanashirov/CMS/develop/tmp/bar.thrift for types
> Parsing /home/mmanashirov/CMS/develop/tmp/foo.thrift for types
> Program: /home/mmanashirov/CMS/develop/tmp/bar.thrift
> Generating "php"
> Program: /home/mmanashirov/CMS/develop/tmp/foo.thrift
> Generating "php"
> It says generating php after bar.thrift but no files actually get generated
> for that file. On the other hand generating files for cpp, py, js for example
> all work.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
