[jira] [Commented] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045468#comment-14045468 ] ASF GitHub Bot commented on THRIFT-2574: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/140 Compiler option to generate namespace directories for Ruby -- Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Labels: compiler, namespaces, patch, ruby Fix For: 0.9.2 Attachments: thrift-2574-formatted-patch.patch, thrift-2574.diff As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045492#comment-14045492 ] Hudson commented on THRIFT-2574: SUCCESS: Integrated in Thrift #1195 (See [https://builds.apache.org/job/Thrift/1195/]) Thrift-THRIFT-2574: Compiler option to generate namespace directories for Ruby (jfarrell: rev bf2617ed15f95e22bcf41fd9d08e7ce562464f46) * lib/rb/spec/namespaced_spec.rb * lib/rb/spec/Referenced.thrift * compiler/cpp/src/generate/t_rb_generator.cc * lib/rb/spec/ThriftNamespacedSpec.thrift * lib/rb/Rakefile Compiler option to generate namespace directories for Ruby -- Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Assignee: Andrew Bloomgarden Labels: compiler, namespaces, patch, ruby Fix For: 0.9.2 Attachments: thrift-2574-formatted-patch.patch, thrift-2574.diff As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2574) Compiler option to generate namespace directories for Ruby
[ https://issues.apache.org/jira/browse/THRIFT-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030249#comment-14030249 ] ASF GitHub Bot commented on THRIFT-2574: GitHub user aughr opened a pull request: https://github.com/apache/thrift/pull/140 rb:namespaced: generate Ruby files in idiomatic namespaced directories. Idiomatic Ruby expects that namespaces are mirrored on the filesystem. This new namespaced option lets that happen. (https://issues.apache.org/jira/browse/THRIFT-2574, patch there also) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aughr/thrift namespaced_ruby_files Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit c8db5edb0426ae4328c8cc9a1354ac8858a03c16 Author: Andrew Bloomgarden stalkingti...@gmail.com Date: 2014-06-13T03:55:34Z rb:namespaced: generate Ruby files in idiomatic namespaced directories. Idiomatic Ruby expects that namespaces are mirrored on the filesystem. This new namespaced option lets that happen. Compiler option to generate namespace directories for Ruby -- Key: THRIFT-2574 URL: https://issues.apache.org/jira/browse/THRIFT-2574 Project: Thrift Issue Type: Improvement Components: Ruby - Compiler Affects Versions: 0.9.1 Reporter: Andrew Bloomgarden Labels: compiler, namespaces, patch, ruby Fix For: 0.9.2 Attachments: thrift-2574-formatted-patch.patch, thrift-2574.diff As described in THRIFT-1544, it would be nice if Thrift generated properly-namespaced files for Ruby. That patch would break backwards compatibility, so I don't know if you want it. This one makes namespacing correctly an option (namespaced). -- This message was sent by Atlassian JIRA (v6.2#6252)
