[jira] [Commented] (THRIFT-2577) TFileTransport missuse of closesocket on windows platform
[ https://issues.apache.org/jira/browse/THRIFT-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042152#comment-14042152 ] ASF GitHub Bot commented on THRIFT-2577: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/142 TFileTransport missuse of closesocket on windows platform -- Key: THRIFT-2577 URL: https://issues.apache.org/jira/browse/THRIFT-2577 Project: Thrift Issue Type: Bug Components: C++ - Library Reporter: suuyaoo Fix For: 1.2 On windows platform , TFileTransport opens a file using the _open function, but close it using THRIFT_CLOSESOCKET(closesocket), and this may cause a TTransportException being throwed, which is not expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2577) TFileTransport missuse of closesocket on windows platform
[ https://issues.apache.org/jira/browse/THRIFT-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042206#comment-14042206 ] Hudson commented on THRIFT-2577: SUCCESS: Integrated in Thrift #1191 (See [https://builds.apache.org/job/Thrift/1191/]) THRIFT-2577 C++ TFileTransport missuse of closesocket on windows platform (henrique: rev 58993d120578ce36fb88f7af06c06d2eba213b65) * lib/cpp/src/thrift/transport/TFileTransport.cpp * lib/cpp/src/thrift/transport/PlatformSocket.h * lib/cpp/test/TFDTransportTest.cpp * lib/cpp/src/thrift/transport/TSimpleFileTransport.cpp * lib/cpp/src/thrift/transport/TFDTransport.cpp TFileTransport missuse of closesocket on windows platform -- Key: THRIFT-2577 URL: https://issues.apache.org/jira/browse/THRIFT-2577 Project: Thrift Issue Type: Bug Components: C++ - Library Reporter: suuyaoo Assignee: Henrique Mendonça Fix For: 1.2 On windows platform , TFileTransport opens a file using the _open function, but close it using THRIFT_CLOSESOCKET(closesocket), and this may cause a TTransportException being throwed, which is not expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2577) TFileTransport missuse of closesocket on windows platform
[ https://issues.apache.org/jira/browse/THRIFT-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031984#comment-14031984 ] ASF GitHub Bot commented on THRIFT-2577: GitHub user suuyaoo opened a pull request: https://github.com/apache/thrift/pull/142 TFileTransport missuse of closesocket on windows platform https://issues.apache.org/jira/browse/THRIFT-2577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/suuyaoo/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 809ee5e0c1148a914537d3857c011fb0d73ade1f Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T06:59:25Z Update PlatformSocket.h commit a2ebfdd35a2f3b80669b21b86d1a4b653723529c Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T07:29:40Z Update TFileTransport.cpp commit e45364d4f3713ecfc365bbd21675b7dc7ef09052 Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T14:37:29Z fix windows filetransport TFileTransport missuse of closesocket on windows platform -- Key: THRIFT-2577 URL: https://issues.apache.org/jira/browse/THRIFT-2577 Project: Thrift Issue Type: Bug Components: C++ - Library Reporter: suuyaoo Fix For: 1.2 On windows platform , TFileTransport opens a file using the _open function, but close it using THRIFT_CLOSESOCKET(closesocket), and this may cause a TTransportException being throwed, which is not expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
