[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573165#comment-15573165 ] ASF GitHub Bot commented on THRIFT-3943: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1109 > Coverity Scan identified some high severity defects > --- > > Key: THRIFT-3943 > URL: https://issues.apache.org/jira/browse/THRIFT-3943 > Project: Thrift > Issue Type: Bug > Components: C++ - Library, Lua - Library >Affects Versions: 0.9.3 > Environment: https://scan.coverity.com/projects/thrift >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > Fix For: 0.10.0 > > > Coverity Scan identified 9 issues of high severity. > I dismissed 4 of them as false positives; coverity lost track of the handling > of socket file descriptors across multiple layers of calls; this left 5 > issues, and I took care of a number of insignificant issues as well: > 1295822 - memory leak in ThreadFactoryTests > 1216842 - uninitialized rfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216841 - uninitialized wfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216840 - getsockname is always passed uninitialized addrlen > 1295810 - uninitialized variables in test > 1295808 - uninitialized variable in test > 1295804 - structurally dead code in processor test event log - changed to use > environment variable > excuded: > 1174563 - memory leak in compiler class handling functions > 1174671 - uninitialized variable in FunctionRunner (intervalMs_) > 1174669, 1174763, 1295806, 1295807, 1295809 - uninitialized variable in > TSocket (peerPort_) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551616#comment-15551616 ] ASF GitHub Bot commented on THRIFT-3943: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1109 I backed out the delete _xcception change in the compiler (1174563 - memory leak in compiler class handling functions), we'll see if that was the culprit. > Coverity Scan identified some high severity defects > --- > > Key: THRIFT-3943 > URL: https://issues.apache.org/jira/browse/THRIFT-3943 > Project: Thrift > Issue Type: Bug > Components: C++ - Library, Lua - Library >Affects Versions: 0.9.3 > Environment: https://scan.coverity.com/projects/thrift >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > Coverity Scan identified 9 issues of high severity. > I dismissed 4 of them as false positives; coverity lost track of the handling > of socket file descriptors across multiple layers of calls; this left 5 > issues: > 1295822 - memory leak in ThreadFactoryTests > 1216842 - uninitialized rfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216841 - uninitialized wfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216840 - getsockname is always passed uninitialized addrlen > 1174563 - memory leak in compiler class handling functions -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550381#comment-15550381 ] ASF GitHub Bot commented on THRIFT-3943: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1109 Well, putting in that delete of xceptions_ certainly didn't fare well. > Coverity Scan identified some high severity defects > --- > > Key: THRIFT-3943 > URL: https://issues.apache.org/jira/browse/THRIFT-3943 > Project: Thrift > Issue Type: Bug > Components: C++ - Library, Lua - Library >Affects Versions: 0.9.3 > Environment: https://scan.coverity.com/projects/thrift >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > Coverity Scan identified 9 issues of high severity. > I dismissed 4 of them as false positives; coverity lost track of the handling > of socket file descriptors across multiple layers of calls; this left 5 > issues: > 1295822 - memory leak in ThreadFactoryTests > 1216842 - uninitialized rfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216841 - uninitialized wfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216840 - getsockname is always passed uninitialized addrlen > 1174563 - memory leak in compiler class handling functions -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3943) Coverity Scan identified some high severity defects
[ https://issues.apache.org/jira/browse/THRIFT-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549630#comment-15549630 ] ASF GitHub Bot commented on THRIFT-3943: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1109 THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan https://scan7.coverity.com/reports.htm#v15415/p10216/fileInstanceId=3547531&defectInstanceId=1023429&mergedDefectId=748818 Coverity Scan identified 9 issues of high severity. I dismissed 4 of them as false positives; coverity lost track of the handling of socket file descriptors across multiple layers of calls; this left 5 issues: 1295822 - memory leak in ThreadFactoryTests 1216842 - uninitialized rfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W) 1216841 - uninitialized wfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W) 1216840 - getsockname is always passed uninitialized addrlen 1174563 - memory leak in compiler class handling functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift defect/THRIFT-3943 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1109 commit fc06e472cdd901e9273936e323efc85e694e7b32 Author: James E. King, III Date: 2016-10-05T18:47:18Z THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan > Coverity Scan identified some high severity defects > --- > > Key: THRIFT-3943 > URL: https://issues.apache.org/jira/browse/THRIFT-3943 > Project: Thrift > Issue Type: Bug > Components: C++ - Library, Lua - Library >Affects Versions: 0.9.3 > Environment: https://scan.coverity.com/projects/thrift >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > Coverity Scan identified 9 issues of high severity. > I dismissed 4 of them as false positives; coverity lost track of the handling > of socket file descriptors across multiple layers of calls; this left 5 > issues: > 1295822 - memory leak in ThreadFactoryTests > 1216842 - uninitialized rfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216841 - uninitialized wfds fd_set is passed to select if mode is not > WAIT_MODE_C (R+W) > 1216840 - getsockname is always passed uninitialized addrlen > 1174563 - memory leak in compiler class handling functions -- This message was sent by Atlassian JIRA (v6.3.4#6332)
