[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904932#comment-15904932 ] ASF GitHub Bot commented on THRIFT-4029: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1206 > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: James E. King, III > Fix For: 0.11.0 > > Attachments: test-thrift.bash > > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904925#comment-15904925 ] James E. King, III commented on THRIFT-4029: Thanks, I am going to commit this. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > Attachments: test-thrift.bash > > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901840#comment-15901840 ] Chandler May commented on THRIFT-4029: -- Dunno if I consider myself a SME but I believe the build works. I am attaching a bash script that fails before the patch and works after it, demonstrating the patch's resolution of the packaging issue. It would be fantastic if this could be added as an integration test (in a greatly cleaned-up form), but I haven't looked at the Python test framework in a while so I'm not sure what the best way is to do that. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898401#comment-15898401 ] James E. King, III commented on THRIFT-4029: This build passed CI however I'm not a python packaging SME. Could someone tell me if the pull request resolves the issue and should be merged? > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895464#comment-15895464 ] ASF GitHub Bot commented on THRIFT-4029: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1206 If the build fails try using this technique to kick another if you think it was environmental: git commit --amend don't change anything, just save. This makes a new identical commit with a new hash. git push -u origin --force overwrites the previous push and kicks another build Thanks. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823166#comment-15823166 ] Chandler May commented on THRIFT-4029: -- The new zip distribution works for me. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822950#comment-15822950 ] John Sirois commented on THRIFT-4029: - This really is the behavior you want - mutable artifacts cause no end of debugging grief. It's really a good prompt to release 0.10.1 - difficulty or ease of this aside. Having one good and 1 bad version of the same artifact seems like it's also asking for debugging trouble and confusion for users. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822948#comment-15822948 ] Jake Farrell commented on THRIFT-4029: -- Uploaded a new package which has the headers in it. It is a zip instead of a tar.gz due to the awful behavior of pypi not allowing multiple uploads of the same named packages {code} Submitting dist/thrift-0.10.0.tar.gz to https://pypi.python.org/pypi Upload failed (400): This filename has previously been used, you should use a different version. error: Upload failed (400): This filename has previously been used, you should use a different version. {code} > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822573#comment-15822573 ] Anatol Pomozov commented on THRIFT-4029: I see the same issue at Arch Linux ``` ==> Starting build()... running build running build_py running build_ext building 'thrift.protocol.fastbinary' extension gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -D_FORTIFY_SOURCE=2 -fPIC -Isrc -I/usr/include/python3.6m -c src/ext/module.cpp -o build/temp.linux-x86_64-3.6/src/ext/module.o cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory #include "types.h" ^ compilation terminated. An error occurred while trying to compile with the C extension enabled Attempting to build without the extension now ``` What I see is that it only includes directory `src` but the header file is located under `src/ext`. > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May >Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821932#comment-15821932 ] Jake Farrell commented on THRIFT-4029: -- Not sure why `python setup.py sdist` is not including the headers as the include_dirs is listed for the extension, nothing new occurring here as far as the steps used to package and push that artifact. Does using a MANIFEST.in with the following fix the issue for you? If so we could look at getting that fixed {code} graft src graft compat graft tests global-exclude __pycache__ global-exclude *.py[co] {code} > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: Chandler May > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" >^ > compilation terminated. > () > > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.4#6332)