[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215643#comment-16215643
 ] 

ASF GitHub Bot commented on THRIFT-4306:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1395


> Thrift imports not replicated to D service output
> -
>
> Key: THRIFT-4306
> URL: https://issues.apache.org/jira/browse/THRIFT-4306
> Project: Thrift
>  Issue Type: Improvement
>  Components: D - Compiler
>Reporter: Neia Neutuladh
>Assignee: Neia Neutuladh
> Fix For: 0.11.0
>
> Attachments: THRIFT-4306 dlang public imports for dependencies.diff
>
>
> Looks like the code relies on a compiler bug that was eliminated a couple 
> years ago. Easy enough to fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215573#comment-16215573
 ] 

ASF GitHub Bot commented on THRIFT-4306:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1395
  
@jfarrell please close this, it was merged in commit 
44701e82ad351d7472101ad81aa13e775ffb7384


> Thrift imports not replicated to D service output
> -
>
> Key: THRIFT-4306
> URL: https://issues.apache.org/jira/browse/THRIFT-4306
> Project: Thrift
>  Issue Type: Improvement
>  Components: D - Compiler
>Reporter: Neia Neutuladh
>Assignee: Neia Neutuladh
> Fix For: 0.11.0
>
> Attachments: THRIFT-4306 dlang public imports for dependencies.diff
>
>
> Looks like the code relies on a compiler bug that was eliminated a couple 
> years ago. Easy enough to fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213974#comment-16213974
 ] 

ASF GitHub Bot commented on THRIFT-4306:


GitHub user dhasenan opened a pull request:

https://github.com/apache/thrift/pull/1395

THRIFT-4306 dlang: public imports for dependencies

If you have an IDL file that imports another IDL file, you can define
a service that accepts, yields, or throws types defined in the
imported file. In this case, the dlang output should ensure that the
types defined in the imported IDL module are visible in the service
interface's module.

The generator failed to do that, resulting in a failure to compile
the generated source in these situations. This was previously
accepted by the compiler due to some long-standing bugs with symbol
visibility, but the compiler bugs have been resolved.

Fixes #4306.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dhasenan/thrift THRIFT-4306

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1395


commit 1eec5b0e4c379d927db014a3b89f01ea0b00713e
Author: dhasenan 
Date:   2017-10-21T15:29:44Z

THRIFT-4306 dlang: public imports for dependencies

If you have an IDL file that imports another IDL file, you can define
a service that accepts, yields, or throws types defined in the
imported file. In this case, the dlang output should ensure that the
types defined in the imported IDL module are visible in the service
interface's module.

The generator failed to do that, resulting in a failure to compile
the generated source in these situations. This was previously
accepted by the compiler due to some long-standing bugs with symbol
visibility, but the compiler bugs have been resolved.

Fixes #4306.




> Thrift imports not replicated to D service output
> -
>
> Key: THRIFT-4306
> URL: https://issues.apache.org/jira/browse/THRIFT-4306
> Project: Thrift
>  Issue Type: Improvement
>  Components: D - Compiler
>Reporter: Neia Neutuladh
>Assignee: Neia Neutuladh
> Fix For: 0.11.0
>
> Attachments: THRIFT-4306 dlang public imports for dependencies.diff
>
>
> Looks like the code relies on a compiler bug that was eliminated a couple 
> years ago. Easy enough to fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211744#comment-16211744
 ] 

Jens Geyer commented on THRIFT-4306:


[~dhasenan], ah, that's the one. You do know the difference between a question 
("can you provide ...") and a strict refuse ("we only accept ...")?

> Thrift imports not replicated to D service output
> -
>
> Key: THRIFT-4306
> URL: https://issues.apache.org/jira/browse/THRIFT-4306
> Project: Thrift
>  Issue Type: Improvement
>  Components: D - Compiler
>Reporter: Neia Neutuladh
> Attachments: THRIFT-4306 dlang public imports for dependencies.diff
>
>
> Looks like the code relies on a compiler bug that was eliminated a couple 
> years ago. Easy enough to fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211017#comment-16211017
 ] 

James E. King, III commented on THRIFT-4306:


Can you submit this as a pull request?

> Thrift imports not replicated to D service output
> -
>
> Key: THRIFT-4306
> URL: https://issues.apache.org/jira/browse/THRIFT-4306
> Project: Thrift
>  Issue Type: Improvement
>  Components: D - Compiler
>Reporter: Neia Neutuladh
> Attachments: THRIFT-4306 dlang public imports for dependencies.diff
>
>
> Looks like the code relies on a compiler bug that was eliminated a couple 
> years ago. Easy enough to fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)