[jira] [Commented] (THRIFT-4498) add phpcs back

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384764#comment-16384764
 ] 

ASF GitHub Bot commented on THRIFT-4498:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1498


> add phpcs back
> --
>
> Key: THRIFT-4498
> URL: https://issues.apache.org/jira/browse/THRIFT-4498
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.12.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
> Fix For: 0.12.0
>
>
> Can we use phpcs to check code for PSR-2?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4498) add phpcs back

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372622#comment-16372622
 ] 

ASF GitHub Bot commented on THRIFT-4498:


GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1498

THRIFT-4498: add phpcs back

ref 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift phpcs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1498


commit 5e60bbbcaba9d4c1ef47fcb99ea8b1ef0bde8fc4
Author: Robert Lu 
Date:   2018-02-22T03:06:07Z

add phpcs back




> add phpcs back
> --
>
> Key: THRIFT-4498
> URL: https://issues.apache.org/jira/browse/THRIFT-4498
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
>
> Can we use phpcs to check code for PSR-2?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)