[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683766#comment-16683766 ] ASF GitHub Bot commented on THRIFT-4529: jeking3 closed pull request #1625: THRIFT-4529: Rust

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683662#comment-16683662 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge commented on issue #1625: THRIFT-4529: Rust

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682943#comment-16682943 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge edited a comment on issue #1625:

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682939#comment-16682939 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge commented on issue #1625: THRIFT-4529: Rust

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682930#comment-16682930 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge commented on issue #1625: THRIFT-4529:

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682921#comment-16682921 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge commented on issue #1625: THRIFT-4529:

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682917#comment-16682917 ] ASF GitHub Bot commented on THRIFT-4529: jeking3 commented on issue #1625: THRIFT-4529:

Re: [jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread James E. King III
Does this mean this is a breaking change? If you have to modify the cross tests... On Sun, Nov 11, 2018 at 10:35 AM ASF GitHub Bot (JIRA) wrote: > > [ >

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682909#comment-16682909 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge commented on issue #1625: THRIFT-4529:

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682504#comment-16682504 ] ASF GitHub Bot commented on THRIFT-4529: allengeorge opened a new pull request #1625:

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-10 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682477#comment-16682477 ] Allen George commented on THRIFT-4529: -- Humorously (I guess this is the story of all programming)

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-07 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678115#comment-16678115 ] Allen George commented on THRIFT-4529: -- Looks like it. For some reason I totally missed the variant

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-07 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678114#comment-16678114 ] Allen George commented on THRIFT-4529: -- Looks like it. For some reason I totally missed the variant

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

2018-11-07 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678088#comment-16678088 ] Allen George commented on THRIFT-4529: -- I'm sorry I missed this :/ Does this happen only for enum