[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479444#comment-16479444 ] James E. King III commented on THRIFT-4573: --- Let's leave it resolved until the 0.12.0 release where the release manager will close it. > Unions Field Count Does Not Consider Binary > --- > > Key: THRIFT-4573 > URL: https://issues.apache.org/jira/browse/THRIFT-4573 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.10.0, 0.11.0 > Environment: Ubuntu 15.10 >Reporter: Zeyu Wang >Assignee: Can Celasun >Priority: Major > Labels: golang, thrift, union > Fix For: 0.12.0 > > Attachments: sample_test.png, wrong_result.png > > > Follow up from this ticket: https://issues.apache.org/jira/browse/THRIFT-3703 > Go code for unions generated by Thrift 0.10.0 fails to consider binary field > of a union when enforcing that the number of fields set is 1 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479340#comment-16479340 ] Zeyu Wang commented on THRIFT-4573: --- [~calcifer]Thanks for the quick fix!! The way I solved it is this [https://github.com/pinterest/thrift/pull/16]! I will close the issue! > Unions Field Count Does Not Consider Binary > --- > > Key: THRIFT-4573 > URL: https://issues.apache.org/jira/browse/THRIFT-4573 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.10.0, 0.11.0 > Environment: Ubuntu 15.10 >Reporter: Zeyu Wang >Assignee: Can Celasun >Priority: Major > Labels: golang, thrift, union > Fix For: 0.12.0 > > Attachments: sample_test.png, wrong_result.png > > > Follow up from this ticket: https://issues.apache.org/jira/browse/THRIFT-3703 > Go code for unions generated by Thrift 0.10.0 fails to consider binary field > of a union when enforcing that the number of fields set is 1 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479223#comment-16479223 ] Can Celasun commented on THRIFT-4573: - I will, just waiting for the reporter to confirm. > Unions Field Count Does Not Consider Binary > --- > > Key: THRIFT-4573 > URL: https://issues.apache.org/jira/browse/THRIFT-4573 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.10.0, 0.11.0 > Environment: Ubuntu 15.10 >Reporter: Zeyu Wang >Assignee: Can Celasun >Priority: Major > Labels: golang, thrift, union > Fix For: 0.12.0 > > Attachments: sample_test.png, wrong_result.png > > > Follow up from this ticket: https://issues.apache.org/jira/browse/THRIFT-3703 > Go code for unions generated by Thrift 0.10.0 fails to consider binary field > of a union when enforcing that the number of fields set is 1 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479181#comment-16479181 ] James E. King III commented on THRIFT-4573: --- Perhaps mark it Fixed and if it isn't, reopen it. > Unions Field Count Does Not Consider Binary > --- > > Key: THRIFT-4573 > URL: https://issues.apache.org/jira/browse/THRIFT-4573 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.10.0, 0.11.0 > Environment: Ubuntu 15.10 >Reporter: Zeyu Wang >Assignee: Can Celasun >Priority: Major > Labels: golang, thrift, union > Fix For: 0.12.0 > > Attachments: sample_test.png, wrong_result.png > > > Follow up from this ticket: https://issues.apache.org/jira/browse/THRIFT-3703 > Go code for unions generated by Thrift 0.10.0 fails to consider binary field > of a union when enforcing that the number of fields set is 1 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4573) Unions Field Count Does Not Consider Binary
[ https://issues.apache.org/jira/browse/THRIFT-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478837#comment-16478837 ] Can Celasun commented on THRIFT-4573: - [~simplee] Thanks for the report, I've just pushed a fixed for this. Can you try again with the latest master? > Unions Field Count Does Not Consider Binary > --- > > Key: THRIFT-4573 > URL: https://issues.apache.org/jira/browse/THRIFT-4573 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.10.0, 0.11.0 > Environment: Ubuntu 15.10 >Reporter: Zeyu Wang >Assignee: Can Celasun >Priority: Major > Labels: golang, thrift, union > Fix For: 0.12.0 > > Attachments: sample_test.png, wrong_result.png > > > Follow up from this ticket: https://issues.apache.org/jira/browse/THRIFT-3703 > Go code for unions generated by Thrift 0.10.0 fails to consider binary field > of a union when enforcing that the number of fields set is 1 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
