[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545613#comment-16545613
]
ASF GitHub Bot commented on TINKERPOP-967:
--
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/890
@jorgebay any reason this wasnt noted in GLV tests? are we missing a
scenario?
---
Updated dev docs (but didn't publish yet) -
https://github.com/apache/tinkerpop/commit/e1d57d6e076efbc68bbdf0fe0c121054a9d5152f
On Fri, Jul 13, 2018 at 10:52 AM Ted Wilmes wrote:
> That looks good, thanks Stephen.
>
> --Ted
>
> On Thu, Jul 12, 2018 at 5:23 PM Stephen Mallette
> wrote:
>
> >
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
I will take care of merging this now that we have reviews done. Thanks for
patiently working through this process @GCHQResearcher1337 - is that how you
will forever be known to us by the way?
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/890
Looks good, thanks @arings !
VOTE: +1
I've filed a ticket to keep track of this bug fix: TINKERPOP-2009.
Committers: note that we should merge it to `tp32`.
---
Jorge Bay created TINKERPOP-2009:
Summary: Pick.any and Pick.none should be exposed in
Gremlin-JavaScript
Key: TINKERPOP-2009
URL: https://issues.apache.org/jira/browse/TINKERPOP-2009
Project:
[
https://issues.apache.org/jira/browse/TINKERPOP-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay updated TINKERPOP-2009:
-
Issue Type: Bug (was: Improvement)
> Pick.any and Pick.none should be exposed in
[
https://issues.apache.org/jira/browse/TINKERPOP-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544968#comment-16544968
]
ASF GitHub Bot commented on TINKERPOP-2009:
---
Github user jorgebay commented on the issue:
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/892#discussion_r202651403
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -242,7 +257,31 @@ private void
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
> Do you think there is a performance real performance penalty when we do
sorting for serialization?
The graphs you have been working with are small (judging from your
questions on
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Long sounds fine. Good catch!
The sort algorithm I suggested is indeed a heuristic, still a better
heuristic as the default String sort by Java ;-)
Ordering
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/892#discussion_r202653620
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -218,20 +220,33 @@ private void
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/892
I use to work on the console, stability and clarity comes there before the
performance when drafting on a solution (my product version would run from
the console anyway).
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/892
Thanks for contributing to Apache TinkerPop. I've done some initial review
of your pull request here - I wouldn't say that I'm done with comments, but I
think I posted enough there to get
14 matches
Mail list logo
