[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562003#comment-16562003 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206182822 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -2489,6 +2489,62 @@

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562032#comment-16562032 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user dkuppitz commented on a diff in

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206207720 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -2489,6 +2489,62 @@

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562034#comment-16562034 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop issue #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/897 @dkuppitz i just pushed a fix for halted traverser stuff - does that look right to you now? or am i still missing something? ---

[jira] [Commented] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562054#comment-16562054 ] ASF GitHub Bot commented on TINKERPOP-2006: --- Github user spmallette commented on the issue:

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561989#comment-16561989 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206188786 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/search/path/ShortestPathVertexProgram.java --- @@ -0,0 +1,581 @@

[GitHub] tinkerpop issue #891: TINKERPOP-2006 - Fix for valid GraphML export when gra...

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/891 @svanteschubert do you plan to come back to this one and #892 ? I think that if you address @twilmes issues here we could push forward at least this change and get it merged. Also, if you are

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562013#comment-16562013 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206194431 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java --- @@ -60,6 +60,10 @@ test =

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562021#comment-16562021 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206210239 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -2489,6 +2489,62 @@

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561846#comment-16561846 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/882#discussion_r206111874 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/ShortestPathVertexProgramStep.java --- @@ -0,0

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561857#comment-16561857 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/897#discussion_r206114783 --- Diff: docs/src/recipes/connected-components.asciidoc --- @@ -35,46 +54,92 @@ g.addV().property(id, "A").as("a").

[GitHub] tinkerpop pull request #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/897#discussion_r206112146 --- Diff: docs/src/recipes/connected-components.asciidoc --- @@ -35,46 +54,92 @@ g.addV().property(id, "A").as("a").

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561848#comment-16561848 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #:

2018-07-30 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/tinkerpop/commit/db46c0f67fb1f93b9ea76032dbd2a852c24effd4#commitcomment-29884736 In gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/io/type-serializers.js: In

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561861#comment-16561861 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/897 @FlorianHockmann regarding your point - yes, those tokens should be added to GLVs. I think we should wait for #893 to merge because it started the pattern for adding such tokens. I think that

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 good question @FlorianHockmann - seems like the recipe shouldn't be removed but perhaps updated to reflect this step?? ---

[jira] [Commented] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property

2018-07-30 Thread Svante Schubert (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562240#comment-16562240 ] Svante Schubert commented on TINKERPOP-2006: Sorry, for the delay. First deadline

[GitHub] tinkerpop pull request #893: TINKERPOP-1996 io()

2018-07-30 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/893#discussion_r206269042 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/IoStep.java --- @@ -0,0 +1,254 @@ +/* + *

[jira] [Commented] (TINKERPOP-1996) Introduce read() and write() steps

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562254#comment-16562254 ] ASF GitHub Bot commented on TINKERPOP-1996: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop issue #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/897 cool - pushed a test ---

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562261#comment-16562261 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user spmallette commented on the issue:

[jira] [Commented] (TINKERPOP-1298) Save OLAP results to file

2018-07-30 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562256#comment-16562256 ] Daniel Kuppitz commented on TINKERPOP-1298: --- Gotcha. Yes, I think that makes sense. > Save

[GitHub] tinkerpop pull request #899: TINKERPOP-2005: Intermittent NullPointerExcepti...

2018-07-30 Thread dimas-b
GitHub user dimas-b opened a pull request: https://github.com/apache/tinkerpop/pull/899 TINKERPOP-2005: Intermittent NullPointerException in response handling Address [TINKERPOP-2005](https://issues.apache.org/jira/browse/TINKERPOP-2005) by ignoring more than one "final" response

[jira] [Commented] (TINKERPOP-2005) Intermittent NullPointerException in response handling

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562438#comment-16562438 ] ASF GitHub Bot commented on TINKERPOP-2005: --- Github user dimas-b commented on the issue:

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562448#comment-16562448 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/882 Just wondered: Does the _Shortest Path_ recipe still make sense with the new `shortestPath()` step? And should the section in the reference docs about shortest paths and the recipe link

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562439#comment-16562439 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user FlorianHockmann commented on the

[jira] [Commented] (TINKERPOP-2005) Intermittent NullPointerException in response handling

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562437#comment-16562437 ] ASF GitHub Bot commented on TINKERPOP-2005: --- GitHub user dimas-b opened a pull request:

[GitHub] tinkerpop issue #897: TINKERPOP-1967 connectedComponent()

2018-07-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/897 Mucho mejor. ``` gremlin> g.withComputer().V().dedup().connectedComponent().valueMap() ==>[gremlin.connectedComponentVertexProgram.component:[1],name:[ripple],lang:[java]]

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 Hi, thanks for the contribution. I'm sure @jorgebay will look in on this when he's back from vacation. In the mean time, for my own information, could you comment on how this file is to be

[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562251#comment-16562251 ] ASF GitHub Bot commented on TINKERPOP-1967: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop pull request #:

2018-07-30 Thread dragma
Github user dragma commented on the pull request: https://github.com/apache/tinkerpop/commit/db46c0f67fb1f93b9ea76032dbd2a852c24effd4#commitcomment-29883926 In gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/io/type-serializers.js: In