Nice! VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/984 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674989#comment-16674989
]
stephen mallette commented on TINKERPOP-2085:
-
ugh - that was my life when i first
stephen mallette created TINKERPOP-2089:
---
Summary: Javascript DSL support
Key: TINKERPOP-2089
URL: https://issues.apache.org/jira/browse/TINKERPOP-2089
Project: TinkerPop
Issue Type:
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/966 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675161#comment-16675161
]
ASF GitHub Bot commented on TINKERPOP-2064:
---
jorgebay opened a new pull request #985:
[
https://issues.apache.org/jira/browse/TINKERPOP-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675141#comment-16675141
]
ASF GitHub Bot commented on TINKERPOP-2070:
---
jorgebay closed pull request #966:
All good suggestions @FlorianHockmann - I believe I've implemented all of them
and pushed now.
[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1516.
---
Resolution: Won't Do
I don't think I want to touch the test suite at this stage.
[
https://issues.apache.org/jira/browse/TINKERPOP-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2065.
---
Resolution: Done
Fix Version/s: 3.3.5
3.4.0
> Optimize
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/984 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1517.
---
Resolution: Won't Do
I don't think I want to touch the test suite at this stage.
[
https://issues.apache.org/jira/browse/TINKERPOP-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz updated TINKERPOP-2059:
--
Labels: breaking (was: )
> Modulation of valueMap()
>
>
[
https://issues.apache.org/jira/browse/TINKERPOP-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675382#comment-16675382
]
ASF GitHub Bot commented on TINKERPOP-2065:
---
spmallette closed pull request #984:
https://issues.apache.org/jira/browse/TINKERPOP-2059
Implemented `by()` and `with()` modulators for `valueMap()` step.
`docker/build.sh -t -i -n` passed and docs generated via `docker/build.sh -d`
look good.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
[
https://issues.apache.org/jira/browse/TINKERPOP-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1200.
---
Resolution: Not A Problem
Doesn't look like this is an issue anymore. The
[
https://issues.apache.org/jira/browse/TINKERPOP-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-1378:
Labels: (was: test)
This one has been around for a while. At this point, I
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/982 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/972 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
needs javadoc "@deprecated As of release 3.4.0, replaced by {@link ...}" also
needed below in the `__` class.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
needs javadoc `@deprecated As of release 3.4.0, replaced by {@link ...}` also
needed below in the `__` class.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Very nice!
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/981 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I don't think we should remove any old tests for the old signature. Those still
need to be tested since we've only deprecated the approach.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Mentioned this earlier, but let's keep the `valueMap(true)` tests since we have
to maintain that deprecated code. There are other places as well obviously
where the `valueMap(true)` tests need to be brought back. Just duplicate the
test basically - one for the old way and one for the new way.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/983 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Can't mix those here, the hashCodes collide.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I kept the boolean overload tests in `ValueMapTest`. I don't think
`AddVertexTest` should be used to test several `valueMap` overloads, but ...
I'll add them back.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for
ok - as long as we at least exercise the old stuff sufficiently then no need to
bring them all back. I just saw these removed and didn't realize that there
were others still hanging about. however you feel like handling it is fine in
that case.
[ Full content available at:
ok - as long as we at least exercise the old stuff sufficiently then no need to
bring them all back. I just saw these removed and didn't realize that there
were others still hanging about.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via
28 matches
Mail list logo
