Awesome, thanks!
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/991 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
If i'm thinking about this rightI guess Gryo used the default Kryo
serialization for 1.0 and 3.0 so by changing that we effectively break
both version of Gryo in 3.4.0. And that would mean that you couldn't
connect to older versions of the Java driver to 3.4.0 systems - you would
have to
[
https://issues.apache.org/jira/browse/TINKERPOP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685400#comment-16685400
]
ASF GitHub Bot commented on TINKERPOP-2010:
---
spmallette closed pull request #991:
[
https://issues.apache.org/jira/browse/TINKERPOP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2010.
---
Resolution: Done
Fix Version/s: 3.3.5
3.4.0
> Generate
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/991 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
That was my conclusion as well, I didn't see a way to make it non-breaking.
Maybe 3.4.0 should just have a special serializer for VertexProperties..?
On Tue, Nov 13, 2018 at 5:00 AM Stephen Mallette
wrote:
> If i'm thinking about this rightI guess Gryo used the default Kryo
> serialization
Gryo is so completely inflexible some times :|
How did we end up having to do this again? Reading back through the thread,
it seemed like it was because of Spark testing. What kinds of tests were
failing for Spark because of this? I assume it wasn't just property
assertions in the tests
https://issues.apache.org/jira/browse/TINKERPOP-2002
I bound this PR to TINKERPOP-2002 as it touches on some of the points made
there, but this set of changes is far more reaching than what was described
there. Basically restructured the entire Introduction section as well as the
Gremlin
