[DISCUSS] Depth First Repeat step

2018-04-16 Thread Keith Lohnes
As part of #838 there’s some discussion around whether or not to make DFS the default for the repeat step. On the one hand, everything else in OLTP is depth first. On the other hand, there’s likely existing traversals that depend on the breadth first n

Re: [DISCUSS] Depth First Repeat step

2018-04-17 Thread Keith Lohnes
t;> ^ This holds true as long as there's no significant difference in the > > >> cpu+memory consumption and overall performance of the two approaches. > > BFS > > >> has its advantages when it comes to bulking; an arbitrary number of > > >> traversers on the sam

Re: [DISCUSS] Depth First Repeat step

2018-04-17 Thread Keith Lohnes
epeatStep depth first. > > I assume you are referring to these booleans: > > > https://github.com/apache/tinkerpop/blob/fe8ee98f6967c7b0f0ee7f2cf2d10531b68fab8b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java#L46-L47 > >

Re: [DISCUSS] Depth First Repeat step

2018-04-19 Thread Keith Lohnes
gt;> link to that JIRA btw - I see I was involved in that conversation a > > >>> little > > >>> bit but then dropped off. You'd commented that you preferred a per > loop > > >>> configuration for search approach which is what you stuck with for > the > > >

Re: [DISCUSS] Depth First Repeat step

2018-04-24 Thread Keith Lohnes
mpact is so great that I'd rather, if possible have BFS as its default. > > I am not sure about this but I reckon that any graph where the TinkerPop > vm is not running in the same process space as the actual graph/data > that latency is a big issue. BFS alleviates the latency issue

Re: [DISCUSS] Depth First Repeat step

2018-04-24 Thread Keith Lohnes
arts. > > But yeah TinkerPop's implementation is always the starting point so I'll > definitely have a look at how you have implemented DFS. > > BTW, does Janus graph use TinkerPop's default RepeatStep as is with no > optimization strategies? > > Cheers > Pie

Re: [DISCUSS] Depth First Repeat step

2018-04-24 Thread Keith Lohnes
> Good for them, first prize is not replacing anything. > > Cheers > Pieter > > On 24/04/2018 19:50, Keith Lohnes wrote: > > It looks like it, > > `g.V().has("foo", "bar").repeat(out()).emit().explain()` > > > > yields > > > >

Re: [DISCUSS] Depth First Repeat step

2018-05-01 Thread Keith Lohnes
So if all that sounds good from a usability perspective, then we get > all > >>> three modes that we want using existing traversal semantics which > removes > >>> the three concerns I've summarized from this thread. We also get > Keith's > >>> d

Re: [DISCUSS] Depth First Repeat step

2018-05-20 Thread Keith Lohnes
m of verification > > strategy > > > >>> that ensures all BFS or all DFS so that users can't get tricked > along > > > the > > > >>> way. It's not enough to just remove LazyBarrierStrategy to get DFS > if > > > >>&g

Re: [DISCUSS] Apache TinkerPop 4 Vision

2018-10-30 Thread Keith Lohnes
Hey Stephen, I'd be interested in taking a look at the doc. -Keith On Tue, Oct 30, 2018 at 12:17 PM Divij Vaidya wrote: > I would like to review the document as well please. > > Regards > Divij > > On Tue, Oct 30, 2018 at 9:10 AM Stephen Mallette > wrote: > > > yes - reviews/comments are open

Re: [jira] [Commented] (TINKERPOP-1690) COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console

2017-06-09 Thread Keith Lohnes
STATIC and TYPE_CHECKED break sessions and aliases in console > > - > > > > Key: TINKERPOP-1690 > > URL: > https://issues.apache.org/jira/browse/TINKERPOP-1690 > > Project: TinkerPop > > Issue Type: Bug > >

Re: [DISCUSS] Gremlin Server Security

2017-09-20 Thread Keith Lohnes
aluates, `plus`, `minus` etc. steps. Maybe a `cast` step and a `concat` step. -Keith Lohnes On Wed, Sep 20, 2017 at 9:21 AM Robert Dale wrote: > Network security is out of scope. It's generally applicable. There's > nothing peculiar to Gremlin Server that would warrant its own se

[jira] [Created] (TINKERPOP-1858) HttpChannelizer regression

2017-12-28 Thread Keith Lohnes (JIRA)
Keith Lohnes created TINKERPOP-1858: --- Summary: HttpChannelizer regression Key: TINKERPOP-1858 URL: https://issues.apache.org/jira/browse/TINKERPOP-1858 Project: TinkerPop Issue Type: Bug

[jira] [Updated] (TINKERPOP-1858) HttpChannelizer regression

2017-12-28 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Lohnes updated TINKERPOP-1858: Description: HttpChannelizer creates a HttpBasicAuthenticationHandler instead of

[jira] [Updated] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

2017-12-29 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Lohnes updated TINKERPOP-1858: Summary: HttpChannelizer regression: Does not create specified AuthenticationHandler

[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search

2018-02-19 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369625#comment-16369625 ] Keith Lohnes commented on TINKERPOP-1822: - I've been looking at the

[jira] [Created] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes

2017-03-24 Thread Keith Lohnes (JIRA)
Keith Lohnes created TINKERPOP-1657: --- Summary: Provide abstraction to easily allow different HttpAuth schemes Key: TINKERPOP-1657 URL: https://issues.apache.org/jira/browse/TINKERPOP-1657 Project

[jira] [Created] (TINKERPOP-1690) COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console

2017-06-09 Thread Keith Lohnes (JIRA)
Keith Lohnes created TINKERPOP-1690: --- Summary: COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console Key: TINKERPOP-1690 URL: https://issues.apache.org/jira/browse/TINKERPOP-1690

[jira] [Commented] (TINKERPOP-1690) COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console

2017-06-12 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046670#comment-16046670 ] Keith Lohnes commented on TINKERPOP-1690: - Not sure yet. I just foun

[jira] [Commented] (TINKERPOP-1690) COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console

2017-06-12 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046867#comment-16046867 ] Keith Lohnes commented on TINKERPOP-1690: - https://issues.apache.org/

[jira] [Closed] (TINKERPOP-1690) COMPILE_STATIC and TYPE_CHECKED break sessions and aliases in console

2017-06-12 Thread Keith Lohnes (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Lohnes closed TINKERPOP-1690. --- Resolution: Invalid > COMPILE_STATIC and TYPE_CHECKED break sessions and aliases

[jira] [Created] (TINKERPOP-1384) Description of filter function in traversal documentation

2016-07-22 Thread Keith Lohnes (JIRA)
Keith Lohnes created TINKERPOP-1384: --- Summary: Description of filter function in traversal documentation Key: TINKERPOP-1384 URL: https://issues.apache.org/jira/browse/TINKERPOP-1384 Project