Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/337
Jline should have some support for obtaining terminal width though it might
not be all that reliable :
```java
jline.TerminalFactory.get().getWidth();
```
I think the above
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/337
duh I totally missed that line when looking through the changes. Late to
the party >.<
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/364
Thanks for this @aholmberg . I'm guessing this will be CTRed but I'll give
it my +1 just in case.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/351
ok I caught up and checked code. I think what @robertdale suggests on the
typing end would be really nice (`int64`, `int32`, etc). But we can keep that
for the thread stephen linked
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Ok I thought The main point here was robustness in typing for non-java
languages. Hence why I suggested even typing things like Int and using java
classes. Honestly depending on how you
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Hey guys,
I've been super busy lately but I definitely plan on diving deep into this
PR over the weekend. One quick remark though.
1. Even the JSON supported types
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/384
awesome!! VOTE: +1 from me as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/386
I'm liking how this has turned out.
I personally don't have much of an opinion in regards to assuming gremlin
is the default namespace and getting rid of `g:` though it does have the merit
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/386
Still reviewing I would like to finish going through the code :) will try
and do this later in the day. But looking good so far
---
If your project is set up for it, you can reply
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/386
I'm waiting to hear back from marko on the points he brought up to cast my
vote :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/386
Ok cool if we're all ok with the new features then I'm satisfied. Code
looked good as well VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/399
+1 from me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/412
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/413
VOTE +1 this is a nice fix to have. Unit tests passed for me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/433
VOTE +1 I get the pinging as well. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/450
Nice PR @jorgebay
Can you elaborate on why you went for `list()` and `one()` rather than
keeping the original method names of `toList()` and `next()`? I understand that
they would still
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/439
I'm currently on some ressource intensive tasks so it's hard for me to
bounce back and forth between projects but I would like to give this a run on
ubuntu 14.04. I suspect that sysV might
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/418
What's the test status on this GLV? Could it be possible to add tests for
this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/424
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/425
Docs were clear, change is straightforward and tested this manually:
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/383
I'm personally ok with the concept. It seems pretty mainstream and will
definitely help some folk. It's the kind of thing that you don't really pick up
from reading the documentation (at least
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/390
Hmmm. I haven't seen this crop up since it was fixed by upgrading Jackson
to `2.7.2`. Though originally my issue was related to the serializing and not
deserializing so there may be something
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/387
Straightforward enough and tests pass so VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Should we add upstart to this PR? I'm not sure if the systemd covers older
versions of ubuntu. Namely 14.04LTS ?
---
If your project is set up for it, you can reply to this email and have
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/439
Just confirming that although ubuntu 14.04 has `systemd` it does not have
`systemd-as-init` . So an upstart would be a good idea and should be relatively
easy since this PR seems
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/472
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/470
looks good and is a nice addition *I will definitely enjoy this* : VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
27 matches
Mail list logo
