[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...

2016-06-08 Thread SergeVil
Github user SergeVil commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66295517 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java --- @@ -721,14 +732,18 @@ public static void

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-08 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 I copied the xml file to a new name and added the test that processes a new xml. Recompiled everything, and I see this file in three places: (incubator-tinkerpop)$ find

[GitHub] incubator-tinkerpop pull request #333: if there is no edge label in the Grap...

2016-06-07 Thread SergeVil
GitHub user SergeVil opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/333 if there is no edge label in the GraphML file, then use Edge.DEFAULT As per suggestion in https://groups.google.com/forum/?utm_medium=email_source=footer#!topic/gremlin-users

[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...

2016-06-07 Thread SergeVil
GitHub user SergeVil opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/332 if there is no edge label in the GraphML file, then use Edge.DEFAULT As per suggestion in https://groups.google.com/forum/?utm_medium=email_source=footer#!topic/gremlin-users

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-09 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Sorry, I did not push it correct, I believe. Thank you for your help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 > Why waste the object creation using Optional? Instead, in one line, do: > edgeOutVertex.addEdge(null == edgeLabel ? Edge.DEFAULT_LABEL : edgeLabel, edgeInVertex, prop

[GitHub] incubator-tinkerpop issue #333: if there is no edge label in the GraphML fil...

2016-06-07 Thread SergeVil
Github user SergeVil commented on the issue: https://github.com/apache/incubator-tinkerpop/pull/333 Will take a look On Tue, Jun 7, 2016 at 2:18 PM, stephen mallette <notificati...@github.com> wrote: > Note that your PR is failing f