[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-10-06 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 1: I mentioned the difficulty of delivering a `RemoteConnection` implementation inside the TinkerPop repository above. 2: I commented in TINKERPOP-1490 that `async` is a reserved keyword

[GitHub] tinkerpop pull request #450: TINKERPOP-1489 Javascript GLV

2016-10-06 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/450#discussion_r82163673 --- Diff: gremlin-javascript/pom.xml --- @@ -0,0 +1,132 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w

[GitHub] tinkerpop issue #450: Javascript GLV

2016-10-05 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 Thanks @PommeVerte for getting a first look at it so fast. About `list()` and `one()`: - `next()` is a method exposed by the [Iterator protocol][1] which in newer versions

[GitHub] tinkerpop pull request #450: Javascript GLV

2016-10-05 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/450 Javascript GLV For [TINKERPOP-1489](https://issues.apache.org/jira/browse/TINKERPOP-1489). - Should work with any ES5 engine that supports CommonJs: tested with Nashorn and Node.js

[GitHub] tinkerpop pull request #450: TINKERPOP-1489 Javascript GLV

2016-10-06 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/450#discussion_r82168010 --- Diff: gremlin-javascript/pom.xml --- @@ -0,0 +1,132 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-11-11 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 > Note that there is a proposal for adding async iterator to JavaScript. Nice! I wasn't aware of that, I really like the syntax! I think the destiny of `next()` for async ops is a

[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

2016-11-16 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/478 I like the bottom-up approach and a really quick turnaround! Regarding the final API, given that it's an async flow designed for remote operations (request/response), it would be nice

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-10-31 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 I've added some fixes during the past weeks. I'll try to summarize the open issues with this patch to try to unblock it: A) Currently, the javascript GLV exposes `list()` instead

[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

2016-11-03 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/478 > What makes `toListAsync()` more "fully async" compared to `promise(traversal::toList)`? Internally, from a Java perspective anyway, `toListAsync()` does the same t

[GitHub] tinkerpop issue #478: TINKERPOP-1490 Implemented promise API for Traversal

2016-11-02 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/478 I think that, instead of doing blocking calls like `fn.apply()` on a thread pool, we could expose a fully async API. Something like `toListAsync()` that returns a `CompletableFuture<L

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2016-10-11 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 I like the idea about returning promises. I think it could be a method overload: user provides a function, use it as callback; otherwise, return a promise. For runtimes that don't support

[GitHub] tinkerpop issue #690: TINKERPOP-1744 Unwrap AggregateException for sync io o...

2017-08-10 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/690 VOTE: +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #690: TINKERPOP-1744 Unwrap AggregateException for sync io o...

2017-08-10 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/690 Does any other contributor has time to look into this PR? I would like to include it before the code freeze as it involves an API change (different exceptions thrown). --- If your project

[GitHub] tinkerpop issue #644: TINKERPOP-1552 Gremlin.Net

2017-07-11 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/644 I'm going to use my newly obtained committer status to say: +1! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

2017-07-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/670 I've reused the `methodsWithSpecificTypes` to generate `ValueMap()` with 2 type parameters. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

2017-07-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/670 I'm looking into the `g_V_HasXname_markoX_ValueMap_Next` failure on gremlin-dotnet, it looks like the generation process was producing: ``` public GraphTraversal<S, IDiction

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

2017-07-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/670 I've added support for GraphSON3 on the Gremlin .NET: - Added `GraphSON3Writer` and `GraphSON3Reader`. - Modified unit tests to run using GraphSON2 and GraphSON2. I'm getting

[GitHub] tinkerpop issue #670: TINKERPOP-1552 (master) Gremlin .NET

2017-07-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/670 np really! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #644: TINKERPOP-1552 Gremlin.Net

2017-07-03 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/644 Some minor nits: - Entries in root `.gitignore` file can be moved to `gremlin-dotnet/.gitignore` to avoid polluting the root file. - The coding style for generated enums is not very

[GitHub] tinkerpop issue #690: TINKERPOP-1744 Unwrap AggregateException for sync io o...

2017-08-09 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/690 Sorry, I've messed up with the name of the pull request, affecting JIRA ticket 1445 logs... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop pull request #690: TINKERPOP-1445 Unwrap AggregateException for sy...

2017-08-09 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/690 TINKERPOP-1445 Unwrap AggregateException for sync io operations https://issues.apache.org/jira/browse/TINKERPOP-1744 Includes a test expecting the underlying exception

[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...

2017-08-09 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132153059 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache

[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...

2017-08-09 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132153295 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache

[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...

2017-08-09 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132183072 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache

[GitHub] tinkerpop pull request #695: TINKERPOP-1489 JavaScript GLV

2017-08-17 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/695 TINKERPOP-1489 JavaScript GLV https://issues.apache.org/jira/browse/TINKERPOP-1489 Submitting the JavaScript for review to merge into tp32 after 3.2.6 code freeze and release

[GitHub] tinkerpop issue #620: TINKERPOP-1552 C# GLV: Generics and enum generation

2017-06-08 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/620 cc @FlorianHockmann --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop pull request #620: TINKERPOP-1552 C# GLV: Generics and enum genera...

2017-06-08 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/620 TINKERPOP-1552 C# GLV: Generics and enum generation Added type safety to traversal interface. For example: ```csharp Vertex vertex = g.V().Next(); // Compile time error Edge

[GitHub] tinkerpop pull request #622: TINKERPOP-1552: Remove unintended comment

2017-06-09 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/622 TINKERPOP-1552: Remove unintended comment You can merge this pull request into a Git repository by running: $ git pull https://github.com/jorgebay/tinkerpop csharp-glv-generics-fixes

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2017-05-18 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 ok thanks! I hope I'll get some time soon to work on the JavaScript GLV to leverage the new async execution introduced in TINKERPOP-1490. --- If your project is set up for it, you can reply

[GitHub] tinkerpop issue #450: TINKERPOP-1489 Javascript GLV

2017-06-05 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/450 Great! Any help is welcome! I have some bandwidth to dedicate on the JavaScript GLV this week, there are still several remaining items: - `DriverRemoteConnection` implementation

[GitHub] tinkerpop issue #619: Tinkerpop 1552 Reorganize Gremlin-DotNet project

2017-06-07 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/619 I gave the C# solution a try and all namespaces are nested within `Gremlin.Net`: `Gremlin.Net.Driver`, `Gremlin.Net.Process` and `Gremlin.Net.Structure`. Looks good to me! +1

[GitHub] tinkerpop issue #623: TINKERPOP-1552: Minor code cleanup for Gremlin.Net

2017-06-09 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/623 lgtm! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #626: Update Javascript GLV

2017-06-13 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/626 Update Javascript GLV Address feedback and provide maven integration: - Reorganize gremlin-javascript into node.js project - Simplify javascript code generators - Generate

[GitHub] tinkerpop issue #626: TINKERPOP-1489: Update Javascript GLV

2017-06-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/626 You can run the Node.js tests using `mvn clean install -DskipIntegrationTests=false` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop pull request #629: TINKERPOP-1552: Clean-up Gremlin-DotNet project...

2017-06-16 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/629#discussion_r122383928 --- Diff: gremlin-dotnet/glv/AnonymousTraversal.template --- @@ -27,6 +27,8 @@ using Gremlin.Net.Structure; // THIS IS A GENERATED FILE - DO

[GitHub] tinkerpop issue #629: TINKERPOP-1552: Clean-up Gremlin-DotNet project files

2017-06-16 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/629 Apart from my previous comment, lgtm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop issue #625: TINKERPOP-1552: Add support for authentication (Plain ...

2017-06-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/625 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 It's weird because 6a3fc39a912bec98707dd69d461955330627df10 was merged by @spmallette on master in 75502eef222b0dfc7aa83c2456ab319a9f9dd1a6 (he beat me to it because I was taking too long to do

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-18 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 The strong name for Gremlin.Net.dll assembly (generated using Gremlin.Net.csproj) is missing, we should add it in the template as well. ---

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 We forgot to consider that, as we are strong named assembly, we must avoid changing the assembly version for patch versions to minimize the need of user-defined binding redirects

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 I've got a failure on Gremlin Python: ``` [INFO] --- maven-antrun-plugin:1.8:run (setup-py-env) @ gremlin-python --- [WARNING] Parameter tasks is deprecated, use target instead

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 Recreating `tinkerpop:base`now... ---

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 Maybe I have to remove the previous tinkerpop:base image? ---

[GitHub] tinkerpop issue #716: TINKERPOP-1785 Added strong name signing for .NET comp...

2017-09-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/716 `dotnet pack gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj -c Release` generates the package containing with assembly with the intended attributes. VOTE +1 ---

[GitHub] tinkerpop issue #719: TINKERPOP-1731 Build for .NET working in docker

2017-09-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/719 dotnet tests pass on docker 🎉 Relevant lines: ``` Test run for /usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/bin/Release/netcoreapp1.0

[GitHub] tinkerpop pull request #716: TINKERPOP-1785 Added strong name signing for .N...

2017-09-20 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/716#discussion_r139970813 --- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template --- @@ -25,7 +25,9 @@ limitations under the License

[GitHub] tinkerpop issue #710: TINKERPOP-1730 Gremlin .NET: add support for GraphSON3

2017-09-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/710 Rebased onto master, tests pass with `mvn clean install -P gremlin-dotnet`. VOTE +1 I'll merge it once CI jobs finish. ---

[GitHub] tinkerpop issue #712: TINKERPOP-1752: Gremlin.Net: Generate completely type-...

2017-09-21 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/712 I wont be able to review it today, I'll probably have some time to look into this early next week. ---

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-08 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 About request pipelining, you can send in a queue one by one regardless of whether or not it was received. On the read side, once a message is received you issue a following call

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2017-09-08 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 I've removed support for Nashorn as part of #626 (see first comment). JavaScript engines don't provide a standard way to deal with and import modules, so supporting with multiple runtimes

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-11 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 I've filed the tickets 1774 and 1775 for the pool enhancements. ---

[GitHub] tinkerpop pull request #710: TINKERPOP-1730 Gremlin .NET: add support for Gr...

2017-09-11 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/710 TINKERPOP-1730 Gremlin .NET: add support for GraphSON3 https://issues.apache.org/jira/browse/TINKERPOP-1730 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] tinkerpop pull request #704: TINKERPOP-1766 Gremlin.Net: Add handling for cl...

2017-09-06 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/704#discussion_r137214097 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs --- @@ -74,6 +85,36 @@ private void AddConnection(Connection connection

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2017-09-06 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 Great! It would be really nice to have a working `GremlinJavaScriptScriptEngine`! ---

[GitHub] tinkerpop pull request #704: TINKERPOP-1766 Gremlin.Net: Add handling for cl...

2017-09-06 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/704#discussion_r137213383 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs --- @@ -74,6 +85,36 @@ private void AddConnection(Connection connection

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-06 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 I've left some line comments on the pr. Apart from the issue this patch is addressing, we should create separate tickets for issues related to the .NET driver pool: - Blocking (use

[GitHub] tinkerpop issue #710: TINKERPOP-1730 Gremlin .NET: add support for GraphSON3

2017-09-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/710 Thanks @FlorianHockmann for the feedback. I've addressed the issues you mentioned. About `ValueMap<TKey, TValue>()`, we can continue the discussion on the mailing list:

[GitHub] tinkerpop pull request #710: TINKERPOP-1730 Gremlin .NET: add support for Gr...

2017-09-12 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/710#discussion_r138317662 --- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/GraphTraversalTests.cs --- @@ -102,9 +102,9

[GitHub] tinkerpop pull request #:

2017-09-25 Thread jorgebay
Github user jorgebay commented on the pull request: https://github.com/apache/tinkerpop/commit/2bf649c22a86f6051dc932d016a4a0bee4756ad0#commitcomment-24544868 In gremlin-test/features/map/Select.feature: In gremlin-test/features/map/Select.feature on line 25: Shouldn't

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-25 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r140818483 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs --- @@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-25 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r140818845 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bindings.cs --- @@ -29,14 +32,42 @@ namespace Gremlin.Net.Process.Traversal public

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-25 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r140812056 --- Diff: gremlin-dotnet/glv/GraphTraversal.template --- @@ -65,9 +65,17 @@ namespace Gremlin.Net.Process.Traversal

[GitHub] tinkerpop pull request #712: TINKERPOP-1752: Gremlin.Net: Generate completel...

2017-09-26 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/712#discussion_r141109744 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs --- @@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2017-08-29 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 VOTE +1 `mvn clean install -DskipIntegrationTests=false` passes. API summary: - All methods are generated using groovy template files. - Naming conventions for js

[GitHub] tinkerpop issue #728: Do not strong-freeze dependencies

2017-10-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/728 VOTE +1 ---

[GitHub] tinkerpop issue #732: TINKERPOP-1799 Fixed serialization of Path objects for...

2017-10-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/732 VOTE +1 ---

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150497558 --- Diff: gremlin-python/src/main/jython/radish/feature_steps.py --- @@ -0,0 +1,231 @@ +''' +Licensed to the Apache Software Foundation (ASF

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150517817 --- Diff: gremlin-python/src/main/jython/radish/feature_steps.py --- @@ -0,0 +1,231 @@ +''' +Licensed to the Apache Software Foundation (ASF

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150476717 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs --- @@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150517147 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs --- @@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150477310 --- Diff: gremlin-python/pom.xml --- @@ -440,6 +440,17 @@ limitations under the License

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150502204 --- Diff: gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 I've rebased this on top of `tp32` (after #752 was merged) on my private fork and the issue I've mentioned earlier persists: https://travis-ci.org/jorgebay/tinkerpop/jobs/305703717#L7380 (Ubuntu

[GitHub] tinkerpop issue #752: TINKERPOP-1820 TravisCI: Add Gremlin.Net as job

2017-11-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/752 Landed in `tp32` and merged into `master`. ---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-22 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 Nice! lgtm VOTE +1 ---

[GitHub] tinkerpop pull request #757: TINKERPOP-1837 Gremlin .NET: Provide type coerc...

2017-11-22 Thread jorgebay
GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/757 TINKERPOP-1837 Gremlin .NET: Provide type coercion between IDictionary<K, V> instances https://issues.apache.org/jira/browse/TINKERPOP-1837 (The new Travis job comes in

[GitHub] tinkerpop issue #754: TINKERPOP-1827 Gremlin .NET: Test Suite Runner

2017-11-23 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/754 I rebased it against `tp32`, all tests pass. VOTE +1 ---

[GitHub] tinkerpop issue #760: TINKERPOP-1806 Consistent use of Gremlin.Net instead o...

2017-11-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/760 lgtm! VOTE +1 ---

[GitHub] tinkerpop pull request #753: TINKERPOP-1811 Fixed bytecode deserialization e...

2017-11-30 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/753#discussion_r154010923 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/JavaTranslator.java --- @@ -173,6 +173,12 @@ private Object invokeMethod(final

[GitHub] tinkerpop pull request #758: TINKERPOP-1734 DSL for Gremlin .NET

2017-11-30 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/758#discussion_r154014270 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -3218,3 +3218,93 @@ social.persons("marko").youngestFriendsAge() social.person

[GitHub] tinkerpop issue #754: TINKERPOP-1827 Gremlin .NET: Test Suite Runner

2017-11-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/754 I've rebased after #757 was merged. Included all previously skipped scenarios related to `IDictionary<K, V>` coercion. I included two type-related fixes to the Match and Group fe

[GitHub] tinkerpop pull request #754: TINKERPOP-1827 Gremlin .NET: Test Suite Runner

2017-11-27 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/754#discussion_r153125632 --- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs --- @@ -0,0 +1,472 @@ +#region License

[GitHub] tinkerpop pull request #757: TINKERPOP-1837 Gremlin .NET: Provide type coerc...

2017-11-27 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/757#discussion_r153128066 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs --- @@ -86,9 +87,61 @@ public void Reset

[GitHub] tinkerpop pull request #757: TINKERPOP-1837 Gremlin .NET: Provide type coerc...

2017-11-26 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/757#discussion_r153125359 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs --- @@ -86,9 +87,61 @@ public void Reset

[GitHub] tinkerpop pull request #757: TINKERPOP-1837 Gremlin .NET: Provide type coerc...

2017-11-27 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/757#discussion_r153151298 --- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs --- @@ -86,9 +87,61 @@ public void Reset

[GitHub] tinkerpop issue #753: TINKERPOP-1811 Fixed bytecode deserialization error me...

2017-11-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/753 Besides the suggestion from @dkuppitz , lgtm! VOTE +1 ---

[GitHub] tinkerpop issue #758: TINKERPOP-1734 DSL for Gremlin .NET

2017-11-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/758 VOTE +1 ---

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2017-11-30 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/695 I've implemented the support files for the gherkin test suite. Thanks to the test suite, I've found and fixed some bugs that were part of the original implementation. `mvn clean

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-16 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r151456526 --- Diff: gremlin-test/features/branch/Choose.feature --- @@ -0,0 +1,124 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-17 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r151697112 --- Diff: gremlin-test/features/map/Mean.feature --- @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-17 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r151698077 --- Diff: gremlin-test/features/sideEffect/Group.feature --- @@ -0,0 +1,244 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 Ah, I see its possible to run integration test using: ``` mvn clean install -pl :gremlin-dotnet-source,:gremlin-dotnet-tests -P gremlin-dotnet -DskipIntegrationTests=false

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150542775 --- Diff: gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] tinkerpop pull request #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/747#discussion_r150542730 --- Diff: gremlin-python/src/main/jython/radish/feature_steps.py --- @@ -0,0 +1,231 @@ +''' +Licensed to the Apache Software Foundation (ASF

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 `docker/build.sh -t -n -i` succeeds and tests pass. VOTE: +1 ---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 hm... with the new server start scripts, when running from within a directory like: ``` cd gremlin-dotnet mvn clean install -P gremlin-dotnet ``` I get the following

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 Fixes look good to me! I'm running integration tests locally on docker and I'll come back to give my plus one. ---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/747 @robertdale thanks for looking into it. I'm running `mvn clean install -DskipTests` followed by a `mvn clean install -pl :gremlin-dotnet-tests -P gremlin-dotnet -DskipIntegrationTests

[GitHub] tinkerpop issue #738: TINKERPOP-1820 Include Python and .NET GLVs on TravisC...

2017-11-20 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/738 I'm closing this one. I'll open a new one to only add Gremlin.Net tests support. ---

[GitHub] tinkerpop pull request #738: TINKERPOP-1820 Include Python and .NET GLVs on ...

2017-11-20 Thread jorgebay
Github user jorgebay closed the pull request at: https://github.com/apache/tinkerpop/pull/738 ---

  1   2   >