[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

Github user pauljackson commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98973022 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/FlatMapStep.java --- @@ -44,6 +45,7 @@ public

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

Github user pauljackson commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/548#discussion_r98972948 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GraphStep.java --- @@ -164,13 +164,13 @@ public int

[GitHub] tinkerpop issue #547: TINKERPOP-1589 Re-introduced CloseableIterator

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/547 Resubmitting this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #547: TINKERPOP-1589 Re-introduced CloseableIterator

Github user pauljackson closed the pull request at: https://github.com/apache/tinkerpop/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #548: TINKERPOP-1589 Re-introduced CloseableIterator

GitHub user pauljackson opened a pull request: https://github.com/apache/tinkerpop/pull/548 TINKERPOP-1589 Re-introduced CloseableIterator https://issues.apache.org/jira/browse/TINKERPOP-1589 Add support for the closing of `Iterators` returned from `Vertex.vertices

[GitHub] tinkerpop issue #548: TINKERPOP-1589 Re-introduced CloseableIterator

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/548 Hadoop build is failing for me, but this happens under normal conditions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop pull request #547: TINKERPOP-1589 Re-introduced CloseableIterator

GitHub user pauljackson opened a pull request: https://github.com/apache/tinkerpop/pull/547 TINKERPOP-1589 Re-introduced CloseableIterator https://issues.apache.org/jira/browse/TINKERPOP-1589 Add support for the closing of `Iterators` returned from `Vertex.vertices

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/457 Sorry, I’m fluent in git (shame). From reading, I gleaned that rebase is a type of merge from one branch to another. Since I created the pull request on tp31 I don’t understand what

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/457 Thank you Robert. This was adequate, I think, to give me some things to Google. I’ve run these commands from my local clone of my fork. It looks like that was all

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/457 It didn’t look intuitively correct, but I didn’t know what was normal. What’s the easiest way to make this right, right, right? Just start over and create a new pull request

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/457 Is there a stacktrace or other output that might help us figure this out? Specific test that fails? Thanks, -Paul From: stephen mallette [mailto:notificati

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/457 Looking at the Hadoop code gives no direct clue (to me), but it does seem to indicate that you are not using the 2.7.2 version, which might explain the inconsistent results. Maybe your local

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/456 OK, sorry about that. I closed it now. -Paul From: Jason Plurad [mailto:notificati...@github.com] Sent: Monday, October 31, 2016 12:13 PM To: apache/tinkerpop

[GitHub] tinkerpop pull request #456: TINKERPOP-1493 Groovy project doesn't build on ...

Github user pauljackson closed the pull request at: https://github.com/apache/tinkerpop/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #456: TINKERPOP-1493 Groovy project doesn't build on ...

GitHub user pauljackson opened a pull request: https://github.com/apache/tinkerpop/pull/456 TINKERPOP-1493 Groovy project doesn't build on Windows Removed support for user.dir property as it was being prepended to a fully qualified path and the second drive letter was making

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

Github user pauljackson commented on the issue: https://github.com/apache/tinkerpop/pull/456 There’s more differences than just the comments at the head of these files, so you could copy them from 3.2.3 if you are ok with those changes. From: Jason Plurad

[GitHub] tinkerpop pull request #457: TINKERPOP-1493 Groovy project doesn't build on ...

GitHub user pauljackson opened a pull request: https://github.com/apache/tinkerpop/pull/457 TINKERPOP-1493 Groovy project doesn't build on Windows Removed support for user.dir property as it was being prepended to a fully qualified path and the second drive letter was making