Github user twilmes commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
Yes, looks good to me VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/328#discussion_r65783485
--- Diff: docs/src/dev/provider/index.asciidoc ---
@@ -505,6 +505,11 @@ off for the test suite (the Maven SureFire Plugin is
configured this way
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/373
Looking good. VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/371
Looks good, nice choice for a recipe.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/358
I made a small update to `ReferencePath` to create new label Sets when a
patch is detached. This had been causing issues where the first set of labels
for a path where being shared across
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/374
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/382
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/546
It looks like when I run this against tp32 without
`MatchPredicateStrategy`, the `a` and `b` keys are missing from the results. I
think I figured out what the issue is. Without
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/546#discussion_r98270533
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -37,14
GitHub user twilmes opened a pull request:
https://github.com/apache/tinkerpop/pull/546
TINKERPOP-1583: PathRetractionStrategy retracts keys that are actually
needed
`PathRetractionStrategy` was not pushing `keepLabels` down into sibling
traversals of children with label
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/546
Made a small update to remove a dependency between `PathRetractionStrategy`
and `MatchPredicateStrategy`. I should also note, this PR addresses
TINKERPOP-1597. TINKERPOP-1597 was entered
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Looks good and good doc updates.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/549
`mvn clean install` was successful. Good set of test cases.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/380
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user twilmes opened a pull request:
https://github.com/apache/tinkerpop/pull/381
TINKERPOP-1405 - profile() doesn't like withPath()
Fixed a small bug in `StandardVerificationStrategy` that caused
verification to fail when `withPath` was used in conjunction with
`ProfileStep
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/408
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/437
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/449
The code and tests look good to me. `mvn clean install` also ran without
issue.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/404
Most excellent and good tests.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/387
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/435
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/434
This is a good batch of new work and updates. I was experimenting with the
`SubgraphStrategy` and wonder if `explain()` should be surfacing the filter
value when a `valueMap()` is used
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/445
I like how you pulled the chunks of processing out into separate methods in
`InlineFilterStrategy`. Cleans things up nicely.
VOTE: +1
---
If your project is set up for it, you can
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/480
Tests and code look good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/477
Tests passed and manual testing looked good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/483
Been having problems with traversal interrupted tests failing across many
branches but I ran other tests including neo4j and everything passed. Checked
out match retraction updates and they look
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/504#discussion_r88901766
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
---
@@ -86,7 +97,7 @@ public
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/469
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/471
Nice find. Looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/475
I grabbed the latest commit and things checked out. Looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/476
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/465
Nice, looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/454
The conversions and additional changes all look good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/508
`docker/build.sh -t -i -n -d` passed and I took a look at the docs and
confirmed they generated correctly.
VOTE: +1
---
If your project is set up for it, you can reply to this email
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/521
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/524
Nice set of updates.
`docker/build.sh -t -i` success
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/572
Merged into tp32 and closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twilmes closed the pull request at:
https://github.com/apache/tinkerpop/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/584
Great improvements, tests were successful and code looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/572#discussion_r107657353
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop 3.2.5
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/587
This is an impressive set of performance improvements. I was testing and
ran into an issue with this following query. It ran successfully against
`tp32`.
```
graph
GitHub user twilmes opened a pull request:
https://github.com/apache/tinkerpop/pull/572
TINKERPOP-1652 Disable PathRetractionStrategy strategy if VertexProgamStep
has LABELLED_PATH requirement
This PR updates `PathRetractionStrategy` to not run if the provided
traversal has
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/572#discussion_r106518558
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -191,6
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/572#discussion_r106646659
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategy.java
---
@@ -72,7
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/572#discussion_r106646840
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -191,6
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/591
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/592
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/602
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/601
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/597
Looks good
VOTE: +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/683
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/684
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user twilmes opened a pull request:
https://github.com/apache/tinkerpop/pull/676
TINKERPOP-1727: Bytecode object shallow copied when traversals are cloned
Added an explicit deep copy of `bytecode` in `DefaultTraversal.clone()`
VOTE: +1
```
[INFO] Apache
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/667
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/668
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/669
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/647
Looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/607
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/615
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user twilmes opened a pull request:
https://github.com/apache/tinkerpop/pull/731
TINKERPOP-1650: PathRetractionStrategy makes Match steps unsolvable
This bug was a result of an unintentionally shared set between a MatchStep
and WhereStep's. This caused the `p` label
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/729#discussion_r142936026
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MathStep.java
---
@@ -0,0 +1,171
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/725
I cleared out my images and rebuilt and all was good.
VOTE: +1
---
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/729
This is going to come in super handy.
A hearty VOTE: +1
---
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/729#discussion_r142801689
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MathStep.java
---
@@ -0,0 +1,171
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/893#discussion_r205649402
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -65,6 +65,33 @@ release where breaking changes are allowed.
See:
link:https
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/893#discussion_r205648775
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -1049,6 +1050,179 @@ inject(1,2).map {it.get() + 1}.map
{g.V(it.get()).next()}.values('name
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/908
Looks good @yura-ata. Did you re-target `master` again for a particular
reason?
VOTE: +1
---
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/891#discussion_r204065136
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -218,20 +220,33 @@ private void
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/891#discussion_r204067177
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -218,20 +220,33 @@ private void
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/891#discussion_r204065865
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java
---
@@ -218,20 +220,33 @@ private void
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Code & tests LGTM.
VOTE: +1
---
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/882#discussion_r201547477
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/search/path/ShortestPathVertexProgram.java
---
@@ -0,0 +1,557
72 matches
Mail list logo
