[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
ok - as long as we at least exercise the old stuff sufficiently then no need to bring them all back. I just saw these removed and didn't realize that there were others still hanging about. however you feel like handling it is fine in that case. [ Full content available at: https://github.com/apache/tinkerpop/pull/986 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
ok - as long as we at least exercise the old stuff sufficiently then no need to bring them all back. I just saw these removed and didn't realize that there were others still hanging about. [ Full content available at: https://github.com/apache/tinkerpop/pull/986 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
Mentioned this earlier, but let's keep the `valueMap(true)` tests since we have to maintain that deprecated code. There are other places as well obviously where the `valueMap(true)` tests need to be brought back. Just duplicate the test basically - one for the old way and one for the new way. [ Full content available at: https://github.com/apache/tinkerpop/pull/986 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
I don't think we should remove any old tests for the old signature. Those still need to be tested since we've only deprecated the approach. [ Full content available at: https://github.com/apache/tinkerpop/pull/986 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
needs javadoc `@deprecated As of release 3.4.0, replaced by {@link ...}` also
needed below in the `__` class.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #986: TINKERPOP-2059 Modulation of valueMap()
needs javadoc "@deprecated As of release 3.4.0, replaced by {@link ...}" also
needed below in the `__` class.
[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
